On Monday 23 November 2009, Dean Glazeski wrote: > The new play area is http://repo.or.cz/w/openocd/dnglaze.git.
Looking at the "armnandio" branch ... mostly OK, but: - ARM NAND I/O refactor code copying ... surely this belongs in src/target/arm.c for even more general reuse? I've been meaning to create that file, but you could easily start it. Eventually, maybe the run-algo code will want to automate this step. - ARM NAND I/O interface update ... please don't add lines of '*' on the right margins, they always end up getting trashed by someone who likes alternate tab widths or somesuch. Also, most of this is doc updates, which is what the preceding patch was supposed to do... IMO you should remove this patch, pushing the doc updates into the preceding patch and the small interface update into the following one which implements the change. (You haven't really changed the interface if none of the code acts different!!) Plus maybe combine the last patch with this too; similar reason: the interface change isn't done without all three fragments. (And none of these are complex enough to need standalone patches.) _______________________________________________ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
