Re: RFR: 8345348: CSS media feature queries [v9]

2025-04-10 Thread Andy Goryachev
On Thu, 10 Apr 2025 10:05:37 GMT, Michael Strauß wrote: >> Implementation of [CSS media >> queries](https://gist.github.com/mstr2/cbb93bff03e073ec0c32aac317b22de7). > > Michael Strauß has updated the pull request incrementally with one additional > commit since the last revision: > > add mor

Re: Stage Maximized/Iconified at the same time

2025-04-10 Thread Andy Goryachev
good catch! -andy From: openjfx-dev on behalf of Thiago Milczarek Sayão Date: Thursday, April 10, 2025 at 05:17 To: openjfx-dev Subject: Stage Maximized/Iconified at the same time Hi, I don't have a Mac to test, but on Linux and Windows, a window can be both maximized and iconified at the s

RFR: 8353632: [Linux] Undefined reference to PlatformSupport::OBSERVED_SETTINGS with C++14

2025-04-10 Thread Kevin Rushforth
Fixes a link error that occurs when using C++14 to compile and link JavaFX on Linux. in function `PlatformSupport::PlatformSupport(JNIEnv_*, _jobject*)': PlatformSupport.cpp:90: undefined reference to `PlatformSupport::OBSERVED_SETTINGS' The solution, proposed by @johanvos, is to define `Pla

Re: RFR: 8345348: CSS media feature queries [v9]

2025-04-10 Thread Michael Strauß
On Thu, 10 Apr 2025 16:05:53 GMT, Andy Goryachev wrote: > In the .md document, you make a reference to w3.org media queries, so one > question comes right away: do you eventually plan to implement the whole spec > as defined there, or we are really talking about a very small subset of > featur

Re: RFR: 8351867: No UI changes while iconified

2025-04-10 Thread Thiago Milczarek Sayao
On Thu, 13 Mar 2025 10:36:40 GMT, John Hendrikx wrote: > Adds code to trigger a scene update when a Window is restored > > This seems to solve https://bugs.openjdk.org/browse/JDK-8351867 and > https://bugs.openjdk.org/browse/JDK-8146479 About the comment on the change: After some experiments,

Re: [jfx24u] RFR: 8354182: Create release notes for JavaFX 24.0.1

2025-04-10 Thread Kevin Rushforth
On Wed, 9 Apr 2025 23:17:49 GMT, Kevin Rushforth wrote: > Release notes for JavaFX 24.0.1. > > Notes to reviewers: > > I used the following filter to pick the issues: > > https://bugs.openjdk.org/issues/?filter=47358 > > The original filter, with the backport IDs, is here: > > https://bugs.o

Re: RFR: 8353632: [Linux] Undefined reference to PlatformSupport::OBSERVED_SETTINGS with C++14

2025-04-10 Thread Kevin Rushforth
On Thu, 10 Apr 2025 16:11:07 GMT, Kevin Rushforth wrote: > Fixes a link error that occurs when using C++14 to compile and link JavaFX on > Linux. > > > in function `PlatformSupport::PlatformSupport(JNIEnv_*, _jobject*)': > PlatformSupport.cpp:90: undefined reference to > `PlatformSupport::OBS

Re: [jfx24u] RFR: 8354182: Create release notes for JavaFX 24.0.1

2025-04-10 Thread Andy Goryachev
On Wed, 9 Apr 2025 23:17:49 GMT, Kevin Rushforth wrote: > Release notes for JavaFX 24.0.1. > > Notes to reviewers: > > I used the following filter to pick the issues: > > https://bugs.openjdk.org/issues/?filter=47358 > > The original filter, with the backport IDs, is here: > > https://bugs.o

Re: RFR: 8345348: CSS media feature queries [v9]

2025-04-10 Thread Michael Strauß
On Thu, 10 Apr 2025 16:07:05 GMT, Andy Goryachev wrote: > Also, would it be possible to add Goals and Non-Goals to the .md, make it > more JEP-like? I added the two sections. - PR Comment: https://git.openjdk.org/jfx/pull/1655#issuecomment-2794556758

Stage Maximized/Iconified at the same time

2025-04-10 Thread Thiago Milczarek Sayão
Hi, I don't have a Mac to test, but on Linux and Windows, a window can be both maximized and iconified at the same time. It retains the maximized state when restored from being iconified. I've mentioned this topic before, but it's now clear to me that there's a bug in JavaFX related to this behav

Re: RFR: 8341670: [Text, TextFlow] Public API for Text Layout Info [v23]

2025-04-10 Thread Andy Goryachev
On Mon, 7 Apr 2025 18:54:00 GMT, Michael Strauß wrote: > I think a class should always be final or sealed by default contr-argument: testing. having extendable classes makes it easier to mock, although in the case of a platform your argument carries greater weight. I can make it `sealed`. --

Re: RFR: 8353845: com.sun.javafx.css.BitSet.equals(null) throws NPE [v2]

2025-04-10 Thread Ambarish Rapte
On Wed, 9 Apr 2025 09:07:40 GMT, Michael Strauß wrote: >> Fixes the bug that `BitSet.equals(null)` throws NPE. >> >> A single reviewer should be sufficient. > > Michael Strauß has updated the pull request incrementally with one additional > commit since the last revision: > > obj == null mo

Re: Stage Maximized/Iconified at the same time

2025-04-10 Thread Martin Fox
The maximized state on Mac is murkier than it is on Windows and Linux but, yes, a window can be both iconified and maximized at the same time. The code you referenced looks correct. If you de-iconify a maximized window the WindowEvent should be MAXIMIZE, not RESTORE. What steps are you taking w

Re: RFR: 8313424: JavaFX controls in the title bar [v60]

2025-04-10 Thread Michael Strauß
On Mon, 7 Apr 2025 18:49:51 GMT, Andy Goryachev wrote: >> Michael Strauß has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 77 commits: >> >> - doc update >> - Merge branch 'master' into feature/extended-window >> >># Confl

Re: Stage Maximized/Iconified at the same time

2025-04-10 Thread Thiago Milczarek Sayão
Hi Martin, I’ve started a broader effort to fix some open Linux bugs related to XWayland and Xorg here: https://github.com/openjdk/jfx-sandbox/compare/master...glass_gtk_bug_squashing It's a work in progress—I'm planning to roll back some changes to narrow the modifications and submit some of it

Re: RFR: 8351878: RichTextArea: copy/paste issues [v5]

2025-04-10 Thread Ziad El Midaoui
On Wed, 26 Mar 2025 14:36:39 GMT, Andy Goryachev wrote: >> Fixed several issues found in importing RTF text: >> >> - charset translation (brought back removed code) >> - missing font size attribute >> - missing strike-through attribute >> >> Also, HTML copy suffered from the following issues: >

Re: RFR: 8353632: [Linux] Undefined reference to PlatformSupport::OBSERVED_SETTINGS with C++14

2025-04-10 Thread Michael Strauß
On Thu, 10 Apr 2025 16:11:07 GMT, Kevin Rushforth wrote: > Fixes a link error that occurs when using C++14 to compile and link JavaFX on > Linux. > > > in function `PlatformSupport::PlatformSupport(JNIEnv_*, _jobject*)': > PlatformSupport.cpp:90: undefined reference to > `PlatformSupport::OBS

Re: RFR: 8313424: JavaFX controls in the title bar [v60]

2025-04-10 Thread Andy Goryachev
On Sun, 6 Apr 2025 09:29:33 GMT, Michael Strauß wrote: >> Implementation of >> [`EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09) >> and `EXTENDED_UTILITY` stage style. > > Michael Strauß has updated the pull request with a new target base due to a > merge or a rebase

Re: RFR: 8335547: Support multi-line prompt text for TextArea [v4]

2025-04-10 Thread Michael Strauß
On Tue, 25 Mar 2025 22:53:55 GMT, Ziad El Midaoui wrote: >> Added multi line prompt support for TextArea this will provide the ability >> to have multiple lines in textArea as expected, >> Also fixed tests to meet the new changes > > Ziad El Midaoui has updated the pull request incrementally wi

Help test the behavior of a multi-screen setup with both Mac and Windows

2025-04-10 Thread Thiago Milczarek Sayão
Hi, Could anyone with a multi-screen setup on Mac and/or Windows please share the results of the two buttons on this sample app? Your feedback would be greatly appreciated! On Ubuntu 24.04 the first button moves the Stage to the end of the first screen (bit weird). The second work as expected, it

Integrated: 8351878: RichTextArea: copy/paste issues

2025-04-10 Thread Andy Goryachev
On Thu, 13 Mar 2025 21:58:16 GMT, Andy Goryachev wrote: > Fixed several issues found in importing RTF text: > > - charset translation (brought back removed code) > - missing font size attribute > - missing strike-through attribute > > Also, HTML copy suffered from the following issues: > > - i

RFR: 8353845: com.sun.javafx.css.BitSet.equals(null) throws NPE

2025-04-10 Thread Michael Strauß
Fixes the bug that `BitSet.equals(null)` throws NPE. A single reviewer should be sufficient. - Commit messages: - fix equals(null) - failing test Changes: https://git.openjdk.org/jfx/pull/1766/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1766&range=00 Issue: https://

RFR: 8354337: GHA: Windows build fails with chmod permission error

2025-04-10 Thread Kevin Rushforth
After a recent update by GitHub to the GHA Windows Server 2022 runner, we get the following error in all GHA test runs: chmod: changing permissions of '.': Permission denied chmod: changing permissions of './bin': Permission denied ... This PR disables running `chmod -R` on the `artifacts/sdk

Re: RFR: 8353845: com.sun.javafx.css.BitSet.equals(null) throws NPE [v3]

2025-04-10 Thread Michael Strauß
On Wed, 9 Apr 2025 18:41:06 GMT, Andy Goryachev wrote: > https://github.com/openjdk/jfx/pull/1766/checks?check_run_id=40273913986 > > this is a weird failure, I've never seen it before. something happened at > cygwin (after yesterday outage) perhaps? > > @mstr2 could you re-run the windows job

Re: RFR: 8353845: com.sun.javafx.css.BitSet.equals(null) throws NPE [v2]

2025-04-10 Thread John Hendrikx
On Wed, 9 Apr 2025 12:27:31 GMT, Ambarish Rapte wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> obj == null > > modules/javafx.graphics/src/main/java/com/sun/javafx/css/BitSet.java line 540: > >> 538:

Re: Help test the behavior of a multi-screen setup with both Mac and Windows

2025-04-10 Thread John Hendrikx
Hi Thiago, I ran this on Windows.  My monitor setup is: Left: 3840x2160 (150%) -- top left coordinate (-2560, 0) (-2560 because of scaling) Middle: 3840x2160 (150%) -- this one has a top left coordinate of (0, 0) Right: 1920x1200 (100%) -- this one has a top left coordinate of (2560, 0) When sta

Re: RFR: 8341670: [Text, TextFlow] Public API for Text Layout Info [v24]

2025-04-10 Thread Andy Goryachev
> Please refer to > > https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md > > The RichTextArea control > ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom > control that needs non-trivial navigation within complex or wrapped text > needs a p

Re: Help test the behavior of a multi-screen setup with both Mac and Windows

2025-04-10 Thread Thiago Milczarek Sayão
Thanks John! I did not calculate the center, I just wanted to know the behaviour of setX() outside bounds and within bounds of the last screen. The GNOME window manager on Linux restricts programmatic movement of windows to prevent them from being moved outside screen boundaries. However, it allo

Re: TabPane overflow menu showing blanks

2025-04-10 Thread Andy Goryachev
All very good points, thank you for this writeup! This discussion relates to https://bugs.openjdk.org/browse/JDK-8353599 . I've been thinking how to handle this issue, and I am leaning to agree with the suggestion proposed in the ticket (some sort of menu item factory). The current "hacky" sol

Re: RFR: 8234153: [TEST_BUG] Rewrite Popup_parentWindow_Test [v2]

2025-04-10 Thread Andy Goryachev
On Mon, 7 Apr 2025 08:09:32 GMT, Lukasz Kostyra wrote: >> This change rewrites `Popup_parentWindow_Test` after a-long-time-ago-done >> changes to Popup public API. >> >> Popup used to have an `owner` and `parentWindow` properties. I couldn't >> track how far back that change happened so I can'

Re: RFR: 8335547: Support multi-line prompt text for TextArea [v4]

2025-04-10 Thread Kevin Rushforth
On Mon, 7 Apr 2025 15:14:52 GMT, Ziad El Midaoui wrote: >> One thing I am curious about: I don't see a similar stripping of newlines in >> the text itself for TextField, and yet it does render the whole string as if >> the newline had been stripped. Do you know why we need to strip it from >>

Re: RFR: 8341670: [Text, TextFlow] Public API for Text Layout Info [v23]

2025-04-10 Thread Andy Goryachev
On Sat, 5 Apr 2025 07:49:07 GMT, Michael Strauß wrote: >> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 48 commits: >> >> - Merge remote-tracking branch 'origin/master' into ag.text.layout.api >> - Merge remote-

Re: Help test the behavior of a multi-screen setup with both Mac and Windows

2025-04-10 Thread Martin Fox
On macOS 15.3.2 I get the same results as Andy. When I press the top button glass asks the OS to move the window offscreen but the OS shifts the location 40 units to the left so it’s partially onscreen. > On Apr 9, 2025, at 8:08 AM, Andy Goryachev wrote: > > Here are the results on macOS 15.3.

Re: RFR: 8354318: freetype.c: compilation error: 'incompatible pointer type' with gcc 14

2025-04-10 Thread Lukasz Kostyra
On Thu, 10 Apr 2025 22:41:02 GMT, Kevin Rushforth wrote: > This PR fixes a bug where a local variable was declared to be the wrong type, > causing an error at compilation time when compiling with gcc 14. gcc 14 > rejects assignments of incompatible pointer types without an explicit cast. > In

RFR: 8088343: Intermittent unit test failure in javafx.concurrent.ServiceLifecycleTest

2025-04-10 Thread Andy Goryachev
The code should not set the `Task.state` value to `CANCELLED` if the said task is already `SUCCEEDED` or `FAILED`. This is a product bug. - Commit messages: - 8088343 Changes: https://git.openjdk.org/jfx/pull/1769/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1769&range

Re: RFR: 8340464: [TestBug] Convert parametrized base tests to JUnit 5 [v9]

2025-04-10 Thread Jay Bhaskar
> Migrated JUnit 4 tests in the jafax.base module to JUnit 5, replacing > deprecated APIs, updating assertions, and refactoring test structures to > align with JUnit 5's improved features. Jay Bhaskar has updated the pull request incrementally with one additional commit since the last revision:

RFR: 8354318: freetype.c: compilation error: 'incompatible pointer type' with gcc 14

2025-04-10 Thread Kevin Rushforth
This PR fixes a bug where a local variable was declared to be the wrong type, causing an error at compilation time when compiling with gcc 14. gcc 14 rejects assignments of incompatible pointer types without an explicit cast. In this case, the solution is declare the variable to be of the correc

Re: RFR: 8354318: freetype.c: compilation error: 'incompatible pointer type' with gcc 14

2025-04-10 Thread Kevin Rushforth
On Thu, 10 Apr 2025 22:41:02 GMT, Kevin Rushforth wrote: > This PR fixes a bug where a local variable was declared to be the wrong type, > causing an error at compilation time when compiling with gcc 14. gcc 14 > rejects assignments of incompatible pointer types without an explicit cast. > In

Re: RFR: 8313424: JavaFX controls in the title bar [v61]

2025-04-10 Thread Michael Strauß
> Implementation of > [`EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09) > and `EXTENDED_UTILITY` stage style. Michael Strauß has updated the pull request incrementally with one additional commit since the last revision: remove import - Changes: - al

Re: RFR: 8354337: GHA: Windows build fails with chmod permission error

2025-04-10 Thread Kevin Rushforth
On Thu, 10 Apr 2025 22:00:35 GMT, Kevin Rushforth wrote: > After a recent update by GitHub to the GHA Windows Server 2022 runner, we get > the following error in all GHA test runs: > > > chmod: changing permissions of '.': Permission denied > chmod: changing permissions of './bin': Permission

Re: RFR: 8088343: Intermittent unit test failure in javafx.concurrent.ServiceLifecycleTest

2025-04-10 Thread Kevin Rushforth
On Thu, 10 Apr 2025 21:22:21 GMT, Andy Goryachev wrote: > The code should not set the `Task.state` value to `CANCELLED` if the said > task is already `SUCCEEDED` or `FAILED`. > > This is a product bug. Reviewers: @kevinrushforth @arapte - PR Comment: https://git.openjdk.org/jfx/p

Re: RFR: 8354337: GHA: Windows build fails with chmod permission error

2025-04-10 Thread Andy Goryachev
On Thu, 10 Apr 2025 22:00:35 GMT, Kevin Rushforth wrote: > After a recent update by GitHub to the GHA Windows Server 2022 runner, we get > the following error in all GHA test runs: > > > chmod: changing permissions of '.': Permission denied > chmod: changing permissions of './bin': Permission

Re: RFR: 8354337: GHA: Windows build fails with chmod permission error

2025-04-10 Thread Kevin Rushforth
On Thu, 10 Apr 2025 22:00:35 GMT, Kevin Rushforth wrote: > After a recent update by GitHub to the GHA Windows Server 2022 runner, we get > the following error in all GHA test runs: > > > chmod: changing permissions of '.': Permission denied > chmod: changing permissions of './bin': Permission

Re: RFR: 8354337: GHA: Windows build fails with chmod permission error

2025-04-10 Thread Andy Goryachev
On Thu, 10 Apr 2025 22:00:35 GMT, Kevin Rushforth wrote: > After a recent update by GitHub to the GHA Windows Server 2022 runner, we get > the following error in all GHA test runs: > > > chmod: changing permissions of '.': Permission denied > chmod: changing permissions of './bin': Permission

Re: RFR: 8345348: CSS media feature queries [v9]

2025-04-10 Thread Michael Strauß
> Implementation of [CSS media > queries](https://gist.github.com/mstr2/cbb93bff03e073ec0c32aac317b22de7). Michael Strauß has updated the pull request incrementally with one additional commit since the last revision: add more tests - Changes: - all: https://git.openjdk.org/jfx

Re: RFR: 8207333: [Linux, macOS] Column sorting is triggered always after context menu request on table header

2025-04-10 Thread Andy Goryachev
On Tue, 1 Apr 2025 17:31:14 GMT, Jose Pereda wrote: > Note: The JBS issue > [JDK-8207333](https://bugs.openjdk.org/browse/JDK-8207333) refers to Linux, > but it happens on macOS too. > > When a TableColumn has a ContextMenu, if the user right clicks on the > tableColumnHeader, the ContextMen

Re: RFR: 8350284: WebKit 620.1 crashes on startup on Windows x86 32-bit

2025-04-10 Thread Kevin Rushforth
On Tue, 8 Apr 2025 07:48:19 GMT, Roman Marchenko wrote: > All the crashes are on "`movaps`" instructions, like "`movaps xmmword ptr > [esi+0x30], xmm0`". > > "`movaps`" must operate with aligned addresses as >> When the source or destination operand is a memory operand, the operand must >> be

Re: RFR: 8340464: [TestBug] Convert parametrized base tests to JUnit 5 [v6]

2025-04-10 Thread Ambarish Rapte
On Sat, 5 Apr 2025 05:27:40 GMT, Jay Bhaskar wrote: >> Migrated JUnit 4 tests in the jafax.base module to JUnit 5, replacing >> deprecated APIs, updating assertions, and refactoring test structures to >> align with JUnit 5's improved features. > > Jay Bhaskar has updated the pull request increm

Re: RFR: 8234153: [TEST_BUG] Rewrite Popup_parentWindow_Test [v2]

2025-04-10 Thread Lukasz Kostyra
On Wed, 9 Apr 2025 07:45:57 GMT, Ambarish Rapte wrote: >> Lukasz Kostyra has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Replace fail() calls with assertions > > modules/javafx.graphics/src/test/java/test/javafx/stage/Popup_owner_Test.ja