On Thu, 10 Apr 2025 16:11:07 GMT, Kevin Rushforth <k...@openjdk.org> wrote:

> Fixes a link error that occurs when using C++14 to compile and link JavaFX on 
> Linux.
> 
> 
> in function `PlatformSupport::PlatformSupport(JNIEnv_*, _jobject*)':
> PlatformSupport.cpp:90: undefined reference to 
> `PlatformSupport::OBSERVED_SETTINGS'
> 
> 
> The solution, proposed by @johanvos, is to define 
> `PlatformSupport::OBSERVED_SETTINGS` in `PlatformSupport.cpp`.
> 
> I have tested this using gcc 13.2 and 14.2 using C++17 and it builds and runs 
> as expected. Johan has already tested a variant of this on C++14, but I will 
> wait for his explicit review.

LGTM

-------------

Marked as reviewed by mstrauss (Reviewer).

PR Review: https://git.openjdk.org/jfx/pull/1768#pullrequestreview-2758062612

Reply via email to