On Thu, 6 Mar 2025 02:50:33 GMT, Nir Lisker wrote:
> The int-based Dimension is only used by Rectangle even if in another class
I've taken another look. Rectangle is not using this class at all. I think it
would be much better to give the GTK screencast logic its own little int/int
record (n
On Mon, 2 Dec 2024 14:34:08 GMT, Alexander Zvegintsev
wrote:
>> Thanks @azvegint. If the `int`-based dimensions are coupled with
>> `com.sun.javafx.geom.Rectangle` (and from the code, that's the only place
>> they are used at), would you object to making `Dimension` an inner class of
>> `Rect
On Mon, 2 Dec 2024 14:34:08 GMT, Alexander Zvegintsev
wrote:
>> Thanks @azvegint. If the `int`-based dimensions are coupled with
>> `com.sun.javafx.geom.Rectangle` (and from the code, that's the only place
>> they are used at), would you object to making `Dimension` an inner class of
>> `Rect
On Mon, 27 Jan 2025 17:28:14 GMT, Andy Goryachev wrote:
>> I'm not familiar with these methods, but I did wonder why we need extra
>> implementations in the initial comment.
>
> looks like dead code left over from the original implementation.
>
> I removed the class along with the two methods a
On Mon, 27 Jan 2025 16:56:21 GMT, Nir Lisker wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/geom/Dimension2Df.java
>> line 34:
>>
>>> 32: * @see javafx.geometry.Dimension2D Dimension2D - doubles
>>> 33: */
>>> 34: public record Dimension2Df(float width, float height) {}
>>
>>
On Mon, 27 Jan 2025 16:36:28 GMT, Andy Goryachev wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address review comments
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/geom/Dimension2Df.java
> line 34:
>
On Sat, 25 Jan 2025 07:04:41 GMT, Nir Lisker wrote:
>> A small refactoring of the Dimension classes.
>>
>> * `com.sun.javafx.geom.Dimension` was removed and its uses were replaced by
>> `com.sun.javafx.geom.Dimension2D`.
>> * `com.sun.javafx.geom.Dimension2D` became a record.
>> * `javafx.geome
On Mon, 2 Dec 2024 19:45:47 GMT, Kevin Rushforth wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/geom/Dimension2D.java
>> line 31:
>>
>>> 29: * A 2D dimension object that contains a width and a height.
>>> 30: */
>>> 31: public record Dimension2D(float width, float height) {}
>
On Mon, 2 Dec 2024 19:13:20 GMT, Andy Goryachev wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address review comments
>
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/gtk/screencast/TokenStorage.java
> l
> A small refactoring of the Dimension classes.
>
> * `com.sun.javafx.geom.Dimension` was removed and its uses were replaced by
> `com.sun.javafx.geom.Dimension2D`.
> * `com.sun.javafx.geom.Dimension2D` became a record.
> * `javafx.geometry.Dimension2D`: fields became `final`.
>
> I'm not sure w
On Mon, 2 Dec 2024 14:34:08 GMT, Alexander Zvegintsev
wrote:
>> Thanks @azvegint. If the `int`-based dimensions are coupled with
>> `com.sun.javafx.geom.Rectangle` (and from the code, that's the only place
>> they are used at), would you object to making `Dimension` an inner class of
>> `Rect
On Fri, 29 Nov 2024 17:00:42 GMT, Nir Lisker wrote:
> A small refactoring of the Dimension classes.
>
> * `com.sun.javafx.geom.Dimension` was removed and its uses were replaced by
> `com.sun.javafx.geom.Dimension2D`.
> * `com.sun.javafx.geom.Dimension2D` became a record.
> * `javafx.geometry.Di
On Fri, 29 Nov 2024 17:00:42 GMT, Nir Lisker wrote:
> A small refactoring of the Dimension classes.
>
> * `com.sun.javafx.geom.Dimension` was removed and its uses were replaced by
> `com.sun.javafx.geom.Dimension2D`.
> * `com.sun.javafx.geom.Dimension2D` became a record.
> * `javafx.geometry.Di
On Mon, 2 Dec 2024 19:18:18 GMT, Andy Goryachev wrote:
>> A small refactoring of the Dimension classes.
>>
>> * `com.sun.javafx.geom.Dimension` was removed and its uses were replaced by
>> `com.sun.javafx.geom.Dimension2D`.
>> * `com.sun.javafx.geom.Dimension2D` became a record.
>> * `javafx.ge
On Fri, 29 Nov 2024 17:00:42 GMT, Nir Lisker wrote:
> A small refactoring of the Dimension classes.
>
> * `com.sun.javafx.geom.Dimension` was removed and its uses were replaced by
> `com.sun.javafx.geom.Dimension2D`.
> * `com.sun.javafx.geom.Dimension2D` became a record.
> * `javafx.geometry.Di
On Mon, 2 Dec 2024 11:25:14 GMT, Nir Lisker wrote:
> would you object to making Dimension an inner class of Rectangle?
I am fine with it.
-
PR Comment: https://git.openjdk.org/jfx/pull/1653#issuecomment-2511707325
On Fri, 29 Nov 2024 17:00:42 GMT, Nir Lisker wrote:
> A small refactoring of the Dimension classes.
>
> * `com.sun.javafx.geom.Dimension` was removed and its uses were replaced by
> `com.sun.javafx.geom.Dimension2D`.
> * `com.sun.javafx.geom.Dimension2D` became a record.
> * `javafx.geometry.Di
On Mon, 2 Dec 2024 02:19:46 GMT, Alexander Zvegintsev
wrote:
>> A small refactoring of the Dimension classes.
>>
>> * `com.sun.javafx.geom.Dimension` was removed and its uses were replaced by
>> `com.sun.javafx.geom.Dimension2D`.
>> * `com.sun.javafx.geom.Dimension2D` became a record.
>> * `ja
On Fri, 29 Nov 2024 17:00:42 GMT, Nir Lisker wrote:
> A small refactoring of the Dimension classes.
>
> * `com.sun.javafx.geom.Dimension` was removed and its uses were replaced by
> `com.sun.javafx.geom.Dimension2D`.
> * `com.sun.javafx.geom.Dimension2D` became a record.
> * `javafx.geometry.Di
On Fri, 29 Nov 2024 17:00:42 GMT, Nir Lisker wrote:
> A small refactoring of the Dimension classes.
>
> * `com.sun.javafx.geom.Dimension` was removed and its uses were replaced by
> `com.sun.javafx.geom.Dimension2D`.
> * `com.sun.javafx.geom.Dimension2D` became a record.
> * `javafx.geometry.Di
On Fri, 29 Nov 2024 17:00:42 GMT, Nir Lisker wrote:
> A small refactoring of the Dimension classes.
>
> * `com.sun.javafx.geom.Dimension` was removed and its uses were replaced by
> `com.sun.javafx.geom.Dimension2D`.
> * `com.sun.javafx.geom.Dimension2D` became a record.
> * `javafx.geometry.Di
On Fri, 29 Nov 2024 17:00:42 GMT, Nir Lisker wrote:
> A small refactoring of the Dimension classes.
>
> * `com.sun.javafx.geom.Dimension` was removed and its uses were replaced by
> `com.sun.javafx.geom.Dimension2D`.
> * `com.sun.javafx.geom.Dimension2D` became a record.
> * `javafx.geometry.Di
A small refactoring of the Dimension classes.
* `com.sun.javafx.geom.Dimension` was removed and its uses were replaced by
`com.sun.javafx.geom.Dimension2D`.
* `com.sun.javafx.geom.Dimension2D` became a record.
* `javafx.geometry.Dimension2D`: fields became `final`.
I'm not sure we need the imple
23 matches
Mail list logo
