On Fri, 29 Nov 2024 17:00:42 GMT, Nir Lisker <nlis...@openjdk.org> wrote:
> A small refactoring of the Dimension classes. > > * `com.sun.javafx.geom.Dimension` was removed and its uses were replaced by > `com.sun.javafx.geom.Dimension2D`. > * `com.sun.javafx.geom.Dimension2D` became a record. > * `javafx.geometry.Dimension2D`: fields became `final`. > > I'm not sure we need the implementation class at all considering we are free > to use the public one. Not sure if it helps, but when working on https://github.com/openjdk/jfx/pull/1462, I also found that inconsistencies. Sometimes `doubl`e is used and later 'degraded' to a `float`, sometimes a `float` is promoted to a `double`. And as we found here, `int` is used but later changed to `float`. I'm not sure why this happens, but maybe worth to take a deeper look. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1653#issuecomment-2511601492
