On Mon, 27 Jan 2025 16:56:21 GMT, Nir Lisker <[email protected]> wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/geom/Dimension2Df.java
>> line 34:
>>
>>> 32: * @see javafx.geometry.Dimension2D Dimension2D - doubles
>>> 33: */
>>> 34: public record Dimension2Df(float width, float height) {}
>>
>> is this class really needed?
>>
>> Looks like it's only referenced from `Arc2D::setArc()` and
>> `RectanglularShape::setFrame()`, as far as I can tell these two methods are
>> never called.
>>
>> Should all three be removed?
>
> I'm not familiar with these methods, but I did wonder why we need extra
> implementations in the initial comment.
looks like dead code left over from the original implementation.
I removed the class along with the two methods and jfx builds (**you need to
merge the latest master though**) and runs (i.e. shows arcs and rectangles)
just fine. Eclipse IDE also has no issues. I think we can remove these.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1653#discussion_r1930914516
