On Mon, 2 Dec 2024 19:45:47 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/geom/Dimension2D.java
>> line 31:
>>
>>> 29: * A 2D dimension object that contains a width and a height.
>>> 30: */
>>> 31: public record Dimension2D(float width, float height) {}
>>
>> I wish this class was named differently to signify it's based on float...
>
> Most of the classes in this package are based on floats. As this is an
> internal class, adding a comment seems sufficient.
I changed the names of the non-public classes to indicate the types they use,
it's just easier to see at a glance.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1653#discussion_r1929490331
