On Mon, 2 Dec 2024 19:13:20 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Nir Lisker has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address review comments > > modules/javafx.graphics/src/main/java/com/sun/glass/ui/gtk/screencast/TokenStorage.java > line 372: > >> 370: affectedScreenBounds >> 371: .stream() >> 372: .map(rectangle -> new Dimension2D(rectangle.width, >> rectangle.height)) > > the largest positive integer that can be stored in a float exactly is ~16M. > we are fine here. Yes, I don't think we need all of them, but I was asked to keep the types. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1653#discussion_r1929490995
