On Tue, 19 Nov 2024 04:34:05 GMT, Ambarish Rapte wrote:
>> Introduce a new build property `jfx.experimental.release.suffix` to be used
>> for the early access builds of an under development feature in JavaFX.
>> This property would be set to a value ONLY in a branch specific to an
>> experiment
On Sun, 17 Nov 2024 09:02:56 GMT, Johan Vos wrote:
>> If we do this, then here are some possible names:
>>
>> * jfx.experimental.release
>> * jfx.experimental.release.name
>> * jfx.variant.release
>> * jfx.variant.release.name
>> * jfx.variant
>> * jfx.feature.variant
>>
>> Thoughts?
>
>> If we
On Tue, 19 Nov 2024 04:34:05 GMT, Ambarish Rapte wrote:
>> Introduce a new build property `jfx.experimental.release.suffix` to be used
>> for the early access builds of an under development feature in JavaFX.
>> This property would be set to a value ONLY in a branch specific to an
>> experiment
On Mon, 18 Nov 2024 21:13:11 GMT, Kevin Rushforth wrote:
>> Ambarish Rapte has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> correcttion
>
> build.gradle line 706:
>
>> 704: relSuffix = jfxExperimentalFeatureName != "" ?
>> 705:
> Introduce a new build property `jfx.experimental.release.suffix` to be used
> for the early access builds of an under development feature in JavaFX.
> This property would be set to a value ONLY in a branch specific to an
> experiment in [jfx-sandbox](https://github.com/openjdk/jfx-sandbox) repo
On Fri, 15 Nov 2024 05:48:15 GMT, Ambarish Rapte wrote:
>> Introduce a new build property `jfx.experimental.release.suffix` to be used
>> for the early access builds of an under development feature in JavaFX.
>> This property would be set to a value ONLY in a branch specific to an
>> experiment
On Mon, 18 Nov 2024 20:56:44 GMT, Ambarish Rapte wrote:
>> Introduce a new build property `jfx.experimental.release.suffix` to be used
>> for the early access builds of an under development feature in JavaFX.
>> This property would be set to a value ONLY in a branch specific to an
>> experiment
> Introduce a new build property `jfx.experimental.release.suffix` to be used
> for the early access builds of an under development feature in JavaFX.
> This property would be set to a value ONLY in a branch specific to an
> experiment in [jfx-sandbox](https://github.com/openjdk/jfx-sandbox) repo
On Mon, 18 Nov 2024 14:46:57 GMT, Kevin Rushforth wrote:
> `jfx.experimental.feature.name` -- The name of the experimental feature
Thanks @kevinrushforth , Updated the property name as suggested.
-
PR Comment: https://git.openjdk.org/jfx/pull/1637#issuecomment-2483775795
> Introduce a new build property `jfx.experimental.release.suffix` to be used
> for the early access builds of an under development feature in JavaFX.
> This property would be set to a value ONLY in a branch specific to an
> experiment in [jfx-sandbox](https://github.com/openjdk/jfx-sandbox) repo
On Mon, 18 Nov 2024 11:52:12 GMT, Ambarish Rapte wrote:
>> Introduce a new build property `jfx.experimental.release.suffix` to be used
>> for the early access builds of an under development feature in JavaFX.
>> This property would be set to a value ONLY in a branch specific to an
>> experiment
On Mon, 18 Nov 2024 11:52:12 GMT, Ambarish Rapte wrote:
>> Introduce a new build property `jfx.experimental.release.suffix` to be used
>> for the early access builds of an under development feature in JavaFX.
>> This property would be set to a value ONLY in a branch specific to an
>> experiment
> Introduce a new build property `jfx.experimental.release.suffix` to be used
> for the early access builds of an under development feature in JavaFX.
> This property would be set to a value ONLY in a branch specific to an
> experiment in [jfx-sandbox](https://github.com/openjdk/jfx-sandbox) repo
On Sat, 16 Nov 2024 15:12:29 GMT, Kevin Rushforth wrote:
>> Ambarish Rapte has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains two additional
>> com
On Sun, 17 Nov 2024 09:06:00 GMT, Johan Vos wrote:
>>> I know I'm a broken record on this topic, but if possible, it would be
>>> great if (parts of) this logic can be moved into a separate file in order
>>> to make the build.gradle smaller and more readable.
>>
>> Also at the risk of sounding
On Sat, 16 Nov 2024 22:36:17 GMT, Kevin Rushforth wrote:
> If we do this, then here are some possible names:
>
> * jfx.experimental.release
> * jfx.experimental.release.name
> * jfx.variant.release
> * jfx.variant.release.name
> * jfx.variant
> * jfx.feature.variant
>
> Thoughts?
I don't have
On Sat, 16 Nov 2024 22:32:30 GMT, Kevin Rushforth wrote:
> > It is a bit confusing to have "jfx.release.suffix" and
> > "jfx.experimental.release.suffix" where the former refers to an artifact
> > property and the latter refers to a major feature/variant/... like metal.
>
> I think you have a
On Sat, 16 Nov 2024 19:43:07 GMT, Nir Lisker wrote:
>> I agree with that. It is often useful to have timestamp info in the builds
>> during development.
>> I know I'm a broken record on this topic, but if possible, it would be great
>> if (parts of) this logic can be moved into a separate file
On Sat, 16 Nov 2024 18:32:10 GMT, Johan Vos wrote:
> It is a bit confusing to have "jfx.release.suffix" and
> "jfx.experimental.release.suffix" where the former refers to an artifact
> property and the latter refers to a major feature/variant/... like metal.
I think you have a good point. May
On Fri, 15 Nov 2024 05:48:15 GMT, Ambarish Rapte wrote:
>> Introduce a new build property `jfx.experimental.release.suffix` to be used
>> for the early access builds of an under development feature in JavaFX.
>> This property would be set to a value ONLY in a branch specific to an
>> experiment
On Sat, 16 Nov 2024 18:27:02 GMT, Johan Vos wrote:
> I know I'm a broken record on this topic, but if possible, it would be great
> if (parts of) this logic can be moved into a separate file in order to make
> the build.gradle smaller and more readable.
Also at the risk of sounding like a brok
On Sat, 16 Nov 2024 16:16:58 GMT, Kevin Rushforth wrote:
> > I might be confused, but wasn't the idea to use a new property (e.g.
> > jfx.feature.variant) instead of overloading the existing jfx.release.suffix?
>
> This PR does add a new property in
> `build.properties`,`jfx.experimental.relea
On Fri, 15 Nov 2024 05:48:15 GMT, Ambarish Rapte wrote:
>> Introduce a new build property `jfx.experimental.release.suffix` to be used
>> for the early access builds of an under development feature in JavaFX.
>> This property would be set to a value ONLY in a branch specific to an
>> experiment
On Sat, 16 Nov 2024 15:09:40 GMT, Kevin Rushforth wrote:
>> Ambarish Rapte has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains two additional
>> com
On Sat, 16 Nov 2024 15:37:22 GMT, Johan Vos wrote:
> I might be confused, but wasn't the idea to use a new property (e.g.
> jfx.feature.variant) instead of overloading the existing jfx.release.suffix?
This PR does add a new property in
`build.properties`,`jfx.experimental.release.suffix`, and
On Fri, 15 Nov 2024 05:48:15 GMT, Ambarish Rapte wrote:
>> Introduce a new build property `jfx.experimental.release.suffix` to be used
>> for the early access builds of an under development feature in JavaFX.
>> This property would be set to a value ONLY in a branch specific to an
>> experiment
On Thu, 14 Nov 2024 12:02:02 GMT, Ambarish Rapte wrote:
>> Introduce a new build property `jfx.experimental.release.suffix` to be used
>> for the early access builds of an under development feature in JavaFX.
>> This property would be set to a value ONLY in a branch specific to an
>> experiment
> Introduce a new build property `jfx.experimental.release.suffix` to be used
> for the early access builds of an under development feature in JavaFX.
> This property would be set to a value ONLY in a branch specific to an
> experiment in [jfx-sandbox](https://github.com/openjdk/jfx-sandbox) repo
On Thu, 14 Nov 2024 12:02:02 GMT, Ambarish Rapte wrote:
>> Introduce a new build property `jfx.experimental.release.suffix` to be used
>> for the early access builds of an under development feature in JavaFX.
>> This property would be set to a value ONLY in a branch specific to an
>> experiment
On Thu, 14 Nov 2024 12:01:29 GMT, Ambarish Rapte wrote:
> Introduce a new build property `jfx.experimental.release.suffix` to be used
> for the early access builds of an under development feature in JavaFX.
> This property would be set to a value ONLY in a branch specific to an
> experiment in
Introduce a new build property `jfx.experimental.release.suffix` to be used for
the early access builds of an under development feature in JavaFX.
This property would be set to a value ONLY in a branch specific to an
experiment in [jfx-sandbox](https://github.com/openjdk/jfx-sandbox) repo.
For ex
On Thu, 14 Nov 2024 12:01:29 GMT, Ambarish Rapte wrote:
> Introduce a new build property `jfx.experimental.release.suffix` to be used
> for the early access builds of an under development feature in JavaFX.
> This property would be set to a value ONLY in a branch specific to an
> experiment in
32 matches
Mail list logo
