On Sat, 16 Nov 2024 15:12:29 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Ambarish Rapte has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains two additional >> commits since the last revision: >> >> - Merge branch 'master' into exp-suffix >> - 8343196: Add build property to identify experimental builds of JavaFX > > build.properties line 42: > >> 40: >> 41: # The experimental release suffix is set only in jfx-sandbox repository >> 42: # for a speficic branch. When this property is set it overrides > > Do you want to say something about it needing to start with a `-`? Or do you > think the example of `-ea` above will be clear enough? Added a comment to describe the use of `-`, with example of `-metal` and -`d3d12`. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1637#discussion_r1846451799
