On Mon, 18 Nov 2024 11:52:12 GMT, Ambarish Rapte <ara...@openjdk.org> wrote:
>> Introduce a new build property `jfx.experimental.release.suffix` to be used >> for the early access builds of an under development feature in JavaFX. >> This property would be set to a value ONLY in a branch specific to an >> experiment in [jfx-sandbox](https://github.com/openjdk/jfx-sandbox) repo. >> For example: >> For the metal branch in jfx-sandbox repo, it would be set to `-metal`. The >> javafx.version for the early access build generated from that branch would >> be `24-metal`. >> >> And it would always be empty for master branch in both main jfx repo and in >> jfx-sandbox repo. >> This change has no effect on a regular developer build from master branch. > > Ambarish Rapte has updated the pull request incrementally with one additional > commit since the last revision: > > review comments I'd rather have the property be something without `suffix` for the reasons Johan and I mentioned. Even though it's a little longer, I like a combination of what Johan and Nir suggested: `jfx.experimental.feature.name` -- The name of the experimental feature No one will ever specify this on the command line or have to type it, so having it be more explicit is good, even though the name is a little long. You can say something like: Set this property to the name of the experimental feature for your branch. Do not include a dash in the name. For example, if you have a sandbox branch named `myfeature` you might set `jfx.experimental.feature.name=myfeature`. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1637#issuecomment-2483263319
