On Fri, 15 Nov 2024 05:48:15 GMT, Ambarish Rapte <ara...@openjdk.org> wrote:
>> Introduce a new build property `jfx.experimental.release.suffix` to be used >> for the early access builds of an under development feature in JavaFX. >> This property would be set to a value ONLY in a branch specific to an >> experiment in [jfx-sandbox](https://github.com/openjdk/jfx-sandbox) repo. >> For example: >> For the metal branch in jfx-sandbox repo, it would be set to `-metal`. The >> javafx.version for the early access build generated from that branch would >> be `24-metal`. >> >> And it would always be empty for master branch in both main jfx repo and in >> jfx-sandbox repo. >> This change has no effect on a regular developer build from master branch. > > Ambarish Rapte has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains two additional > commits since the last revision: > > - Merge branch 'master' into exp-suffix > - 8343196: Add build property to identify experimental builds of JavaFX Looks good. I left a couple comments and will reapprove if you decide to make the changes. build.gradle line 705: > 703: } else { > 704: relSuffix = jfxExperimentalReleaseSuffix != "" ? > 705: jfxExperimentalReleaseSuffix : jfxReleaseSuffix; One thought I had: we might also want to set `relOpt = "-${buildTimestamp}"` here like we do for internal builds so we always see a time stamp for experimental builds. What do you think? build.properties line 42: > 40: > 41: # The experimental release suffix is set only in jfx-sandbox repository > 42: # for a speficic branch. When this property is set it overrides Do you want to say something about it needing to start with a `-`? Or do you think the example of `-ea` above will be clear enough? ------------- Marked as reviewed by kcr (Lead). PR Review: https://git.openjdk.org/jfx/pull/1637#pullrequestreview-2440546348 PR Review Comment: https://git.openjdk.org/jfx/pull/1637#discussion_r1844995084 PR Review Comment: https://git.openjdk.org/jfx/pull/1637#discussion_r1844995524
