Re: Proposal: Focus Traversal API

2024-10-23 Thread Kevin Rushforth
plate, etc.) but we could have added applicationFocusOwnerProperty() etc. Do we need another brainstorming round? -andy *From: *openjfx-dev on behalf of Michael Strauß *Date: *Wednesday, October 23, 2024 at 10:58 *To: * *Cc: *openjfx-dev@openjdk.org *Subject: *Re: Proposal: Focus Traversa

Re: Proposal: Focus Traversal API

2024-10-23 Thread Michael Strauß
Maybe we can polish the naming a bit: When used as a transitive verb, "traverse" means (according to Merriam-Webster): to go or travel across or over, to move or pass along or through. MW gives the example: "light rays traversing a crystal". So one thing is moving (light rays), while the other th

Re: Proposal: Focus Traversal API

2024-10-23 Thread Michael Strauß
> > > *From: *openjfx-dev on behalf of Michael > Strauß > *Date: *Wednesday, October 23, 2024 at 10:05 > *To: * > *Cc: *openjfx-dev@openjdk.org > *Subject: *Re: Proposal: Focus Traversal API > > Maybe we can polish the naming a bit: > > When used as a transitive ve

Re: Proposal: Focus Traversal API

2024-10-23 Thread Michael Strauß
While I like "tryXYZ", I notice that this style of method naming has no precedence in the public API of JavaFX. This is my ranking of the names suggested so far: 1. moveFocus: short and concise, may be a bit assertive 2. requestFocusTraversal: a bit wordy, but says what it'll do 3. tryMoveFocus: g

Re: Proposal: Focus Traversal API

2024-10-23 Thread Andy Goryachev
o: Cc: openjfx-dev@openjdk.org<mailto:openjfx-dev@openjdk.org> <mailto:openjfx-dev@openjdk.org> Subject: Re: Proposal: Focus Traversal API How about „predictFocus“, which will return a Node without changing focus? This would give applications even more flexibility, because th

Re: Proposal: Focus Traversal API

2024-10-23 Thread Nir Lisker
methods (predict, infer, > contemplate, etc.) but we could have added applicationFocusOwnerProperty() > etc. > > > > Do we need another brainstorming round? > > > > -andy > > > > > > > > > > *From: *openjfx-dev > on behalf of Michael

Re: Proposal: Focus Traversal API

2024-10-23 Thread Michael Strauß
another brainstorming round? > > > > -andy > > > > > > > > > > *From: *openjfx-dev > on behalf of Michael Strauß > > *Date: *Wednesday, October 23, 2024 at 10:58 > *To: * > *Cc: *openjfx-dev@openjdk.org > > *Subject: *Re: Proposal: Foc

Re: Proposal: Focus Traversal API

2024-10-23 Thread Andy Goryachev
x-dev@openjdk.org Subject: Re: Proposal: Focus Traversal API How about „predictFocus“, which will return a Node without changing focus? This would give applications even more flexibility, because they can then decide if they want to go ahead and actually change focus by calling predictFocus()?.request

Re: Proposal: Focus Traversal API

2024-10-23 Thread Andy Goryachev
May be a simple traverse(TraversalDirection) would suffice? -andy From: openjfx-dev on behalf of Michael Strauß Date: Wednesday, October 23, 2024 at 10:05 To: Cc: openjfx-dev@openjdk.org Subject: Re: Proposal: Focus Traversal API Maybe we can polish the naming a bit: When used as a

Re: Proposal: Focus Traversal API

2024-10-23 Thread Andy Goryachev
like that. Maybe "requestTraversal" although it will expand auto-completion list that has 2 items already. Welcome any alternative, as long as it's not creat(). -andy From: openjfx-dev on behalf of Michael Strauß Date: Wednesday, October 23, 2024 at 10:05 To: Cc: openjfx-dev@openj

Re: Proposal: Focus Traversal API

2024-10-23 Thread Kevin Rushforth
October 22, 2024 at 12:22 *To: *John Hendrikx , openjfx-dev@openjdk.org *Subject: *Re: Proposal: Focus Traversal API Thank you. I completely disagree with the idea of adding a single method to Node and introducing 6 way enum, for the reasons provided earlier. Having said that, I am more in

Re: Proposal: Focus Traversal API

2024-10-22 Thread Andy Goryachev
-dev@openjdk.org Subject: Re: Proposal: Focus Traversal API Thank you. I completely disagree with the idea of adding a single method to Node and introducing 6 way enum, for the reasons provided earlier. Having said that, I am more interested in moving forward. If everyone feels more

Re: Proposal: Focus Traversal API

2024-10-22 Thread Andy Goryachev
k you for a lively discussion. -andy From: openjfx-dev on behalf of John Hendrikx Date: Monday, October 21, 2024 at 23:46 To: openjfx-dev@openjdk.org Subject: Re: Proposal: Focus Traversal API I already like this suggestion very much, as it is simple, concise and located exactly where you

Re: Proposal: Focus Traversal API

2024-10-21 Thread John Hendrikx
I already like this suggestion very much, as it is simple, concise and located exactly where you'd expect it (near `requestFocus`).  It offers the navigation options that FX offers in a programmatic way and doesn't need to cater to other methods, only what FX offers. I also have an alternative

Re: Proposal: Focus Traversal API

2024-10-21 Thread Andy Goryachev
d why anyone want to switch on method references or "modify control flow" where these APIs are clearly transmit-only so to speak. I just see no use case. -andy From: openjfx-dev on behalf of Michael Strauß Date: Monday, October 21, 2024 at 14:47 To: Cc: openjfx-dev@openjdk.org

Re: Proposal: Focus Traversal API

2024-10-21 Thread Michael Strauß
> Also, there seems to be little utility in creating the directionality enum - > the only reason to do so would, in my opinion, be within the context of a > traversal policy, something that appeared to be very controversial. I can't > but notice how the example you gave tries to solve the same

Re: Proposal: Focus Traversal API

2024-10-21 Thread Andy Goryachev
onday, October 21, 2024 at 10:13 To: Cc: openjfx-dev@openjdk.org Subject: Re: Proposal: Focus Traversal API I think it is a good idea to do the non-controversial part of this feature first. With regards to the API, I would prefer a single instance method on Node: Node moveFocus(FocusTraversa

Re: Proposal: Focus Traversal API

2024-10-21 Thread Michael Strauß
I think it is a good idea to do the non-controversial part of this feature first. With regards to the API, I would prefer a single instance method on Node: Node moveFocus(FocusTraversalKind); Where FocusTraversalKind is an enum with values UP, DOWN, LEFT, RIGHT, NEXT, and PREVIOUS. Note that

Re: Proposal: Focus Traversal API

2024-10-18 Thread Andy Goryachev
API for use in custom controls [2] Draft PR https://github.com/openjdk/jfx/pull/1604 From: openjfx-dev on behalf of Andy Goryachev Date: Tuesday, September 3, 2024 at 12:33 To: openjfx-dev@openjdk.org Subject: Proposal: Focus Traversal API Dear fellow developers: I'd like to propose

Re: [External] : Re: Proposal: Focus Traversal API

2024-09-26 Thread Martin Fox
e, I’m good. Many thanks. Martin > > References > > [0] InputMap > https://github.com/andy-goryachev-oracle/Test/tree/main/doc/InputMap > > > > > > From: Martin Fox > Date: Tuesday, September 24, 2024 at 13:30 > To: Andy Goryachev > Cc: OpenJF

Re: [External] : Re: Proposal: Focus Traversal API

2024-09-24 Thread John Hendrikx
On 24/09/2024 22:29, Martin Fox wrote: This proposal should give some quick background on how traversal key events are handled, specifically that controls should let the key events bubble up to the Scene to invoke traversal. And if the traversal keys are always going to be consumed by the Sce

Re: [External] : Re: Proposal: Focus Traversal API

2024-09-24 Thread Martin Fox
providing two requested features soon, or never. > > I would also encourage other members of the development community to voice > their opinion on the subject, perhaps there is something else we can do to > move forward. > > Thank you > -andy > > > From: John H

Re: [External] : Re: Proposal: Focus Traversal API

2024-09-24 Thread Andy Goryachev
I fully agree with Martin here. -andy From: Martin Fox Date: Wednesday, September 18, 2024 at 11:49 To: John Hendrikx Cc: Andy Goryachev , OpenJFX Subject: Re: [External] : Re: Proposal: Focus Traversal API John, Sorry I didn’t respond to this thread earlier. I’ve been looking at the code

Re: [External] : Re: Proposal: Focus Traversal API

2024-09-24 Thread Andy Goryachev
essibility regression with ScrollPane Is this a complete list? Did I miss anything? -andy From: John Hendrikx Date: Thursday, September 19, 2024 at 07:24 To: Andy Goryachev , openjfx-dev@openjdk.org Subject: Re: [External] : Re: Proposal: Focus Traversal API My apologies then, I was a bit

Re: [External] : Re: Proposal: Focus Traversal API

2024-09-19 Thread John Hendrikx
*To: *Andy Goryachev , openjfx-dev@openjdk.org *Subject: *Re: [External] : Re: Proposal: Focus Traversal API Andy, As you're not responding to any of the suggestions or any of my questions, but are only re-iterating points that I believe are not going to be a benefit to the long term via

Re: [External] : Re: Proposal: Focus Traversal API

2024-09-18 Thread Martin Fox
rhaps there is something else we can do to >> move forward. >> >> Thank you >> -andy >> >> >> From: John Hendrikx >> <mailto:john.hendr...@gmail.com> >> Date: Saturday, September 14, 2024 at 09:41 >> To: Andy Goryachev >

Re: [External] : Re: Proposal: Focus Traversal API

2024-09-18 Thread Andy Goryachev
last week or this week. Sorry, will definitely respond in detail early next week. -andy From: John Hendrikx Date: Tuesday, September 17, 2024 at 23:05 To: Andy Goryachev , openjfx-dev@openjdk.org Subject: Re: [External] : Re: Proposal: Focus Traversal API Andy, As you're not respondin

Re: [External] : Re: Proposal: Focus Traversal API

2024-09-17 Thread John Hendrikx
k you -andy *From: *John Hendrikx *Date: *Saturday, September 14, 2024 at 09:41 *To: *Andy Goryachev , openjfx-dev@openjdk.org *Subject: *[External] : Re: Proposal: Focus Traversal API Hi Andy, First let me say that when it comes to designing an API, you really need to take the time to thin

Re: [External] : Re: Proposal: Focus Traversal API

2024-09-17 Thread Andy Goryachev
From: John Hendrikx Date: Saturday, September 14, 2024 at 09:41 To: Andy Goryachev , openjfx-dev@openjdk.org Subject: [External] : Re: Proposal: Focus Traversal API Hi Andy, First let me say that when it comes to designing an API, you really need to take the time to think the solution through

Re: Proposal: Focus Traversal API

2024-09-14 Thread John Hendrikx
ust "copy" said code) Public API: Maybe some methods in Node, or some kind of static helper. 6. CSS styleable properties If we really want to give power to our users, and impress them with a flexible focus traversal API, then make these properties styleable. Benefit: allow users to p

Re: Proposal: Focus Traversal API

2024-09-13 Thread Andy Goryachev
To: openjfx-dev@openjdk.org Subject: Re: Proposal: Focus Traversal API Hi Andy / List, I've given this some thought first, without looking too much at the proposal. In my view, focus traversal should be implemented using events, and FX should provide standard handling of these events contro

Re: Proposal: Focus Traversal API

2024-09-11 Thread John Hendrikx
Hi Andy / List, I've given this some thought first, without looking too much at the proposal. In my view, focus traversal should be implemented using events, and FX should provide standard handling of these events controlled with properties (potentially even CSS stylable for easy mass changi

Proposal: Focus Traversal API

2024-09-03 Thread Andy Goryachev
Dear fellow developers: I'd like to propose the public focus traversal API: https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal.md Draft PR: https://github.com/openjdk/jfx/pull/1555 Your comments and suggestions will be warmly accepted and appreciated. T