On Thu, 15 Jun 2023 19:38:00 GMT, Andy Goryachev wrote:
> Modified the resize algorithm to work well with fractional scale, thanks for
> deeper understanding of the problem thanks to @hjohn and @mstr2 .
>
> Removed earlier manual tester in favor of the monkey tester.
>
> It is important to no
On Thu, 6 Jun 2024 23:47:44 GMT, Andy Goryachev wrote:
>> I'm having some doubts about the solution still. It is mentioned that this
>> problem can occur in text containing both LTR and RTL text together,
>> however, as far as I can see, a `TextRun` never contains a mix of text
>> directions.
On Thu, 6 Jun 2024 16:53:47 GMT, Andy Goryachev wrote:
> The code to reproduce was
>
> ```
> flow = new TextFlow(
> t("Arabic:", Color.RED),
> t(" ", Color.YELLOW),
> t("العربية", Color.GREEN),
> new Text("\n"),
>
.
>
> Made changes in `getPosX` of `TextRun` class to handle negative values.
>
> Tested the changes manually with the sample code present in the bug and using
> the MonkeyTester.
Karthik P K has updated the pull request incrementally with one additional
commit
On Fri, 31 May 2024 14:39:00 GMT, Karthik P K wrote:
> The issue is specific to Mac. The glyph positions returned from native side
> for complex text is not handled in the text render logic. This issue is
> observed only when trailing spaces are present along with LTR text mixed wi
.
>
> Made changes in `getPosX` of `TextRun` class to handle negative values.
>
> Tested the changes manually with the sample code present in the bug and using
> the MonkeyTester.
Karthik P K has updated the pull request incrementally with one additional
commit since the
On Sat, 1 Jun 2024 04:53:48 GMT, John Hendrikx wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/text/TextRun.java line
>> 332:
>>
>>> 330: return x;
>>> 331: }
>>> 332: int prevIdx = (glyphIndex - 1)<<1;
>>
>> would it be possible to add a
On Fri, 31 May 2024 17:21:56 GMT, Andy Goryachev wrote:
> Seems to work with the example in the ticket and the TextArea in the Monkey
> Tester. No ill effects on Windows. (Did not test it on Linux)
>
I tested the issue on Linux. It is not reproducible. So this is specific to Mac
only.
> Could
The issue is specific to Mac. The glyph positions returned from native side for
complex text is not handled in the text render logic. This issue is observed
only when trailing spaces are present along with LTR text mixed with RTL text
(Example: "Arabic: العربية").
Made changes in `getPosX` of `
On Thu, 23 May 2024 10:53:36 GMT, Thiago Milczarek Sayao
wrote:
>> This fixes two bugs appointed on the JBS issue:
>>
>> 1) Sometimes window was moving to the top left corner - seems to be a bug
>> somewhere in `gdk_window_get_origin` when used before map (a X concept when
>> the window appea
On Wed, 22 May 2024 21:28:47 GMT, Thiago Milczarek Sayao
wrote:
> This fixes two bugs appointed on the JBS issue:
>
> 1) Sometimes window was moving to the top left corner - seems to be a bug
> somewhere in `gdk_window_get_origin` when used before map (a X concept when
> the window appears).
On Fri, 17 May 2024 15:36:27 GMT, Andy Goryachev wrote:
>> This change replaces Character.isLetterOrDigit(char) which fails with
>> surrogate characters with Character.isLetterOrDigit(int).
>
> Andy Goryachev has updated the pull request with a new target base due to a
> merge or a rebase. The
On Tue, 7 May 2024 10:10:23 GMT, Karthik P K wrote:
> The `ComboBox` value was not set to previously selected value in the item
> list change listener when `setAll` method is used to change the items. Fixed
> the issue by restoring the selection in this case.
>
> Added a unit t
On Tue, 14 May 2024 22:27:25 GMT, Andy Goryachev wrote:
>> Karthik P K has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix JDK-8279139
>
> It looks like we have quite a few bugs related to different aspect
On Thu, 9 May 2024 09:38:31 GMT, Karthik P K wrote:
>> The `ComboBox` value was not set to previously selected value in the item
>> list change listener when `setAll` method is used to change the items. Fixed
>> the issue by restoring the selection in this case.
>>
//bugs.openjdk.org/browse/JDK-8279139) is also fixed with
> this change and added a unit test for the same.
Karthik P K has updated the pull request incrementally with one additional
commit since the last revision:
Fix JDK-8279139
-
Changes:
- all: https://git.openjdk.org/jfx/pu
On Tue, 7 May 2024 15:46:18 GMT, Andy Goryachev wrote:
>> Adds **Labeled.textTruncated** property which indicates when the text is
>> visually truncated (and the ellipsis string is inserted) in order to fit the
>> available width.
>>
>> The new property is being set by the code which computes
On Tue, 7 May 2024 14:56:57 GMT, Andy Goryachev wrote:
>> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/skin/Utils.java
>> line 218:
>>
>>> 216: * Computes the actual text to be shown in the Labeled with the
>>> text wrapping disabled:
>>> 217: * unmodified if it
On Mon, 6 May 2024 15:23:20 GMT, Andy Goryachev wrote:
>> Adds **Labeled.textTruncated** property which indicates when the text is
>> visually truncated (and the ellipsis string is inserted) in order to fit the
>> available width.
>>
>> The new property is being set by the code which computes
On Tue, 7 May 2024 10:10:23 GMT, Karthik P K wrote:
> The `ComboBox` value was not set to previously selected value in the item
> list change listener when `setAll` method is used to change the item list.
> Fixed the issue by restoring the selection in this case.
>
> Added
The `ComboBox` value was not set to previously selected value in the item list
change listener when `setAll` method is used to change the item list. Fixed the
issue by restoring the selection in this case.
Added a unit test to validate the fix
-
Commit messages:
- Fix item selecti
On Mon, 29 Apr 2024 21:27:41 GMT, Andy Goryachev wrote:
> If I were to fix the behavior (if we decide to fix the behavior of the
> nextWord function, that is), I would make it consistent with MS Word, but
> let's discuss.
>
The behaviour in MS word looks to be easy to understand and what we wo
On Fri, 19 Apr 2024 20:36:42 GMT, Andy Goryachev wrote:
>> This change replaces Character.isLetterOrDigit(char) which fails with
>> surrogate characters with Character.isLetterOrDigit(int).
>
> Andy Goryachev has updated the pull request with a new target base due to a
> merge or a rebase. The
On Thu, 25 Apr 2024 14:26:06 GMT, Karthik P K wrote:
> The text was not getting selected on adding the `TextField` to the scene
> initially, subsequently removing and adding the `TextField` to the scene
> selects the entire text present in the `TextField`.
>
> Made
The text was not getting selected on adding the `TextField` to the scene
initially, subsequently removing and adding the `TextField` to the scene
selects the entire text present in the `TextField`.
Made changes in the `TextFieldBehavior` constructor to select the text on
adding the `TextField`
On Tue, 23 Apr 2024 19:30:49 GMT, John Hendrikx wrote:
>> There are a number of tickets open related to text rendering:
>>
>> https://bugs.openjdk.org/browse/JDK-8314215
>>
>> https://bugs.openjdk.org/browse/JDK-8145496
>>
>> https://bugs.openjdk.org/browse/JDK-8129014
>>
>> They have in comm
On Mon, 12 Feb 2024 10:00:57 GMT, Karthik P K wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Change test to use the more common Arial font and add assumptions
>
> I ran the tests in
On Mon, 15 Apr 2024 15:41:19 GMT, eduardsdv wrote:
>> This change fixes the calculation of which nodes go to the toolbar and which
>> go to the overflow menu.
>> It is now determined before the nodes are removed from the scene graph.
>> This is important because the values returned by
>> ``Node
On Fri, 19 Apr 2024 16:14:27 GMT, Andy Goryachev wrote:
>> So, none of them can be reproduced on windows, only on mac.
>>
>> The #2 can be reproduced in the version before PR and after PR.
>>
>> The #3 is reproducible only with PR changes and in my opinion an other bug
>> in JavaFX, which is m
On Mon, 15 Apr 2024 15:41:19 GMT, eduardsdv wrote:
>> This change fixes the calculation of which nodes go to the toolbar and which
>> go to the overflow menu.
>> It is now determined before the nodes are removed from the scene graph.
>> This is important because the values returned by
>> ``Node
On Mon, 15 Apr 2024 15:41:19 GMT, eduardsdv wrote:
>> This change fixes the calculation of which nodes go to the toolbar and which
>> go to the overflow menu.
>> It is now determined before the nodes are removed from the scene graph.
>> This is important because the values returned by
>> ``Node
On Wed, 10 Apr 2024 11:47:28 GMT, drmarmac wrote:
>> This PR should fix the issue and cover all relevant cases with new tests.
>>
>> Note: This involves a small behavior change, as can be seen in
>> dblSpinner_testWrapAround_decrement_twoSteps() in SpinnerTest.java:749. With
>> this change the
On Wed, 10 Apr 2024 21:25:10 GMT, Andy Goryachev wrote:
>> Adds **Labeled.textTruncated** property which indicates when the text is
>> visually truncated (and the ellipsis string is inserted) in order to fit the
>> available width.
>>
>> The new property reacts to changes in the following prop
On Wed, 10 Apr 2024 21:28:16 GMT, Andy Goryachev wrote:
>> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/LabeledHelper.java
>> line 38:
>>
>>> 36: /**
>>> 37: * Returns true when the Labeled must compute the actual
>>> content width in computePrefWidth().
On Thu, 28 Mar 2024 21:44:49 GMT, Andy Goryachev wrote:
>> Adds **Labeled.textTruncated** property which indicates when the text is
>> visually truncated (and the ellipsis string is inserted) in order to fit the
>> available width.
>>
>> The new property reacts to changes in the following prop
On Thu, 28 Mar 2024 14:54:47 GMT, Andy Goryachev wrote:
>> Fixing missing @ OVERRIDES in tests.
>>
>> This is still a trivial change since all the spots are identified by the IDE.
>
> Andy Goryachev has updated the pull request with a new target base due to a
> merge or a rebase. The incrementa
On Thu, 28 Mar 2024 08:49:44 GMT, drmarmac wrote:
>> This PR removes potentially incorrect usages of Stream.peek().
>> The changed code should be covered by the tests that are already present.
>
> drmarmac has updated the pull request incrementally with two additional
> commits since the last re
On Fri, 22 Mar 2024 15:55:35 GMT, Andy Goryachev wrote:
> Fixing missing @ OVERRIDES in tests.
>
> This is still a trivial change since all the spots are identified by the IDE.
Changes looks good.
Found few file where `@Override` can be added for `start` method.
1. `BigGlyphIDTest.java`
2. `IN
On Thu, 21 Mar 2024 21:50:37 GMT, Andy Goryachev wrote:
> Using Eclipse IDE to remove unused imports in **demo apps** (3D, Ensemble,
> etc.) and update the copyright year to 2024. Using wildcard for more than 10
> static imports.
>
>
> --
>
> This is a trivial change (though fairly large), 1
On Wed, 27 Mar 2024 23:21:34 GMT, Nir Lisker wrote:
>> `forEach` is void, so we can not return a list afterwards.
>
> You don't need to return a list, you create it ahead of time like was done in
> line 167
>
> List indices = new ArrayList<>();
>
> and the add the elements in `forEach`.
> Why
On Wed, 27 Mar 2024 23:24:51 GMT, Marius Hanl wrote:
>>> In the java.util.stream package
>>> [docs](https://docs.oracle.com/en/java/javase/16/docs/api/java.base/java/util/stream/package-summary.html#SideEffects)
>>> it is mentioned that `forEach()` method operates only via side-effects. So
>>>
On Mon, 25 Mar 2024 22:36:48 GMT, Andy Goryachev wrote:
>> Further changes to the MonkeyTester application:
>>
>> - remember split pane divider ✔
>> - use 'private' instead of 'protected' in many cases ✔
>> - added more scripts to the 'writing systems' text sample ✔
>> - added RTL window control
On Sun, 24 Mar 2024 15:10:22 GMT, drmarmac wrote:
> This PR removes potentially incorrect usages of Stream.peek().
> The changed code should be covered by the tests that are already present.
modules/javafx.controls/src/main/java/javafx/scene/control/ControlUtils.java
line 176:
> 174:
On Mon, 25 Mar 2024 22:36:48 GMT, Andy Goryachev wrote:
>> Further changes to the MonkeyTester application:
>>
>> - remember split pane divider ✔
>> - use 'private' instead of 'protected' in many cases ✔
>> - added more scripts to the 'writing systems' text sample ✔
>> - added RTL window control
On Fri, 22 Mar 2024 18:23:41 GMT, Andy Goryachev wrote:
> > * In all the pages, under Region option, if we select MAX_VALUE for Min
> > Height or Min Width, the application hangs or whole window becomes white. I
> > observed this issue if we select MIN_VALUE or POSITIVE_INFINITY as well.
>
> w
On Wed, 20 Mar 2024 23:56:50 GMT, Andy Goryachev wrote:
>> Further changes to the MonkeyTester application:
>>
>> - remember split pane divider ✔
>> - use 'private' instead of 'protected' in many cases ✔
>> - added more scripts to the 'writing systems' text sample ✔
>> - added RTL window control
On Thu, 21 Mar 2024 07:18:28 GMT, Karthik P K wrote:
> Enabled a test in `SpinnerTest` class.
> Added comment to the editing test, why it can not be enabled. When Spinner
> value is set using `getEditor` `setText` method, the listener added to the
> spinner is not invoked. There i
On Thu, 21 Mar 2024 12:54:05 GMT, Kevin Rushforth wrote:
>> Karthik P K has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add bug id to ignore comment
>
> modules/javafx.controls/src/test/java/test/javafx/
; the expectation in this case.
> Other set of tests which are ignored are `LocalTimeSpinnerValueFactory`
> tests. Since these tests are unstable and fail only at certain time of the
> day, not enabling this test as well.
Karthik P K has updated the pull request incrementally with one addi
Enabled a test in `SpinnerTest` class.
Added comment to the editing test, why it can not be enabled. When Spinner
value is set using `getEditor` `setText` method, the listener added to the
spinner is not invoked. There is no bug for this issue. I'm not sure about the
expectation in this case.
Ot
On Tue, 19 Mar 2024 21:37:50 GMT, Kevin Rushforth wrote:
> I also suspect that Karthik was running in that mode. You can check the value
> of the `XDG_SESSION_TYPE` env var to see. All robot tests that read the
> screen will fail on Wayland until
> [JDK-8326712](https://bugs.openjdk.org/browse
On Tue, 19 Mar 2024 13:16:48 GMT, Lukasz Kostyra wrote:
>> There were two different problems with this test's stability and HiDPI and
>> both were fixed with this change.
>>
>> The whole reason for this tests lack of stability comes with how Windows
>> calculates window position when using HiD
On Wed, 13 Mar 2024 05:17:40 GMT, Karthik P K wrote:
> Because of the difference in the size of characters in default fonts in
> different OS, 2 tests were failing in `RTLTextFlowCharacterIndexTest`.
>
> Increased the scene width to accommodate all the characters as required for
&
On Thu, 14 Mar 2024 10:37:26 GMT, Karthik P K wrote:
>> Because of the difference in the size of characters in default fonts in
>> different OS, 2 tests were failing in `RTLTextFlowCharacterIndexTest`.
>>
>> Increased the scene width to accommodate all the characters
On Thu, 14 Mar 2024 10:37:26 GMT, Karthik P K wrote:
>> Because of the difference in the size of characters in default fonts in
>> different OS, 2 tests were failing in `RTLTextFlowCharacterIndexTest`.
>>
>> Increased the scene width to accommodate all the characters
On Thu, 14 Mar 2024 16:06:55 GMT, Lukasz Kostyra wrote:
> There were two different problems with this test's stability and HiDPI and
> both were fixed with this change.
>
> The whole reason for this tests lack of stability comes with how Windows
> calculates window position when using HiDPI. W
On Wed, 13 Mar 2024 16:30:27 GMT, Andy Goryachev wrote:
>> Karthik P K has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments
>
> tests/system/src/test/java/test/robot/javafx/scene/RTLTextFlowChara
forms.
Karthik P K has updated the pull request incrementally with one additional
commit since the last revision:
Review comments
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1399/files
- new: https://git.openjdk.org/jfx/pull/1399/files/cdf341fc..06c81170
Webrevs:
Because of the difference in the size of characters in default fonts in
different OS, 2 tests were failing in `RTLTextFlowCharacterIndexTest`.
Increased the scene width to accommodate all the characters as required for the
test to validate HitInfo values in all the platforms.
-
Com
On Tue, 5 Mar 2024 15:34:36 GMT, Andy Goryachev wrote:
>>> P.S. Tested on on macOS 14.3.1. The results on Windows/Linux should be
>>> identical, but if we can get some testing done on these two platforms that
>>> would be nice.
>>
>> I tested the changes in windows and do not see any issues.
On Mon, 4 Mar 2024 21:04:28 GMT, Andy Goryachev wrote:
> Adds Labeled.truncated property which indicates when the text is visually
> truncated (and the ellipsis string is inserted) in order to fit the available
> width.
>
> The new property reacts to changes in the following properties:
> - el
On Sat, 24 Feb 2024 17:38:11 GMT, Marius Hanl wrote:
>> `TreeTableRow` does not check the item with `isItemChanged(..)`, unlike all
>> other implementations of the cell.
>>
>> This also means that the `TreeTableRow` always updates the item, although it
>> should not, resulting in a performance
On Tue, 9 Jan 2024 07:31:51 GMT, Karthik P K wrote:
> In the `getHitInfo()` method of PrismTextLayout, RTL node orientation
> conditions were not considered, hence hit test values such as character index
> and insertion index values were incorrect.
>
> Added checks for RTL
On Thu, 29 Feb 2024 17:33:14 GMT, John Hendrikx wrote:
>> @hjohn how do you get this coverage diagram?
>>
>> The BreakIterator is a part of the existing code, we should probably have
>> this discussion outside of this PR. I agree, there might be a situation
>> when the app wants to select a s
On Thu, 29 Feb 2024 12:12:01 GMT, John Hendrikx wrote:
>> Karthik P K has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments
>
> modules/javafx.graphics/src/main/java/javafx/scene/text/T
`getHitInfo()` to calculate correct hit test values.
>
> Added system tests to validate the changes.
Karthik P K has updated the pull request incrementally with one additional
commit since the last revision:
Add unit test
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1
On Thu, 29 Feb 2024 00:27:33 GMT, Andy Goryachev wrote:
> P.S. Tested on on macOS 14.3.1. The results on Windows/Linux should be
> identical, but if we can get some testing done on these two platforms that
> would be nice.
I tested the changes in windows and do not see any issues.
I have exec
`getHitInfo()` to calculate correct hit test values.
>
> Added system tests to validate the changes.
Karthik P K has updated the pull request incrementally with one additional
commit since the last revision:
Review comments
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1
`getHitInfo()` to calculate correct hit test values.
>
> Added system tests to validate the changes.
Karthik P K has updated the pull request incrementally with one additional
commit since the last revision:
Simplified approach
-
Changes:
- all: https://git.openjdk.org/jfx
On Tue, 27 Feb 2024 16:18:31 GMT, John Hendrikx wrote:
>> Karthik P K has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix repeating text node issue
>
> So, I looked into the mirroring problem as well. I
On Tue, 27 Feb 2024 05:09:20 GMT, Karthik P K wrote:
>> yes, this bothered me from the start. I did have a test case in the MT with
>> two text nodes with the same text, and it seemed to work correctly. or did
>> I miss something?
>
> Actually most of the repeating t
`getHitInfo()` to calculate correct hit test values.
>
> Added system tests to validate the changes.
Karthik P K has updated the pull request incrementally with one additional
commit since the last revision:
Fix repeating text node issue
-
Changes:
- all: https://git.openjdk
On Mon, 26 Feb 2024 11:35:06 GMT, Karthik P K wrote:
>> tests/system/src/test/java/test/robot/javafx/scene/RTLTextFlowCharacterIndexTest.java
>> line 238:
>>
>>> 236:
>>> 237: @Test
>>> 238: public void testTextAndTextFlowHitInfoForRTLE
On Mon, 26 Feb 2024 16:22:56 GMT, Andy Goryachev wrote:
>> You are right. It fails when there are repeated text nodes. I will look into
>> this
>
> yes, this bothered me from the start. I did have a test case in the MT with
> two text nodes with the same text, and it seemed to work correctly.
On Sun, 25 Feb 2024 13:16:06 GMT, John Hendrikx wrote:
>> Karthik P K has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 13 addi
On Sat, 24 Feb 2024 23:00:43 GMT, John Hendrikx wrote:
>> Karthik P K has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 13 addi
On Sat, 24 Feb 2024 22:44:05 GMT, John Hendrikx wrote:
> The character index, even in your example image above, seems to be relative
> to the `Text`, not to the `TextFlow` (it is 0, even though there are clearly
> 10 characters before it belonging to another `Text`), so what exactly do you
> m
On Thu, 22 Feb 2024 10:33:38 GMT, Karthik P K wrote:
>> A valid concern about specific fonts, similar to
>> https://github.com/openjdk/jfx/pull/1236#issuecomment-1937022815
>>
>> What was the resolution there? To use a hard-coded font based on the
>> platform,
On Tue, 20 Feb 2024 15:48:26 GMT, Andy Goryachev wrote:
>> I see that the tests don't run on all the platforms. I will look into this
>> and update the PR
>
> A valid concern about specific fonts, similar to
> https://github.com/openjdk/jfx/pull/1236#issuecomment-1937022815
>
> What was the re
On Wed, 21 Feb 2024 18:59:02 GMT, John Hendrikx wrote:
> I'm unclear on this part, do you mean it's possible that multiple `Text`
> objects could be hit at the same time? There should only be one `TextRun` at
> a certain x/y coordinate right?
>
Yes there will be one TextRun at a certain x/y co
On Mon, 19 Feb 2024 14:32:36 GMT, John Hendrikx wrote:
> To determine the runStart/runEnd, `Text` is already analyzing the runs (and
> doing coordinate tests on them). Runs however have locations, with x/y
> coordinates. Would it not be possible, and more sensible, to adjust the `x`,
> `y` coo
`getHitInfo()` to calculate correct hit test values.
>
> Added system tests to validate the changes.
Karthik P K has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull reques
On Mon, 19 Feb 2024 14:32:36 GMT, John Hendrikx wrote:
>Okay, so let me summarize (and let me know if that's correct)
@hjohn you have summarised it correctly. I understood your concern and thanks
for explaining your suggestion it in details. I will look into this approach
and get back to you.
On Thu, 15 Feb 2024 10:36:51 GMT, Karthik P K wrote:
>> I think we should simplify the `getHitInfo` method in the `TextLayout`
>> interface.
>>
>> The code currently seems to be making distinctions where there are none.
>> `TextFlow`s provide spans, while `Text
On Thu, 15 Feb 2024 17:29:10 GMT, Andy Goryachev wrote:
>> Move caret animation handling due to keyboard input to the Skin, by
>> registering a listener on the caretPosition property. This will restart
>> animation only when the caret position changes instead of every key press.
>>
>> This al
On Wed, 14 Feb 2024 04:39:04 GMT, John Hendrikx wrote:
>> Karthik P K has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/text/Pr
On Wed, 14 Feb 2024 04:33:00 GMT, John Hendrikx wrote:
>> Karthik P K has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/text/Pr
On Wed, 14 Feb 2024 04:27:42 GMT, John Hendrikx wrote:
>> Karthik P K has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/scene/te
`getHitInfo()` to calculate correct hit test values.
>
> Added system tests to validate the changes.
Karthik P K has updated the pull request incrementally with one additional
commit since the last revision:
Code refactoring
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1
On Wed, 14 Feb 2024 05:27:19 GMT, John Hendrikx wrote:
> I think we should simplify the `getHitInfo` method in the `TextLayout`
> interface.
>
> The code currently seems to be making distinctions where there are none.
> `TextFlow`s provide spans, while `Text`s provide a text. `getHitInfo` can
On Sat, 10 Feb 2024 17:24:17 GMT, John Hendrikx wrote:
>> There are a number of tickets open related to text rendering:
>>
>> https://bugs.openjdk.org/browse/JDK-8314215
>>
>> https://bugs.openjdk.org/browse/JDK-8145496
>>
>> https://bugs.openjdk.org/browse/JDK-8129014
>>
>> They have in comm
On Fri, 9 Feb 2024 17:33:04 GMT, Andy Goryachev wrote:
>> John Hendrikx has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Add some clarifying documentation
>> - Do not collapse trailing spaces of last line (where no soft wrap occurs)
>
On Thu, 8 Feb 2024 18:22:28 GMT, Andy Goryachev wrote:
>> Karthik P K has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix emoji issue
>
> @hjohn this might impact your work in #1236 - would you like to take
On Thu, 8 Feb 2024 18:13:58 GMT, Andy Goryachev wrote:
>> Karthik P K has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix emoji issue
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/text/Pr
`getHitInfo()` to calculate correct hit test values.
>
> Added system tests to validate the changes.
Karthik P K has updated the pull request incrementally with one additional
commit since the last revision:
Review comments
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1
On Wed, 7 Feb 2024 21:41:10 GMT, Andy Goryachev wrote:
>> Requesting content layout when font changes.
>>
>> This change makes the visual impact of
>> [JDK-8314683](https://bugs.openjdk.org/browse/JDK-8314683) more visible, so
>> perhaps both bugs should be fixed at the same time.
>
> Andy Gor
On Wed, 7 Feb 2024 21:41:10 GMT, Andy Goryachev wrote:
>> Requesting content layout when font changes.
>>
>> This change makes the visual impact of
>> [JDK-8314683](https://bugs.openjdk.org/browse/JDK-8314683) more visible, so
>> perhaps both bugs should be fixed at the same time.
>
> Andy Gor
On Wed, 7 Feb 2024 23:43:41 GMT, Andy Goryachev wrote:
> I see the emoji and tab text options work now, but inline nodes still fail.
I don't see issue with inline nodes. Please let me know in which case you are
facing issue.
https://github.com/openjdk/jfx/assets/26969459/e926e7ad-1fd1-4cb8-af01
On Wed, 7 Feb 2024 10:23:20 GMT, Ambarish Rapte wrote:
>> Requesting content layout when font changes.
>>
>> This change makes the visual impact of
>> [JDK-8314683](https://bugs.openjdk.org/browse/JDK-8314683) more visible, so
>> perhaps both bugs should be fixed at the same time.
>
> With thi
On Wed, 7 Feb 2024 10:43:12 GMT, Karthik P K wrote:
>> In the `getHitInfo()` method of PrismTextLayout, RTL node orientation
>> conditions were not considered, hence hit test values such as character
>> index and insertion index values were incorrect.
>>
>> Added
1 - 100 of 459 matches
Mail list logo
