On Mon, 15 Apr 2024 15:41:19 GMT, eduardsdv <d...@openjdk.org> wrote:
>> This change fixes the calculation of which nodes go to the toolbar and which >> go to the overflow menu. >> It is now determined before the nodes are removed from the scene graph. >> This is important because the values returned by >> ``Node.prefWidth(..)``/``Node.prefHeight(..)`` may depend on whether the >> node is added to the scene graph. >> >> Furthermore I corrected the ``hasOveflow`` value passed to the >> ``organizeOverflow(double, boolean)`` in ``correctOverflow(double)``. > > eduardsdv has updated the pull request incrementally with one additional > commit since the last revision: > > JDK-8328577: Refactor and fix binding of style related properties I see few of issue with the item selection when toolbar items are overflown. 1. If a visible toolbar item is selected and we select an item from overflown list, both the items get marked as selected with blue outline. But overflow icon remains grey. 2. If an item is selected and then change window size so that selected item moves to overflow list, overflow icon becomes blue. If we change the selection to another item in the overflow list, then overflow icon becomes grey. But on hovering anywhere in the window, overflow icon becomes blue again. 3. If an item is selected in the overflow list and we select an item from the visible list, selection in the overflow list remains on opening the overflow list for the first time but overflow icon becomes grey. If we open overflow list again, selection will get removed. I'm not sure whether this issue is in the scope of this PR. Other than these, this PR looks good to me. ------------- PR Review: https://git.openjdk.org/jfx/pull/1434#pullrequestreview-2010946097
