On Fri, 19 Apr 2024 20:36:42 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> This change replaces Character.isLetterOrDigit(char) which fails with >> surrogate characters with Character.isLetterOrDigit(int). > > Andy Goryachev has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains two additional > commits since the last revision: > > - Merge branch 'master' into 8330590.prev.word > - 8330590 TextInputControl: previous word fails with Bhojpuri characters LGTM Validated the changes manually and using the unit tests. The new unit test fails without the fix and passes with the fix provided in this PR as expected. I have one query though, while moving from left to write by word (using option + RIGHT) for the same text, after the first word "Bhojpuri", it goes to the beginning of the Bhojpuri text and then to the end of the Bhojpuri text. But if it was all English text, then it directly goes to the end of the text and skips space. Is this expected? ------------- Marked as reviewed by kpk (Committer). PR Review: https://git.openjdk.org/jfx/pull/1444#pullrequestreview-2027897621
