On Wed, 22 May 2024 21:28:47 GMT, Thiago Milczarek Sayao <tsa...@openjdk.org> wrote:
> This fixes two bugs appointed on the JBS issue: > > 1) Sometimes window was moving to the top left corner - seems to be a bug > somewhere in `gdk_window_get_origin` when used before map (a X concept when > the window appears). The change is to ignore the configure events (happens > when location or size changes) until window is mapped. Before map java is > notified in the `set_bounds` function. > > This seems to happen on newer versions of linux distros. > > 2) Specific to KDE, in the case of the example provided, when an MODAL window > pops, it calls `set_enabled` `false` on the child (or all other windows if > APPLICATION_MODAL) which causes it to update the window constraints. When > maximized, the constraints where applied anyways, causing the window to still > be maximized but not show as maximized. The change is to not apply > constraints when not floating (meaning floating on the screen - not > maximized, fullscreen or iconified). I was checking if this fix resolves the issue reported in [JDK-8332352](https://bugs.openjdk.org/browse/JDK-8332352) and found that this fix is causing change of behaviour in Ubuntu with KDE desktop environment. To reproduce the issue follow the steps given in [JDK-8332352](https://bugs.openjdk.org/browse/JDK-8332352). On selecting File menu, the popup window remains open until the mouse is pressed and closes as the mouse is released. The popup window is also not displayed below the File menu, it gets displayed with some offset, almost on the centre of the screen. This issue is not observed in MacOS. Screen recording of the above issue https://github.com/openjdk/jfx/assets/26969459/1a8cc7ce-5cd0-4562-85cb-01ea7f02b1de ------------- PR Comment: https://git.openjdk.org/jfx/pull/1460#issuecomment-2126302490 PR Comment: https://git.openjdk.org/jfx/pull/1460#issuecomment-2126305088
