> Fixing a bug that breaks proper serialization of character attributes.
>
> This, unfortunately, makes a breaking change in the RichTextArea native
> format [0].
>
> ## References
>
> [0]
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/RichTextArea/Ri
; tabPane.getTabs().addAll(tab1, tab2);
>
> TabPaneSkin skin = new TabPaneSkin(tabPane);
> // set overflow menu factory with the same method as was used to
> create the tabs
> skin.setMenuGraphicFactory(this::createGraphic);
> tabPane.setSkin(skin
On Thu, 29 May 2025 15:47:20 GMT, Michael Strauß wrote:
>> Implementation of [CSS media
>> queries](https://gist.github.com/mstr2/cbb93bff03e073ec0c32aac317b22de7).
>
> Michael Strauß has updated the pull request incrementally with one additional
> commit since the last revision:
>
> reorder
Vote: YES
-andy
From: openjfx-dev on behalf of Kevin Rushforth
Date: Wednesday, May 28, 2025 at 12:51
To: openjfx-dev , Alexander Zuev
Subject: CFV: New OpenJFX Committer: Alexander Zuev
I hereby nominate Alexander Zuev [1] to OpenJFX Committer.
Alexander is a member of the JavaFX team at
On Tue, 20 May 2025 19:01:26 GMT, Michael Strauß wrote:
>> Implementation of
>> [`StageStyle.EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09).
>
> Michael Strauß has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now cont
On Mon, 28 Apr 2025 18:27:37 GMT, Jose Pereda wrote:
>> Note: The JBS issue
>> [JDK-8207333](https://bugs.openjdk.org/browse/JDK-8207333) refers to Linux,
>> but it happens on macOS too.
>>
>> When a TableColumn has a ContextMenu, if the user right clicks on the
>> tableColumnHeader, the Con
Dear Pavel:
This is not a trivial request. Currently, there is not easy way to control
(override) the behavior of the CodeModel with respect to line endings. Line
endings are not stored in the model, but they are emitted when saving/copying.
Perhaps we ought to add a dedicated property to the
On Tue, 27 May 2025 17:18:47 GMT, Michael Strauß wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/Scene.java line 6571:
>>
>>> 6569: * Media Feature
>>> 6570: *
>>> 6571: *
>>> Name-fx-prefers-persistent-scrollbars
>>
>> why the change to
On Sun, 25 May 2025 00:19:36 GMT, Michael Strauß wrote:
>> Implementation of [CSS media
>> queries](https://gist.github.com/mstr2/cbb93bff03e073ec0c32aac317b22de7).
>
> Michael Strauß has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains
On Tue, 27 May 2025 16:09:52 GMT, Ziad El Midaoui
wrote:
>> When the Root TreeItem is set to null, need to relayout to show the children
>> items
>
> Ziad El Midaoui has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Minor change : new line
On Tue, 27 May 2025 14:03:15 GMT, Ziad El Midaoui
wrote:
>> When the Root TreeItem is set to null, need to relayout to show the children
>> items
>
> Ziad El Midaoui has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - Merge remote-tracking
er:
https://github.com/andy-goryachev-oracle/MonkeyTest
VoiceOver announces the accessible text set on ImageView (the image view was
set focus traversable).
Also the following is being logged when Logging -> Accessibility is turned on:
{time:1748360254874, log:"accessibility", "
> Please refer to
>
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>
> The RichTextArea control
> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
> control that needs non-trivial navigation within complex or wr
On Thu, 22 May 2025 21:47:22 GMT, Michael Strauß wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 59 commits:
>>
>> - Merge remote-tracking branch 'origin/master' int
On Thu, 22 May 2025 17:59:40 GMT, Andy Goryachev wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/text/Text.java line 1123:
>>
>>> 1121: * @since 25
>>> 1122: */
>>> 1123: public final PathElement[] getStrikeThroughShape(int start
> Please refer to
>
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>
> The RichTextArea control
> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
> control that needs non-trivial navigation within complex or wr
> Please refer to
>
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>
> The RichTextArea control
> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
> control that needs non-trivial navigation within complex or wr
On Thu, 22 May 2025 00:05:29 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 55 commits:
>>
>> - review comments
>> - Merge remote-tracki
> Please refer to
>
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>
> The RichTextArea control
> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
> control that needs non-trivial navigation within complex or wr
ted
https://bugs.openjdk.org/browse/JDK-8357582 to rectify that.
Hope this helps, and thank you for the feedback - keep it coming!
-andy
From: Timo
Date: Thursday, May 22, 2025 at 04:18
To: Andy Goryachev
Subject: [External] : richtextarea / documentation / feedback
Hi Andy
Thanks for the richtextare
On Thu, 22 May 2025 15:05:02 GMT, Michael Strauß wrote:
>> I would have agreed with the proposed change, if it were a public API.
>>
>> This is an internal method, so it was made as low level as possible. The
>> return value is documented, and the consumer is another part of internal
>> code.
On Thu, 22 May 2025 00:05:29 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 55 commits:
>>
>> - review comments
>> - Merge remote-tracki
On Wed, 21 May 2025 23:49:29 GMT, Michael Strauß wrote:
>> This method does not throw any exceptions, so none are specified.
>
> Instead of returning `float[]` here, this would be a good candidate to return
> a discriminated union instead, something like:
>
> sealed interface CaretGeometry {
>
> Please refer to
>
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>
> The RichTextArea control
> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
> control that needs non-trivial navigation within complex or wr
Fixing a bug that breaks proper serialization of character attributes.
This, unfortunately, makes a breaking change in the RichTextArea native format
[0].
## References
[0]
https://github.com/andy-goryachev-oracle/Test/blob/main/doc/RichTextArea/RichTextArea_DataFormat_V2.md
On Wed, 21 May 2025 10:22:10 GMT, Ziad El Midaoui
wrote:
>> The issue occurred because items preceding an item with children (items with
>> a disclosure node) had different widths, which led to misalignment. This can
>> be fixed by requesting a cell relayout whenever the disclosure node's widt
On Tue, 20 May 2025 15:53:53 GMT, Ziad El Midaoui
wrote:
>> The issue occurred because items preceding an item with children (items with
>> a disclosure node) had different widths, which led to misalignment. This can
>> be fixed by requesting a cell relayout whenever the disclosure node's widt
On Tue, 20 May 2025 09:35:45 GMT, Ambarish Rapte wrote:
>>> Would it be possible to avoid re-layout of the cells that are after the
>>> Cell with a disclosureNode ?
>>
>> This is actually what is happening, when we scroll down and find a TreeCell
>> that has a disclosure node this is when the
On Wed, 23 Apr 2025 22:05:33 GMT, Andy Goryachev wrote:
> Fixed an NPE that should only happen in a headless test environment.
>
> This is a follow-up for https://github.com/openjdk/jfx/pull/1677
This pull request has now been integrated.
Changeset: 9ca61edb
Author:Andy Gorya
On Tue, 20 May 2025 17:00:33 GMT, Ambarish Rapte wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contai
etSortPolicy(sortPolicy);
But don't you think the VALUE parameters are redundant since they can be
obtained directly from ITEM?
Best regards, Pavel
On 5/19/25 22:28, Andy Goryachev wrote:
One possible solution would be to deprecate the comparator property (not for
removal, keep it for ba
# Tab Stop Policy
Andy Goryachev
## Summary
Introduce a `tabStopPolicy` property in the `TextFlow` class which, when set,
overrides the existing `tabSize`
value and provides consistent way of setting tab stops at the paragraph level,
regardless of the individual text
segments font [0
One possible solution would be to deprecate the comparator property (not for
removal, keep it for backward compatibility), and add a new property
'sortPolicy' which will use an interface that can be evolved, as opposed to a
naive callback.
public interface SortPolicy {
public int compare(IT
vel
On 5/7/25 20:04, Andy Goryachev wrote:
There is no dedicated method to do that. The application can iterate over
paragraphs to compute the text position, just keep in mind that the model can
be quite large and it a) will take a lot of iterations and b) the result may
exceed 2^31 (i.e. need t
On Mon, 19 May 2025 18:05:39 GMT, Michael Strauß wrote:
>> 100 still looks excessive to me - it's unlikely that we'll have two
>> different scenarios when this happens, so most of the time the log will have
>> 100 identical traces.
>>
>> I mean, one is probably enough, we could have 2 or 4 jus
On Sat, 17 May 2025 12:24:46 GMT, Michael Strauß wrote:
>> When an exception is thrown from `AnimationTimer::handle`, the JavaFX
>> application freezes. The reason is that the user exception will bubble up
>> into framework code, preventing the normal operation of JavaFX.
>>
>> The following p
On Sat, 17 May 2025 12:21:17 GMT, Michael Strauß wrote:
>> On the other hand, AnimationTimer is a public API that allows for arbitrary
>> code execution, which always has the potential to fail for any number of
>> reasons (think of calling an unstable API from the timer callback). We can’t
>>
On Sun, 18 May 2025 19:02:14 GMT, Martin Fox wrote:
> The GlassTouches code for monitoring touch events was disabled years ago
> because it uses a global event tap. As Apple tightened security this started
> generating alerts. With the latest version of Xcode (16.3) this unused code
> is trigg
On Fri, 16 May 2025 22:25:20 GMT, Martin Fox wrote:
>> Under the hood the Keyman input method appears as a US English keyboard
>> layout. The characters attached to an NSEvent are always US English Roman
>> even if the selected Keyman layout is, say, Hebrew or Dvorak. Keyman sends
>> the corre
On Fri, 16 May 2025 22:25:20 GMT, Martin Fox wrote:
>> Under the hood the Keyman input method appears as a US English keyboard
>> layout. The characters attached to an NSEvent are always US English Roman
>> even if the selected Keyman layout is, say, Hebrew or Dvorak. Keyman sends
>> the corre
On Fri, 16 May 2025 22:25:20 GMT, Martin Fox wrote:
>> Under the hood the Keyman input method appears as a US English keyboard
>> layout. The characters attached to an NSEvent are always US English Roman
>> even if the selected Keyman layout is, say, Hebrew or Dvorak. Keyman sends
>> the corre
On Fri, 16 May 2025 19:03:14 GMT, Michael Strauß wrote:
>> We're throwing away all exceptions after a certain point (either after the
>> first, or some number of exceptions after that). A potential use case would
>> be debugging a large application that for some reason throws lots of
>> differ
On Fri, 16 May 2025 18:12:35 GMT, Michael Strauß wrote:
>> When an exception is thrown from `AnimationTimer::handle`, the JavaFX
>> application freezes. The reason is that the user exception will bubble up
>> into framework code, preventing the normal operation of JavaFX.
>>
>> The following p
On Fri, 16 May 2025 18:12:35 GMT, Michael Strauß wrote:
>> When an exception is thrown from `AnimationTimer::handle`, the JavaFX
>> application freezes. The reason is that the user exception will bubble up
>> into framework code, preventing the normal operation of JavaFX.
>>
>> The following p
On Fri, 16 May 2025 18:12:35 GMT, Michael Strauß wrote:
>> When an exception is thrown from `AnimationTimer::handle`, the JavaFX
>> application freezes. The reason is that the user exception will bubble up
>> into framework code, preventing the normal operation of JavaFX.
>>
>> The following p
On Fri, 16 May 2025 14:38:20 GMT, Michael Strauß wrote:
> When an exception is thrown from `AnimationTimer::handle`, the JavaFX
> application freezes. The reason is that the user exception will bubble up
> into framework code, preventing the normal operation of JavaFX.
>
> The following progra
On Wed, 14 May 2025 15:31:46 GMT, Martin Fox wrote:
> Under the hood the Keyman input method appears as a US English keyboard
> layout. The characters attached to an NSEvent are always US English Roman
> even if the selected Keyman layout is, say, Hebrew or Dvorak. Keyman sends
> the correct H
On Thu, 15 May 2025 22:57:08 GMT, Steven Loomis wrote:
>>> Do you think it's a bug in keyman or our code? I head the beep (correctly)
>>> but then n appears, despite the keyman onscreen keyboard showing an empty
>>> key. If it is our code, should there be some additional logic?
>>
>> Keyman is
On Thu, 15 May 2025 19:04:26 GMT, Martin Fox wrote:
> The N key in the Himyarit Musnad layout shouldn't generate a character (just
> a beep)
Do you think it's a bug in keyman or our code? I head the beep (correctly) but
then n appears, despite the keyman onscreen keyboard showing an empty key
On Wed, 14 May 2025 15:31:46 GMT, Martin Fox wrote:
> Under the hood the Keyman input method appears as a US English keyboard
> layout. The characters attached to an NSEvent are always US English Roman
> even if the selected Keyman layout is, say, Hebrew or Dvorak. Keyman sends
> the correct H
On Thu, 15 May 2025 18:56:14 GMT, Michael Strauß wrote:
>> Some platform preference changes can trigger the emission of multiple
>> notifications. For example, when switching from a high-contrast theme on
>> Windows to the regular theme, the following notifications are emitted (log
>> can be v
On Thu, 15 May 2025 18:28:59 GMT, Michael Strauß wrote:
>> modules/javafx.graphics/src/main/native-glass/win/PlatformSupport.h line 75:
>>
>>> 73: * Suggested aggregation delay for changes that come in over a
>>> period of time.
>>> 74: */
>>> 75: static constexpr int SUGGESTED_DE
On Thu, 15 May 2025 17:50:50 GMT, Michael Strauß wrote:
> Some platform preference changes can trigger the emission of multiple
> notifications. For example, when switching from a high-contrast theme on
> Windows to the regular theme, the following notifications are emitted (log
> can be viewe
On Wed, 14 May 2025 15:31:46 GMT, Martin Fox wrote:
> Under the hood the Keyman input method appears as a US English keyboard
> layout. The characters attached to an NSEvent are always US English Roman
> even if the selected Keyman layout is, say, Hebrew or Dvorak. Keyman sends
> the correct H
On Thu, 15 May 2025 17:26:39 GMT, Alexander Zuev wrote:
>> Noticed a bit of a problem.
>>
>> To reproduce, install Himyarit Musnad keyboard
>> https://keyman.com/keyboards/himyarit_musnad
>>
>> typing 'h' causes this character to appear: 𐩱
>> typing 'n' followed by 'h' generates garbage input
On Wed, 14 May 2025 15:31:46 GMT, Martin Fox wrote:
> Under the hood the Keyman input method appears as a US English keyboard
> layout. The characters attached to an NSEvent are always US English Roman
> even if the selected Keyman layout is, say, Hebrew or Dvorak. Keyman sends
> the correct H
On Wed, 14 May 2025 15:31:46 GMT, Martin Fox wrote:
> Under the hood the Keyman input method appears as a US English keyboard
> layout. The characters attached to an NSEvent are always US English Roman
> even if the selected Keyman layout is, say, Hebrew or Dvorak. Keyman sends
> the correct H
the correct Hebrew or Dvorak character to insertText:replacementRange:
> instead.
>
> This PR special-cases the Keyman layout, detecting it using the same method
> that AWT does. When Keyman is active Glass records the insertText: character
> and uses that when sending out K
On Wed, 14 May 2025 16:40:36 GMT, Ambarish Rapte wrote:
>>> In that case the TreeCells are layout while the scroll is in progress.
>>
>> does this create any visual artifacts?
>
>> does this create any visual artifacts?
>
> No artifacts, just that one can notice the re-layout and the TreeCell s
On Wed, 14 May 2025 14:43:05 GMT, Ziad El Midaoui
wrote:
>> Also noticed a scenario: When a TreeCell with disclosureNode is currently
>> not shown on screen but becomes visible on scrolling. In that case the
>> TreeCells are layout while the scroll is in progress. I see only one way to
>> avo
On Fri, 2 May 2025 15:44:03 GMT, Andy Goryachev wrote:
>> Moving MenuBarSkin initialization code to install() which always happens in
>> the FX Application Thread.
>>
>> Also, ensure that the reverse process also happens in the FX application
>> thread.
>
>
On Fri, 25 Apr 2025 22:39:12 GMT, Andy Goryachev wrote:
> Moving MenuBarSkin initialization code to install() which always happens in
> the FX Application Thread.
>
> Also, ensure that the reverse process also happens in the FX application
> thread.
This pull request has now
On Mon, 21 Apr 2025 15:42:20 GMT, Ziad El Midaoui
wrote:
> Fixed Caret disappear after unfocus then focus on the TextArea, the issue was
> happening because the caret position was set to -1 when we focus on the
> TextArea with empty text and caused the caret to disappear from at the skin
> le
On Mon, 21 Apr 2025 15:42:20 GMT, Ziad El Midaoui
wrote:
> Fixed Caret disappear after unfocus then focus on the TextArea, the issue was
> happening because the caret position was set to -1 when we focus on the
> TextArea with empty text and caused the caret to disappear from at the skin
> le
And a thread on reddit: https://www.reddit.com/r/java/s/IcJhCpNt7y
(Warning: S/N ratio)
-andy
From: openjfx-dev on behalf of Nir Lisker
Date: Saturday, May 10, 2025 at 22:33
To: openjfx-dev
Subject: JavaFX Presentation at JavaOne
Just saw Kevin's JavaFX talk released on YT. Thanks Kevin!
htt
sue with ID: 9078500.
Best regards, Pavel
On 5/12/25 19:58, Andy Goryachev wrote:
JDK-8355774 adds methods to style highlights added via addHighlight() with CSS.
What (I think) you want is an ability to style a single text segment with
(background | underlines | etc) attributes, which is still
does not
consider the possibility of styling underline/wavy underline via a CSS file
(without calling special methods
like addHighlight, addWavyUnderline?
If so, should I open another issue?
Best regards, Pavel
On 5/12/25 19:41, Andy Goryachev wrote:
Yes, I know. But we must support both
I’ve said many times, I’m
only considering styling through a CSS file.
Best regards, Pavel
On 5/12/25 19:28, Andy Goryachev wrote:
Pavel:
Underlines and strike-through attributes are available via
StyleAttributeMap.STRIKE_THROUGH and StyleAttributeMap.UNDERLINE (using text
color). On the
that only 60% of the
core properties are supported.
That's just my feedback — the decision is, of course, yours :)
Best regards, Pavel
On 5/9/25 00:09, Andy Goryachev wrote:
The only property that makes sense is the background color. The wavy and other
kinds of underlines, while they make so
On Fri, 2 May 2025 15:44:03 GMT, Andy Goryachev wrote:
>> Moving MenuBarSkin initialization code to install() which always happens in
>> the FX Application Thread.
>>
>> Also, ensure that the reverse process also happens in the FX application
>> thread.
>
>
On Fri, 9 May 2025 10:51:20 GMT, Ziad El Midaoui wrote:
>> The issue occurred because items preceding an item with children (items with
>> a disclosure node) had different widths, which led to misalignment. This can
>> be fixed by requesting a cell relayout whenever the disclosure node's width
talic, size, name) (+)
- underline (e.g. for links) (?)
- wavy underline (e.g. for spelling) (-)
I think these properties cover 99% of all the necessary properties for CodeArea.
I used + and - to show what has already been implemented.
Best regards, Pavel
On 5/8/25 22:21, Andy Goryachev wrote:
Oh, I fi
On Thu, 8 May 2025 20:16:12 GMT, Ziad El Midaoui wrote:
>> The issue occurred because items preceding an item with children (items with
>> a disclosure node) had different widths, which led to misalignment. This can
>> be fixed by requesting a cell relayout whenever the disclosure node's width
e used, an
alternative property can be introduced,
such as -fx-highlight-color. However, everything else in the example should
work as described.
Best regards, Pavel
On 5/8/25 21:25, Andy Goryachev wrote:
Pavel:
I think your comments in the ticket are still invisible to me, so I can't
comment.
Ab
ished CSS norms.
This is my personal opinion, which, of course, can be wrong.
Best regards, Pavel
On 5/8/25 20:46, Andy Goryachev wrote:
> Adding missing APIs related to styling the highlights with CSS:
>
> 
Adds methods to the `RichParagraph.Builder`:
/**
* Adds a wavy underline (typically used as a
On Wed, 7 May 2025 15:56:57 GMT, Ziad El Midaoui wrote:
>> The issue occurred because items preceding an item with children (items with
>> a disclosure node) had different widths, which led to misalignment. This can
>> be fixed by requesting a cell relayout whenever the disclosure node's width
On Thu, 8 May 2025 14:59:40 GMT, Ziad El Midaoui wrote:
>> The issue occurred because items preceding an item with children (items with
>> a disclosure node) had different widths, which led to misalignment. This can
>> be fixed by requesting a cell relayout whenever the disclosure node's width
On Wed, 7 May 2025 15:56:57 GMT, Ziad El Midaoui wrote:
>> The issue occurred because items preceding an item with children (items with
>> a disclosure node) had different widths, which led to misalignment. This can
>> be fixed by requesting a cell relayout whenever the disclosure node's width
On Wed, 7 May 2025 15:42:03 GMT, Alexander Zuev wrote:
>> Initial implementation. In order to implement progress indicator the group
>> accessibility protocol has to be implemented too so this is also a fix for
>> 8351773. There are commented out sections that can be used to verify the
>> func
; to a
text from from 5 to 20. We do not know IF THESE STYLES
SET BACKGROUND COLOR. Or should we ask an user to name a class this way -
"foo-bg"?
Best regards, Pavel
On 5/7/25 21:16, Andy Goryachev wrote:
Thank you for the feedback!
I finally got the ticket - https://
behalf of PavelTurk
Date: Wednesday, May 7, 2025 at 10:30
To: openjfx-dev@openjdk.org
Subject: Re: CodeArea: -fx-background-color doesn't work.
Andy, thank you very much for your help!
Best regards, Pavel
On 5/7/25 20:29, Andy Goryachev wrote:
This bug is still percolating through the system
opened an issue today, so, when it is approved there won't be any
questions.
Best regards, Pavel
On 5/6/25 00:04, Andy Goryachev wrote:
Will not happen. CSS compatibility with a third party library is not a
requirement in this case.
-andy
From: openjfx-dev
<mailto:openjfx-de
On Wed, 7 May 2025 15:42:03 GMT, Alexander Zuev wrote:
>> Initial implementation. In order to implement progress indicator the group
>> accessibility protocol has to be implemented too so this is also a fix for
>> 8351773. There are commented out sections that can be used to verify the
>> func
There is no dedicated method to do that. The application can iterate over
paragraphs to compute the text position, just keep in mind that the model can
be quite large and it a) will take a lot of iterations and b) the result may
exceed 2^31 (i.e. need to be 'long').
The same is true for the re
RichTextArea.getTextPosition() should be able to give the answer.
-andy
From: openjfx-dev on behalf of PavelTurk
Date: Wednesday, May 7, 2025 at 08:52
To: openjfx-dev@openjdk.org
Subject: CodeArea: how to get the indexes of the first visible paragraph and
the last one?
Could anyone say how t
On Wed, 7 May 2025 15:42:03 GMT, Alexander Zuev wrote:
>> Initial implementation. In order to implement progress indicator the group
>> accessibility protocol has to be implemented too so this is also a fix for
>> 8351773. There are commented out sections that can be used to verify the
>> func
On Wed, 19 Feb 2025 16:45:54 GMT, Ziad El Midaoui
wrote:
> The issue occurred because items preceding an item with children (items with
> a disclosure node) had different widths, which led to misalignment. This can
> be fixed by requesting a cell relayout whenever the disclosure node's width
On Mon, 5 May 2025 21:28:08 GMT, Ziad El Midaoui wrote:
>> The issue was happening because `-fx-highlight-text-fill` was set to white ,
>> so when the background color is bright (>60% brightness ) the text is not
>> visible , the solution is to change the value to be dynamically set
>> dependi
On Wed, 7 May 2025 15:09:18 GMT, Kevin Rushforth wrote:
>> yes it can:
>>
>> --add-opens javafx.graphics/com.sun.javafx.application.preferences=andy_test
>>
>>
>>
>> var platformPreferences = Platform.getPreferences();
>> var colorSchemeProperty = platformPreferences.colorSche
On Wed, 7 May 2025 15:16:15 GMT, Kevin Rushforth wrote:
>> okay
>
> Further, if you call `setAccessibile` in connection with `--add-opens`, which
> your above code snippet does, you can even call _private_ methods.
>
> So at the risk of repeating myself, there is no concern that making this
>
On Wed, 7 May 2025 14:51:11 GMT, Kevin Rushforth wrote:
>> No, an application would not be able to do that. A getter whose
>> implementation happens to return a subtype in a non-exported package does
>> not allow the caller of that getter to access any methods in the
>> non-exported class (eve
On Wed, 7 May 2025 09:28:53 GMT, Michael Strauß wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/application/preferences/PreferenceProperties.java
>> line 258:
>>
>>> 256: }
>>> 257:
>>> 258: // This method must only be called on the FX application
>>> thread.
>>
On Tue, 6 May 2025 20:23:01 GMT, Michael Strauß wrote:
>> Implementation of [CSS media
>> queries](https://gist.github.com/mstr2/cbb93bff03e073ec0c32aac317b22de7).
>
> Michael Strauß has updated the pull request incrementally with three
> additional commits since the last revision:
>
> - cssr
On Tue, 6 May 2025 20:33:43 GMT, Michael Strauß wrote:
>> how about:
>>
>> - the implementation must not fire any events before the Scene is shown
>> - the preferences getters should disallow calls from a background thread
>
> 1. That's how it is implemented. No change events before the scene i
On Tue, 6 May 2025 20:29:29 GMT, Michael Strauß wrote:
>> Thank you!
>>
>> I might suggest to drop `` since these bullets are somewhat of a
>> distraction.
>
> Without it, it just looks like a wall of text to me.
ok
-
PR Review Comment: https://git.openjdk.org/jfx/pull/1655#discu
On Tue, 6 May 2025 20:23:10 GMT, Michael Strauß wrote:
>> That's why I am against this background thread nonsense. Create - yes (even
>> though I am against this). Access and modify properties, especially those
>> that interact with other parts of the FX - no.
>>
>> I think we should enforce
On Tue, 6 May 2025 20:18:05 GMT, Michael Strauß wrote:
>> I insist: the doc should include an example with an operator, and possibly
>> how to achieve A and not B case mentioned earlier.
>>
>> Assume the reader has no clue how media queries work and does not want to
>> wade through the massive
On Tue, 6 May 2025 19:20:04 GMT, Michael Strauß wrote:
>> I see. The I suggest we enforce single-threaded nature of it: everything
>> must happen in the FX Application Thread. I don't think it's a good idea to
>> start synchronizing things in FX now all of a sudden.
>>
>> Any code that wants
1 - 100 of 2679 matches
Mail list logo
