On Tue, 6 May 2025 20:23:01 GMT, Michael Strauß <mstra...@openjdk.org> wrote:

>> Implementation of [CSS media 
>> queries](https://gist.github.com/mstr2/cbb93bff03e073ec0c32aac317b22de7).
>
> Michael Strauß has updated the pull request incrementally with three 
> additional commits since the last revision:
> 
>  - cssref documentation changes
>  - added test
>  - canonical modifier order

Thank you for expanding CSS media query examples!  Verified that they work as 
expected:


@media (prefers-color-scheme: dark) and (not (prefers-persistent-scrollbars)) {
  .root {
    -fx-accent: yellow;
  }
}


I am still convinced javaFX should have been a single-threaded framework with 
no exceptions, but the current code seems ok as long as it's not abused.

-------------

Marked as reviewed by angorya (Reviewer).

PR Review: https://git.openjdk.org/jfx/pull/1655#pullrequestreview-2819661773

Reply via email to