On Fri, 16 May 2025 19:03:14 GMT, Michael Strauß <mstra...@openjdk.org> wrote:

>> We're throwing away all exceptions after a certain point (either after the 
>> first, or some number of exceptions after that). A potential use case would 
>> be debugging a large application that for some reason throws lots of 
>> different exceptions from timers. There can't be many applications that do 
>> this, because right now that would most likely just freeze the application. 
>> I'm okay either way (logging the first exception, or logging the first 100 
>> exceptions with a user-configurable threshold).
>
> We could also just keep it with a fixed threshold, but remove the system 
> property.

It just seems unnecessary to add all this complexity.  The first exception is 
all we need, really - we can skip the 2nd, 3rd, ...  This might rule out the 
property.

It might be unlikely that two or more completely unrelated failures would 
happen in the field in a well-tested application [citation needed], I think 
there is a little value in trying to add this complex logic per timer.  A 
static boolean might suffice.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1811#discussion_r2093548949

Reply via email to