On Fri, 16 May 2025 22:25:20 GMT, Martin Fox <m...@openjdk.org> wrote:
>> Under the hood the Keyman input method appears as a US English keyboard
>> layout. The characters attached to an NSEvent are always US English Roman
>> even if the selected Keyman layout is, say, Hebrew or Dvorak. Keyman sends
>> the correct Hebrew or Dvorak character to insertText:replacementRange:
>> instead.
>>
>> This PR special-cases the Keyman layout, detecting it using the same method
>> that AWT does. When Keyman is active Glass records the insertText: character
>> and uses that when sending out KeyEvents.
>
> Martin Fox has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Second try at making Keyman work to some extent
modules/javafx.graphics/src/main/native-glass/mac/GlassView3D.m line 806:
> 804: // but a text input client should not. So we ignore this which
> avoids an
> 805: // annoying beep.
> 806: if (keymanActive) {
I noticed the latest code does not beep. Were the beeps produced earlier
expected for unmapped keys?
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1805#discussion_r2093763002
