On Thu, 1 May 2025 22:08:46 GMT, Ziad El Midaoui wrote:
> The issue was happening because `-fx-highlight-text-fill` was set to white ,
> so when the background color is bright (>60% brightness ) the text is not
> visible , the solution is to change the value to be dynamically set depending
> o
On Fri, 2 May 2025 10:32:42 GMT, Michael Strauß wrote:
>> Implementation of
>> [`StageStyle.EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09).
>
> Michael Strauß has updated the pull request incrementally with one additional
> commit since the last revision:
>
> simp
On Mon, 28 Apr 2025 07:38:37 GMT, Michael Strauß wrote:
>> Implementation of [CSS media
>> queries](https://gist.github.com/mstr2/cbb93bff03e073ec0c32aac317b22de7).
>
> Michael Strauß has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains
On Fri, 2 May 2025 21:53:09 GMT, Michael Strauß wrote:
>> `reconsume` -> `resetToPrevious` + mention "reconsume" in javadoc?
>
> I don't want to die on the `reconsume` hill here, but I think there is some
> value in being able to read through the W3C specification of the CSS
> algorithms, and f
On Fri, 2 May 2025 21:43:39 GMT, Andy Goryachev wrote:
>> I renamed `consume(Predicate)` to `consumeIf(Predicate)`, and
>> `peekMany(Predicate...)` to `matches(Predicate...)`.
>>
>> `index()` and `reset()` don't need to be public, so I've removed that (also
>> I don't want to mimic the problem
On Mon, 14 Apr 2025 14:35:43 GMT, Michael Strauß wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/css/parser/TokenStream.java
>> line 31:
>>
>>> 29: import java.util.function.Predicate;
>>> 30:
>>> 31: public final class TokenStream {
>>
>> I think the naming of the methods in t
On Fri, 2 May 2025 21:09:12 GMT, Michael Strauß wrote:
> I don't think we need to repeat that for each individual property, at least
> not manually.
Maybe not manually, but a reflection-based test that verifies each `Styleable`
property (and also verify that these properties are listed in the
On Fri, 2 May 2025 20:38:39 GMT, Andy Goryachev wrote:
> We already have `fontSetFromCSS()` test there, so I am not against adding a
> test in this file.
That's not my point. `fontSetFromCSS` tests whether a font can be set via CSS,
which concerns the implementation of `TextInputControl`. In c
On Fri, 2 May 2025 19:24:40 GMT, Michael Strauß wrote:
> I'm interested in a second opinion on whether we should do this kind of
> testing, and what in particular it should accomplish.
We already have `fontSetFromCSS()` test there, so I am not against adding a
test in this file.
You do bring
On Thu, 1 May 2025 22:08:46 GMT, Ziad El Midaoui wrote:
> The issue was happening because `-fx-highlight-text-fill` was set to white ,
> so when the background color is bright (>60% brightness ) the text is not
> visible , the solution is to change the value to be dynamically set depending
> o
On Thu, 1 May 2025 22:08:46 GMT, Ziad El Midaoui wrote:
> The issue was happening because `-fx-highlight-text-fill` was set to white ,
> so when the background color is bright (>60% brightness ) the text is not
> visible , the solution is to change the value to be dynamically set depending
> o
On Fri, 2 May 2025 10:32:42 GMT, Michael Strauß wrote:
>> Implementation of
>> [`StageStyle.EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09).
>
> Michael Strauß has updated the pull request incrementally with one additional
> commit since the last revision:
>
> simp
On Fri, 2 May 2025 11:46:12 GMT, Michael Strauß wrote:
> > Would it be feasible to ensure the minium window width is large enough by
> > default, and allowing to turn this off when manual clipping is implemented
> > instead?
>
> It's probably a bit hard with the API around `Stage.minWidth` and
On Fri, 2 May 2025 17:42:45 GMT, Andy Goryachev wrote:
>> Please refer to
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>>
>> The RichTextArea control
>> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
>> control that needs no
> Please refer to
>
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>
> The RichTextArea control
> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
> control that needs non-trivial navigation within complex or wrapped text
> needs a p
On Mon, 7 Apr 2025 19:37:27 GMT, Andy Goryachev wrote:
>> Please refer to
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>>
>> The RichTextArea control
>> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
>> control that needs no
On Thu, 1 May 2025 18:58:47 GMT, Kevin Rushforth wrote:
>> We've got https://bugs.openjdk.org/browse/JDK-8341438 and a possibility of a
>> regression if we change the existing methods.
>>
>> I would very much like to get your thoughts on this.
>
> I also would like to hear thoughts about compat
On Thu, 1 May 2025 18:54:53 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> sealed
>
> modules/javafx.graphics/src/main/java/javafx/scene/text/CaretInfo.java line
> 60:
>
>> 58: * @ret
On Thu, 1 May 2025 18:39:44 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> sealed
>
> modules/javafx.graphics/src/main/java/javafx/scene/text/LayoutInfo.java line
> 57:
>
>> 55: * @re
On Thu, 1 May 2025 18:04:15 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> sealed
>
> modules/javafx.graphics/src/main/java/javafx/scene/text/LayoutInfo.java line
> 36:
>
>> 34: * as well
On Thu, 1 May 2025 17:59:23 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> sealed
>
> modules/javafx.graphics/src/main/java/javafx/scene/text/Text.java line 2100:
>
>> 2098: * While th
On Thu, 1 May 2025 15:39:03 GMT, Kevin Rushforth wrote:
>> I understand the argument for `TextLineInfo`, I guess I'm looking more at
>> `LayoutInfo` here. My question is whether it is really the best choice to
>> sacrifice local consistency within a single class just to have it look more
>> si
On Thu, 1 May 2025 15:41:07 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> sealed
>
> modules/javafx.graphics/src/main/java/javafx/scene/text/Text.java line 866:
>
>> 864: /**
>> 865:
> Moving MenuBarSkin initialization code to install() which always happens in
> the FX Application Thread.
>
> Also, ensure that the reverse process also happens in the FX application
> thread.
Andy Goryachev has updated the pull request with a new target base due to a
merge or a rebase. The i
Definitely not null - the javadoc says nothing about null, perhaps it should be
more explicit. The paragraph may contain paragraph attributes, even when empty.
-andy
From: openjfx-dev on behalf of PavelTurk
Date: Friday, May 2, 2025 at 08:30
To: openjfx-dev@openjdk.org
Subject: CodeArea:
Could anyone say what createRichParagraph should return if the paragraph is
empty (length = 0)?
For example, RichParagraph.builder().build(), or null, or ?
Best regards, Pavel
On Fri, 2 May 2025 14:41:06 GMT, Martin Fox wrote:
> I'm not entirely sure that's a requirement we should be testing for.
I agree. We should test that it settles to the expected values eventually.
-
PR Comment: https://git.openjdk.org/jfx/pull/1797#issuecomment-2847383534
On Wed, 30 Apr 2025 23:34:06 GMT, Martin Fox wrote:
>> On macOS the system animates the transition into and out of fullscreen and
>> this animation runs asynchronously. JavaFX tries to make the setFullScreen
>> call appear synchronous by running a nested event loop while the transition
>> is g
On Fri, 2 May 2025 10:32:42 GMT, Michael Strauß wrote:
>> Implementation of
>> [`StageStyle.EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09).
>
> Michael Strauß has updated the pull request incrementally with one additional
> commit since the last revision:
>
> simp
On Fri, 2 May 2025 11:18:04 GMT, Markus Mack wrote:
> Would it be feasible to ensure the minium window width is large enough by
> default, and allowing to turn this off when manual clipping is implemented
> instead?
It's probably a bit hard with the API around `Stage.minWidth` and
`Stage.minH
On Fri, 2 May 2025 10:32:42 GMT, Michael Strauß wrote:
>> Implementation of
>> [`StageStyle.EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09).
>
> Michael Strauß has updated the pull request incrementally with one additional
> commit since the last revision:
>
> simp
On Fri, 2 May 2025 10:32:42 GMT, Michael Strauß wrote:
>> Implementation of
>> [`StageStyle.EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09).
>
> Michael Strauß has updated the pull request incrementally with one additional
> commit since the last revision:
>
> simp
On Fri, 2 May 2025 10:32:42 GMT, Michael Strauß wrote:
>> Implementation of
>> [`StageStyle.EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09).
>
> Michael Strauß has updated the pull request incrementally with one additional
> commit since the last revision:
>
> simp
> Implementation of
> [`StageStyle.EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09).
Michael Strauß has updated the pull request incrementally with one additional
commit since the last revision:
simplify header area picking
-
Changes:
- all: https://g
34 matches
Mail list logo
