On Thu, 1 May 2025 22:08:46 GMT, Ziad El Midaoui <zelmida...@openjdk.org> wrote:
> The issue was happening because `-fx-highlight-text-fill` was set to white , > so when the background color is bright (>60% brightness ) the text is not > visible , the solution is to change the value to be dynamically set depending > on the level of brightness of the background this is done by > `-fx-focused-text-base-color` . I don't think that styling details of the Modena theme should be unit-tested in `TextInputControlTest`. First of all, this has nothing to do with the `TextInputControl` implementation. Second, it seems a bit pointless to me to unit-test individual styling aspects of one particular CSS theme, it's not what unit tests are meant to do. I'm interested in a second opinion on whether we should do this kind of testing, and what in particular it should accomplish. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1801#issuecomment-2847938322 PR Comment: https://git.openjdk.org/jfx/pull/1801#issuecomment-2847939449
