On Thu, 1 May 2025 22:08:46 GMT, Ziad El Midaoui <zelmida...@openjdk.org> wrote:
> The issue was happening because `-fx-highlight-text-fill` was set to white , > so when the background color is bright (>60% brightness ) the text is not > visible , the solution is to change the value to be dynamically set depending > on the level of brightness of the background this is done by > `-fx-focused-text-base-color` . Looks good. Thanks for the test, nice idea with the "double-parameterized" case. 1 reviewer should be sufficient. Please wait 24 hrs before integrating. ------------- Marked as reviewed by angorya (Reviewer). PR Review: https://git.openjdk.org/jfx/pull/1801#pullrequestreview-2812733235
