On Fri, 2 May 2025 21:43:39 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> I renamed `consume(Predicate)` to `consumeIf(Predicate)`, and >> `peekMany(Predicate...)` to `matches(Predicate...)`. >> >> `index()` and `reset()` don't need to be public, so I've removed that (also >> I don't want to mimic the problematic mark/reset pattern of `InputStream`). >> >> `reconsume` is [CSS >> lingo](https://www.w3.org/TR/css-syntax-3/#tokenizer-definitions), I'm >> keeping that as-is. > > `reconsume` -> `resetToPrevious` + mention "reconsume" in javadoc? I don't want to die on the `reconsume` hill here, but I think there is some value in being able to read through the W3C specification of the CSS algorithms, and find similar terminology in our implementation. Makes it a bit easier to correlate specification and implementation. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1655#discussion_r2072184243
