RFR: 8337960: Improve performance of mfwrapper by reusing GStreamer media buffers for decoded video

2025-02-04 Thread Alexander Matveev
- Added new class `CMFGSTBuffer` which can allocate memory internally or provide GStreamer allocated memory to Media Foundation. - Added `GstBufferPool` to limit allocation of output buffers used for rendering (memory will not be allocated for each buffer, but instead will be reused from pool).

Re: RFR: 8348423: [TestBug] stress test Nodes initialization from a background thread [v8]

2025-02-04 Thread Andy Goryachev
On Mon, 3 Feb 2025 21:47:11 GMT, Andy Goryachev wrote: >> Created a test that validates various Nodes can be initialized in a >> background thread. > > Andy Goryachev has updated the pull request incrementally with one additional > commit since the last revision: > > more jitter It looks li

Re: RFR: 8313424: JavaFX controls in the title bar [v47]

2025-02-04 Thread Andy Goryachev
On Tue, 4 Feb 2025 12:41:24 GMT, Michael Strauß wrote: >> Implementation of >> [`EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09) >> and `EXTENDED_UTILITY` stage style. > > Michael Strauß has updated the pull request incrementally with one additional > commit since th

Re: RFR: 8349373: Support JavaFX preview features [v2]

2025-02-04 Thread Kevin Rushforth
On Tue, 4 Feb 2025 19:39:07 GMT, Michael Strauß wrote: >> This PR contains a definition of preview features for JavaFX, as well as a >> helper class to verify that an application has opted into preview features. > > Michael Strauß has updated the pull request incrementally with one additional >

Re: RFR: 8349373: Support JavaFX preview features [v2]

2025-02-04 Thread Kevin Rushforth
On Tue, 4 Feb 2025 19:47:08 GMT, Kevin Rushforth wrote: >> We could also do that, but the problem is that the contents of JEP 12 only >> map to JavaFX in some parts, but not in others. So we would need to include >> weasel language like "where applicable" (which always leaves a bit of room >>

Re: RFR: 8349373: Support JavaFX preview features [v2]

2025-02-04 Thread Kevin Rushforth
On Tue, 4 Feb 2025 19:25:40 GMT, Michael Strauß wrote: >> PREVIEW-FEATURES.md line 1: >> >>> 1: # Preview features >> >> is this a good location of this document? >> should it be in /doc-files somewhere? > > I think it's not a documentation of JavaFX itself, but more like a > meta-documentatio

Re: RFR: 8349373: Support JavaFX preview features [v2]

2025-02-04 Thread Kevin Rushforth
On Tue, 4 Feb 2025 19:20:47 GMT, Michael Strauß wrote: >> The space of people who know what a JDK preview is is larger than that of >> JFX people. I think we might want to point to JEP12 and explicitly explain >> the difference, that's all. > > We could also do that, but the problem is that th

Re: RFR: 8313424: JavaFX controls in the title bar [v47]

2025-02-04 Thread Michael Strauß
On Tue, 4 Feb 2025 19:08:22 GMT, Andy Goryachev wrote: > Do you mind if I eventually move the changes to the "Stage" page? Sure, do that. It might be prudent to wait for the API in this PR to stabilize, though. - PR Comment: https://git.openjdk.org/jfx/pull/1605#issuecomment-26349

Re: RFR: 8349373: Support JavaFX preview features [v2]

2025-02-04 Thread Andy Goryachev
On Tue, 4 Feb 2025 19:34:29 GMT, Michael Strauß wrote: >> modules/javafx.base/src/main/java/com/sun/javafx/PreviewFeature.java line 37: >> >>> 35: * has opted into preview features. >>> 36: */ >>> 37: public enum PreviewFeature { >> >> Why enum? >> Maybe use a regular class with a public cons

Re: RFR: 8349373: Support JavaFX preview features [v2]

2025-02-04 Thread Michael Strauß
On Tue, 4 Feb 2025 18:18:31 GMT, Andy Goryachev wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> move enum field to top > > modules/javafx.base/src/main/java/com/sun/javafx/PreviewFeature.java line 37: > >> 35:

Re: RFR: 8349373: Support JavaFX preview features [v2]

2025-02-04 Thread Michael Strauß
> This PR contains a definition of preview features for JavaFX, as well as a > helper class to verify that an application has opted into preview features. Michael Strauß has updated the pull request incrementally with one additional commit since the last revision: move enum field to top

Re: RFR: 8349373: Support JavaFX preview features

2025-02-04 Thread Michael Strauß
On Tue, 4 Feb 2025 18:44:57 GMT, Andy Goryachev wrote: >> This definition is, as you point out, largely lifted from JEP 12. Aside from >> wording changes, here are some key differences: >> >> * JEP 12 assumes that a feature should be finished within two releases. I >> think for JavaFX, being j

Re: RFR: 8349373: Support JavaFX preview features

2025-02-04 Thread Michael Strauß
On Tue, 4 Feb 2025 18:13:19 GMT, Andy Goryachev wrote: >> This PR contains a definition of preview features for JavaFX, as well as a >> helper class to verify that an application has opted into preview features. > > PREVIEW-FEATURES.md line 1: > >> 1: # Preview features > > is this a good loca

Re: RFR: 8313424: JavaFX controls in the title bar [v47]

2025-02-04 Thread Andy Goryachev
On Tue, 4 Feb 2025 12:41:24 GMT, Michael Strauß wrote: >> Implementation of >> [`EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09) >> and `EXTENDED_UTILITY` stage style. > > Michael Strauß has updated the pull request incrementally with one additional > commit since th

Re: RFR: 8349373: Support JavaFX preview features

2025-02-04 Thread Andy Goryachev
On Tue, 4 Feb 2025 18:41:13 GMT, Michael Strauß wrote: >> PREVIEW-FEATURES.md line 32: >> >>> 30:application has not opted into the use of preview features. All >>> preview features have equal status >>> 31:in any given JavaFX release and can not be enabled individually. >>> 32: >> >>

Re: RFR: 8349373: Support JavaFX preview features

2025-02-04 Thread Michael Strauß
On Tue, 4 Feb 2025 18:16:22 GMT, Andy Goryachev wrote: >> This PR contains a definition of preview features for JavaFX, as well as a >> helper class to verify that an application has opted into preview features. > > PREVIEW-FEATURES.md line 32: > >> 30:application has not opted into the use

Re: RFR: 8342565: [TestBug] StubTextLayout [v2]

2025-02-04 Thread Andy Goryachev
On Tue, 4 Feb 2025 08:50:43 GMT, Marius Hanl wrote: >> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 19 additional >> commits s

Re: RFR: 8342565: [TestBug] StubTextLayout [v3]

2025-02-04 Thread Andy Goryachev
> Changed the StubTextLayout to use product PrismTextLayout with much > simplified glyph layout (via stubbed fonts). The new layout assumes all the > glyphs are squares of font size, while the bold type face produces wider > glyphs (by 1 pixel). The default font size has changed from 10 to 12

Re: RFR: 8341670: [Text, TextFlow] Public API for Text Layout Info [v16]

2025-02-04 Thread Johan Vos
On Thu, 16 Jan 2025 19:34:06 GMT, Andy Goryachev wrote: >> Please refer to >> >> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md >> >> The RichTextArea control >> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom >> control that needs n

Re: RFR: 8349373: Support JavaFX preview features

2025-02-04 Thread Andy Goryachev
On Wed, 7 Feb 2024 20:05:01 GMT, Michael Strauß wrote: > This PR contains a definition of preview features for JavaFX, as well as a > helper class to verify that an application has opted into preview features. PREVIEW-FEATURES.md line 1: > 1: # Preview features is this a good location of this

Re: RFR: 8335587: TextInputControl: Binding prompt text that contains linebreak causes exception [v2]

2025-02-04 Thread Andy Goryachev
On Tue, 4 Feb 2025 16:01:03 GMT, Ziad El Midaoui wrote: >> When binding the promptTextProperty of a TextInputControl (TextField or >> TextArea) to a text that contains linebreaks/newlines ("\n") the "bind" call >> causes a RuntimeException to be thrown, the solution to it is to unbind >> befor

Re: RFR: 8335587: TextInputControl: Binding prompt text that contains linebreak causes exception [v2]

2025-02-04 Thread Andy Goryachev
On Tue, 4 Feb 2025 16:15:48 GMT, Michael Strauß wrote: > the point of this particular ticket [NEW DRIVER. PLEASE BE PATIENT] - PR Comment: https://git.openjdk.org/jfx/pull/1694#issuecomment-2634459921

Re: RFR: 8335587: TextInputControl: Binding prompt text that contains linebreak causes exception [v2]

2025-02-04 Thread Michael Strauß
On Tue, 4 Feb 2025 16:01:03 GMT, Ziad El Midaoui wrote: >> When binding the promptTextProperty of a TextInputControl (TextField or >> TextArea) to a text that contains linebreaks/newlines ("\n") the "bind" call >> causes a RuntimeException to be thrown, the solution to it is to unbind >> befor

Re: RFR: 8342565: [TestBug] StubTextLayout [v2]

2025-02-04 Thread Andy Goryachev
On Tue, 4 Feb 2025 08:53:31 GMT, Marius Hanl wrote: > `S`, `M` or `L` as variable names (minor) the meaning should be obvious from the context (small, medium, large) and I don't want code like this to take two pages: testScrollTo(360, 1, new Integer[] { S, S, S, S, S, S, S, S, S, S, S, S, S, S

RFR: 8349373: Support JavaFX preview features

2025-02-04 Thread Michael Strauß
This PR contains a definition of preview features for JavaFX, as well as a helper class to verify that an application has opted into preview features. - Commit messages: - Use enum constants instead of feature names - Merge branch 'master' into feature/previewfeature - Preview fea

Re: RFR: 8335587: TextInputControl: Binding prompt text that contains linebreak causes exception

2025-02-04 Thread Andy Goryachev
On Tue, 4 Feb 2025 15:13:31 GMT, Michael Strauß wrote: >> When binding the promptTextProperty of a TextInputControl (TextField or >> TextArea) to a text that contains linebreaks/newlines ("\n") the "bind" call >> causes a RuntimeException to be thrown, the solution to it is to unbind >> before

Re: RFR: 8313424: JavaFX controls in the title bar [v47]

2025-02-04 Thread Michael Strauß
On Tue, 4 Feb 2025 12:41:24 GMT, Michael Strauß wrote: >> Implementation of >> [`EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09) >> and `EXTENDED_UTILITY` stage style. > > Michael Strauß has updated the pull request incrementally with one additional > commit since th

Re: RFR: 8335587: TextInputControl: Binding prompt text that contains linebreak causes exception

2025-02-04 Thread Andy Goryachev
On Tue, 4 Feb 2025 14:11:00 GMT, Ziad El Midaoui wrote: > When binding the promptTextProperty of a TextInputControl (TextField or > TextArea) to a text that contains linebreaks/newlines ("\n") the "bind" call > causes a RuntimeException to be thrown, the solution to it is to unbind > before ca

Re: RFR: 8313424: JavaFX controls in the title bar [v47]

2025-02-04 Thread Andy Goryachev
On Tue, 4 Feb 2025 12:41:24 GMT, Michael Strauß wrote: >> Implementation of >> [`EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09) >> and `EXTENDED_UTILITY` stage style. > > Michael Strauß has updated the pull request incrementally with one additional > commit since th

Re: RFR: 8335587: TextInputControl: Binding prompt text that contains linebreak causes exception

2025-02-04 Thread Michael Strauß
On Tue, 4 Feb 2025 14:11:00 GMT, Ziad El Midaoui wrote: > When binding the promptTextProperty of a TextInputControl (TextField or > TextArea) to a text that contains linebreaks/newlines ("\n") the "bind" call > causes a RuntimeException to be thrown, the solution to it is to unbind > before ca

RFR: 8335587: TextInputControl: Binding prompt text that contains linebreak causes exception

2025-02-04 Thread Ziad El Midaoui
When binding the promptTextProperty of a TextInputControl (TextField or TextArea) to a text that contains linebreaks/newlines ("\n") the "bind" call causes a RuntimeException to be thrown, the solution to it is to unbind before calling the set(txt) method to set the new value for the property. A

Re: RFR: 8313424: JavaFX controls in the title bar [v47]

2025-02-04 Thread Kevin Rushforth
On Tue, 4 Feb 2025 12:41:24 GMT, Michael Strauß wrote: >> Implementation of >> [`EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09) >> and `EXTENDED_UTILITY` stage style. > > Michael Strauß has updated the pull request incrementally with one additional > commit since th

Re: RFR: 8313424: JavaFX controls in the title bar [v45]

2025-02-04 Thread Kevin Rushforth
On Tue, 4 Feb 2025 12:12:31 GMT, Michael Strauß wrote: >> modules/javafx.graphics/src/main/java/com/sun/javafx/scene/layout/HeaderButtonBehavior.java >> line 41: >> >>> 39: import java.util.Optional; >>> 40: >>> 41: public final class HeaderButtonBehavior implements >>> EventHandler { >> >>

Re: RFR: 8313424: JavaFX controls in the title bar [v47]

2025-02-04 Thread Michael Strauß
> Implementation of > [`EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09) > and `EXTENDED_UTILITY` stage style. Michael Strauß has updated the pull request incrementally with one additional commit since the last revision: add "maximized" pseudo-class for custom maxim

Re: RFR: 8313424: JavaFX controls in the title bar [v46]

2025-02-04 Thread Michael Strauß
> Implementation of > [`EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09) > and `EXTENDED_UTILITY` stage style. Michael Strauß has updated the pull request incrementally with one additional commit since the last revision: move StageTester to Tools menu -

Re: RFR: 8313424: JavaFX controls in the title bar [v45]

2025-02-04 Thread Michael Strauß
On Mon, 3 Feb 2025 23:38:30 GMT, Andy Goryachev wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> macOS bugfixes, default button behavior > > modules/javafx.graphics/src/main/java/com/sun/javafx/scene/layout/Header

Re: RFR: 8342565: [TestBug] StubTextLayout [v2]

2025-02-04 Thread Marius Hanl
On Wed, 29 Jan 2025 19:01:40 GMT, Andy Goryachev wrote: >> Changed the StubTextLayout to use product PrismTextLayout with much >> simplified glyph layout (via stubbed fonts). The new layout assumes all the >> glyphs are squares of font size, while the bold type face produces wider >> glyphs (

Re: RFR: 8342565: [TestBug] StubTextLayout [v2]

2025-02-04 Thread Marius Hanl
On Wed, 29 Jan 2025 19:01:40 GMT, Andy Goryachev wrote: >> Changed the StubTextLayout to use product PrismTextLayout with much >> simplified glyph layout (via stubbed fonts). The new layout assumes all the >> glyphs are squares of font size, while the bold type face produces wider >> glyphs (

Integrated: 8185887: TableRowSkinBase fails to correctly virtualize cells in horizontal direction

2025-02-04 Thread Marius Hanl
On Fri, 22 Nov 2024 16:32:49 GMT, Marius Hanl wrote: > This PR fixes the horizontal virtualization performed in the > `TableRowSkinBase`, which significantly improves performance with many > columns (and thus many cells). Scrolling up and down as well as scrolling > left and right feels much m