On Mon, 3 Feb 2025 23:38:30 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> macOS bugfixes, default button behavior > > modules/javafx.graphics/src/main/java/com/sun/javafx/scene/layout/HeaderButtonBehavior.java > line 41: > >> 39: import java.util.Optional; >> 40: >> 41: public final class HeaderButtonBehavior implements >> EventHandler<MouseEvent> { > > it might be better to call this class other than "behavior", "handler" > perhaps? mouse handler? It's a bit more than just a generic handler, it basically encapsulates the entire behavior of a window button (including setting its visibility and disabled states). ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1605#discussion_r1941053806