On Tue, 4 Feb 2025 12:41:24 GMT, Michael Strauß <mstra...@openjdk.org> wrote:
>> Implementation of >> [`EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09) >> and `EXTENDED_UTILITY` stage style. > > Michael Strauß has updated the pull request incrementally with one additional > commit since the last revision: > > add "maximized" pseudo-class for custom maximize button I wonder if the header bar needs to get clipped somehow:  (also weird padding around buttons in the left content area) modules/javafx.base/src/test/java/test/util/ReflectionUtils.java line 41: > 39: * The field can be declared on any of the object's inherited classes. > 40: */ > 41: @SuppressWarnings("unchecked") is this annotation still needed (the build gives no warnings when it's removed)? modules/javafx.graphics/src/main/native-glass/gtk/glass_window.h line 2: > 1: /* > 2: * Copyright (c) 2011, 2024, Oracle and/or its affiliates. All rights > reserved. we probably want to change this to 2025 (and merge the latest master for good measure) tests/manual/monkey/src/com/oracle/tools/fx/monkey/tools/StageTesterWindow.java line 186: > 184: sizeComboBox.valueProperty().subscribe(event -> > updateMinHeight.run()); > 185: headerBar.minSystemHeightProperty().subscribe(event -> > updateMinHeight.run()); > 186: headerBar.setLeading(new Button("✨")); minor: this is nice, but can we replace this with non-emoji character please? (messes up the line spacing in Eclipse) ------------- PR Comment: https://git.openjdk.org/jfx/pull/1605#issuecomment-2635049491 PR Review Comment: https://git.openjdk.org/jfx/pull/1605#discussion_r1941811731 PR Review Comment: https://git.openjdk.org/jfx/pull/1605#discussion_r1941806528 PR Review Comment: https://git.openjdk.org/jfx/pull/1605#discussion_r1941871727
