Re: RFR: 8345136: Update JDK_DOCS property to point to JDK 23 docs [v2]

2024-12-17 Thread Joeri Sykora
On Tue, 17 Dec 2024 19:29:17 GMT, Kevin Rushforth wrote: >> Update the docs bundle to point to the JDK 23 docs (we're currently pointing >> to JDK 21). >> >> I will need to also download and host a zip bundle and add its checksum to >> gradle/verification-metadata.xml to avoid breaking our int

Re: [External] : Re: Focus delegation API

2024-12-17 Thread Andy Goryachev
Martin: I guess I am trying to say that I find the focus delegation idea as unnecessary - it feels to me like a band-aid on a broken event dispatching system. It might be the case that the current design was there from the beginning, and so probably all the other issues we have encountered so

Re: RFR: 8301121: RichTextArea Control (Incubator) [v65]

2024-12-17 Thread Andy Goryachev
On Tue, 17 Dec 2024 21:06:16 GMT, Andy Goryachev wrote: >> Incubating a new feature - rich text control, **RichTextArea**, intended to >> bridge the functional gap with Swing and its StyledEditorKit/JEditorPane. >> The main design goal is to provide a control that is complete enough to be >> u

Re: RFR: 8301121: RichTextArea Control (Incubator) [v64]

2024-12-17 Thread Kevin Rushforth
On Tue, 17 Dec 2024 20:53:31 GMT, Andy Goryachev wrote: >> Incubating a new feature - rich text control, **RichTextArea**, intended to >> bridge the functional gap with Swing and its StyledEditorKit/JEditorPane. >> The main design goal is to provide a control that is complete enough to be >> u

Re: RFR: 8301121: RichTextArea Control (Incubator) [v65]

2024-12-17 Thread Andy Goryachev
> Incubating a new feature - rich text control, **RichTextArea**, intended to > bridge the functional gap with Swing and its StyledEditorKit/JEditorPane. The > main design goal is to provide a control that is complete enough to be useful > out-of-the box, as well as open to extension by the appl

Re: RFR: 8301121: RichTextArea Control (Incubator) [v64]

2024-12-17 Thread Andy Goryachev
> Incubating a new feature - rich text control, **RichTextArea**, intended to > bridge the functional gap with Swing and its StyledEditorKit/JEditorPane. The > main design goal is to provide a control that is complete enough to be useful > out-of-the box, as well as open to extension by the appl

Re: RFR: 8299753: Tree/TableView: Column Resizing With Fractional Scale [v5]

2024-12-17 Thread Andy Goryachev
On Mon, 4 Nov 2024 17:21:57 GMT, Andy Goryachev wrote: >> Modified the resize algorithm to work well with fractional scale, thanks for >> deeper understanding of the problem thanks to @hjohn and @mstr2 . >> >> Removed earlier manual tester in favor of the monkey tester. >> >> It is important

Re: RFR: 8301121: RichTextArea Control (Incubator) [v63]

2024-12-17 Thread Kevin Rushforth
On Tue, 17 Dec 2024 20:01:14 GMT, Andy Goryachev wrote: >> modules/jfx.incubator.input/src/main/java/jfx/incubator/scene/control/input/InputMap.java >> line 292: >> >>> 290: */ >>> 291: public void unregister(KeyBinding k) { >>> 292: map.put(k, NULL); >> >> Why does this add a

Re: RFR: 8301121: RichTextArea Control (Incubator) [v63]

2024-12-17 Thread Andy Goryachev
On Tue, 17 Dec 2024 18:42:45 GMT, Kevin Rushforth wrote: >> Andy Goryachev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review comments > > modules/jfx.incubator.input/src/main/java/jfx/incubator/scene/control/input/InputMap.java > l

Re: RFR: 8301121: RichTextArea Control (Incubator) [v63]

2024-12-17 Thread Andy Goryachev
On Tue, 17 Dec 2024 18:30:57 GMT, Kevin Rushforth wrote: >> Andy Goryachev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review comments > > modules/jfx.incubator.input/src/main/java/jfx/incubator/scene/control/input/InputMap.java > l

Re: RFR: 8345136: Update JDK_DOCS property to point to JDK 23 docs [v2]

2024-12-17 Thread Kevin Rushforth
On Tue, 17 Dec 2024 19:06:29 GMT, Andy Goryachev wrote: >> Kevin Rushforth has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Move jdk.docs.version before jfx.build.jdk.version > > build.properties line 92: > >> 90: jfx.build.jdk.version=2

Re: RFR: 8345136: Update JDK_DOCS property to point to JDK 23 docs

2024-12-17 Thread Kevin Rushforth
On Fri, 13 Dec 2024 00:52:00 GMT, Kevin Rushforth wrote: > Update the docs bundle to point to the JDK 23 docs (we're currently pointing > to JDK 21). > > I will need to also download and host a zip bundle and add its checksum to > gradle/verification-metadata.xml to avoid breaking our internal

Re: RFR: 8345136: Update JDK_DOCS property to point to JDK 23 docs [v2]

2024-12-17 Thread Andy Goryachev
On Tue, 17 Dec 2024 19:26:36 GMT, Kevin Rushforth wrote: >> Update the docs bundle to point to the JDK 23 docs (we're currently pointing >> to JDK 21). >> >> I will need to also download and host a zip bundle and add its checksum to >> gradle/verification-metadata.xml to avoid breaking our int

Re: RFR: 8345136: Update JDK_DOCS property to point to JDK 23 docs [v2]

2024-12-17 Thread Kevin Rushforth
> Update the docs bundle to point to the JDK 23 docs (we're currently pointing > to JDK 21). > > I will need to also download and host a zip bundle and add its checksum to > gradle/verification-metadata.xml to avoid breaking our internal CI build. > > As mentioned in [JDK-8325873](https://bugs.

Re: RFR: 8345136: Update JDK_DOCS property to point to JDK 23 docs

2024-12-17 Thread Andy Goryachev
On Fri, 13 Dec 2024 00:52:00 GMT, Kevin Rushforth wrote: > Update the docs bundle to point to the JDK 23 docs (we're currently pointing > to JDK 21). > > I will need to also download and host a zip bundle and add its checksum to > gradle/verification-metadata.xml to avoid breaking our internal

Re: RFR: 8301121: RichTextArea Control (Incubator) [v63]

2024-12-17 Thread Kevin Rushforth
On Fri, 13 Dec 2024 00:08:09 GMT, Andy Goryachev wrote: >> Incubating a new feature - rich text control, **RichTextArea**, intended to >> bridge the functional gap with Swing and its StyledEditorKit/JEditorPane. >> The main design goal is to provide a control that is complete enough to be >> u

Integrated: 8218745: TableView: visual glitch at borders on horizontal scrolling

2024-12-17 Thread Marius Hanl
On Thu, 23 May 2024 21:51:55 GMT, Marius Hanl wrote: > Alternative PR to https://github.com/openjdk/jfx/pull/1330 which does not > modify the layout of `VirtualFlow`. > > This PR fixes the glitching by removing the code in `NGNode.renderRectClip`, > which made many calculations leading to floa

Re: RFR: 8288893: Popup and its subclasses cannot input text from InputMethod [v4]

2024-12-17 Thread Andy Goryachev
On Fri, 13 Dec 2024 16:26:54 GMT, Martin Fox wrote: >> Input methods don’t work for text controls inside Popups. This PR fixes that. >> >> Some background: >> >> A PopupWindow always has an owner. The owner of the first Popup is a >> standard Window; I’ll refer to that as the root window. But

Re: RFR: 8346227: Seal Paint and Material [v2]

2024-12-17 Thread Andy Goryachev
On Tue, 17 Dec 2024 18:13:28 GMT, Michael Strauß wrote: >> modules/javafx.graphics/src/main/java/com/sun/javafx/tk/Toolkit.java line >> 597: >> >>> 595: >>> 596: public Object getPaint(Paint paint) { >>> 597: return switch (paint) { >> >> standard warning: not equivalent change (i

Re: RFR: 8346227: Seal Paint and Material [v2]

2024-12-17 Thread Michael Strauß
On Tue, 17 Dec 2024 18:01:57 GMT, Andy Goryachev wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> use exhaustive switch pattern > > modules/javafx.graphics/src/main/java/com/sun/javafx/tk/Toolkit.java line 597: >

Re: RFR: 8346227: Seal Paint and Material [v2]

2024-12-17 Thread Andy Goryachev
On Sat, 14 Dec 2024 17:16:20 GMT, Michael Strauß wrote: >> The `Paint` and `Material` classes can't be extended by user code, because >> their implementations require special support in internal JavaFX code. The >> classes should be sealed. > > Michael Strauß has updated the pull request increm

Re: RFR: 8343398: Add reducedData preference [v6]

2024-12-17 Thread Andy Goryachev
On Thu, 12 Dec 2024 01:03:26 GMT, Michael Strauß wrote: >> The `reducedData` preference instructs applications to minimize internet >> traffic, as users might be on a metered network or a limited data plan. >> >> This corresponds to the following OS settings: >> >> Windows: Settings -> Network

Re: RFR: 8345127: Add --sun-misc-unsafe-memory-access=allow when running tests until JDK-8334137 is fixed

2024-12-17 Thread Ambarish Rapte
On Wed, 27 Nov 2024 19:27:55 GMT, Kevin Rushforth wrote: > Add the `--sun-misc-unsafe-memory-access=allow` flag until > [JDK-8334137](https://bugs.openjdk.org/browse/JDK-8334137) is fixed to avoid > warnings when running tests (automated and manual) with JDK 24. > > I've tested this using a bo

Re: RFR: 8346227: Seal Paint and Material [v2]

2024-12-17 Thread Nir Lisker
On Sat, 14 Dec 2024 17:16:20 GMT, Michael Strauß wrote: >> The `Paint` and `Material` classes can't be extended by user code, because >> their implementations require special support in internal JavaFX code. The >> classes should be sealed. > > Michael Strauß has updated the pull request increm