On Fri, 13 Dec 2024 00:52:00 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
> Update the docs bundle to point to the JDK 23 docs (we're currently pointing > to JDK 21). > > I will need to also download and host a zip bundle and add its checksum to > gradle/verification-metadata.xml to avoid breaking our internal CI build. > > As mentioned in [JDK-8325873](https://bugs.openjdk.org/browse/JDK-8325873) > when we updated the docs to use JDK 21, we should do this as a part of > updating the boot JDK. To facilitate this, and to move more version number > properties to a common place, I will create a new `jdk.docs.version` property > in `build.properties` and put it near the `jfx.build.jdk.version` property. > > Both the GHA build and our CI build are successful. Marked as reviewed by angorya (Reviewer). build.properties line 92: > 90: jfx.build.jdk.version=23 > 91: jfx.build.jdk.buildnum=37 > 92: jdk.docs.version=23 very, very minor: maybe move this var to L95 so as not to break `jfx.build.jdk` block? (and also text in L76) ------------- PR Review: https://git.openjdk.org/jfx/pull/1663#pullrequestreview-2509848239 PR Review Comment: https://git.openjdk.org/jfx/pull/1663#discussion_r1889076646
