Re: RFR: 8301121: RichTextArea Control (Incubator) [v63]

[Andy Goryachev]

On Tue, 17 Dec 2024 18:30:57 GMT, Kevin Rushforth <k...@openjdk.org> wrote:

>> Andy Goryachev has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   review comments
>
> modules/jfx.incubator.input/src/main/java/jfx/incubator/scene/control/input/InputMap.java
>  line 287:
> 
>> 285:      * {@link #register(KeyBinding, Runnable)},
>> 286:      * {@link #registerKey(KeyBinding, FunctionTag)},
>> 287:      * or registered by the skin.
> 
> The "or registered by the skin" part seems doesn't seem right to me. Is that 
> really what happens? And if so, why is it the right thing to do?

this call disables the key binding, regardless of who registered it.

the use case example is Eclipse's "Unbind Command":

![Screenshot 2024-12-17 at 11 32 
33](https://github.com/user-attachments/assets/cb39eb4c-969b-4967-9c10-9acd133c33b9)

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1524#discussion_r1889109521