Re: RFR: 8301121: RichTextArea Control (Incubator) [v63]

2024-12-12 Thread Andy Goryachev
> Incubating a new feature - rich text control, **RichTextArea**, intended to > bridge the functional gap with Swing and its StyledEditorKit/JEditorPane. The > main design goal is to provide a control that is complete enough to be useful > out-of-the box, as well as open to extension by the appl

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v31]

2024-12-12 Thread Helly Guo
On Thu, 12 Dec 2024 15:25:29 GMT, Martin Fox wrote: >> ![pic_20241212193112](https://github.com/user-attachments/assets/7b9233f9-3af5-42d5-89f9-9f85248d68dd) >> >> The option is surrounded by a red box. > > @hellyguo Thanks so much for tracking this down and providing all the > details. I would

Re: RFR: 8301121: RichTextArea Control (Incubator) [v61]

2024-12-12 Thread Kevin Rushforth
On Thu, 12 Dec 2024 22:05:48 GMT, Andy Goryachev wrote: >> modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/model/RichParagraph.java >> line 216: >> >>> 214: * @return this {@code Builder} instance >>> 215: */ >>> 216: public Builder ad

Re: RFR: 8301121: RichTextArea Control (Incubator) [v62]

2024-12-12 Thread Andy Goryachev
> Incubating a new feature - rich text control, **RichTextArea**, intended to > bridge the functional gap with Swing and its StyledEditorKit/JEditorPane. The > main design goal is to provide a control that is complete enough to be useful > out-of-the box, as well as open to extension by the appl

Re: RFR: 8301121: RichTextArea Control (Incubator) [v61]

2024-12-12 Thread Andy Goryachev
On Thu, 12 Dec 2024 19:33:34 GMT, Kevin Rushforth wrote: >> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 83 commits: >> >> - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea >> - legal >>

Re: RFR: 8301121: RichTextArea Control (Incubator) [v61]

2024-12-12 Thread Andy Goryachev
On Thu, 12 Dec 2024 19:19:00 GMT, Kevin Rushforth wrote: >> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 83 commits: >> >> - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea >> - legal >>

Re: RFR: 8301121: RichTextArea Control (Incubator) [v61]

2024-12-12 Thread Andy Goryachev
On Thu, 12 Dec 2024 19:04:53 GMT, Kevin Rushforth wrote: >> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 83 commits: >> >> - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea >> - legal >>

Re: RFR: 8301121: RichTextArea Control (Incubator) [v61]

2024-12-12 Thread Andy Goryachev
On Thu, 12 Dec 2024 18:49:13 GMT, Kevin Rushforth wrote: >> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 83 commits: >> >> - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea >> - legal >>

Re: RFR: 8218745: TableView: visual glitch at borders on horizontal scrolling [v7]

2024-12-12 Thread Andy Goryachev
On Mon, 9 Dec 2024 23:53:54 GMT, Marius Hanl wrote: >> Alternative PR to https://github.com/openjdk/jfx/pull/1330 which does not >> modify the layout of `VirtualFlow`. >> >> This PR fixes the glitching by removing the code in `NGNode.renderRectClip`, >> which made many calculations leading to

Re: RFR: 8218745: TableView: visual glitch at borders on horizontal scrolling [v7]

2024-12-12 Thread Marius Hanl
On Thu, 12 Dec 2024 19:52:53 GMT, Andy Goryachev wrote: > please address the merge conflict. ? - PR Comment: https://git.openjdk.org/jfx/pull/1462#issuecomment-2540033618

Re: RFR: 8301121: RichTextArea Control (Incubator) [v61]

2024-12-12 Thread Andy Goryachev
On Thu, 12 Dec 2024 16:40:27 GMT, Kevin Rushforth wrote: >> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 83 commits: >> >> - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea >> - legal >>

Re: RFR: 8301121: RichTextArea Control (Incubator) [v61]

2024-12-12 Thread Andy Goryachev
On Thu, 12 Dec 2024 16:21:04 GMT, Kevin Rushforth wrote: >> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 83 commits: >> >> - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea >> - legal >>

Re: RFR: 8301121: RichTextArea Control (Incubator) [v59]

2024-12-12 Thread Andy Goryachev
On Tue, 10 Dec 2024 21:11:51 GMT, Kevin Rushforth wrote: >> Andy Goryachev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> unicode license > > modules/jfx.incubator.input/src/main/java/jfx/incubator/scene/control/input/KeyBinding.java >

Re: RFR: 8301121: RichTextArea Control (Incubator) [v59]

2024-12-12 Thread Kevin Rushforth
On Tue, 10 Dec 2024 20:00:47 GMT, Andy Goryachev wrote: >> Incubating a new feature - rich text control, **RichTextArea**, intended to >> bridge the functional gap with Swing and its StyledEditorKit/JEditorPane. >> The main design goal is to provide a control that is complete enough to be >> u

Re: RFR: 8301121: RichTextArea Control (Incubator) [v61]

2024-12-12 Thread Kevin Rushforth
On Wed, 11 Dec 2024 21:34:49 GMT, Andy Goryachev wrote: >> Incubating a new feature - rich text control, **RichTextArea**, intended to >> bridge the functional gap with Swing and its StyledEditorKit/JEditorPane. >> The main design goal is to provide a control that is complete enough to be >> u

Re: RFR: 8218745: TableView: visual glitch at borders on horizontal scrolling [v7]

2024-12-12 Thread Andy Goryachev
On Mon, 9 Dec 2024 23:53:54 GMT, Marius Hanl wrote: >> Alternative PR to https://github.com/openjdk/jfx/pull/1330 which does not >> modify the layout of `VirtualFlow`. >> >> This PR fixes the glitching by removing the code in `NGNode.renderRectClip`, >> which made many calculations leading to

Re: RFR: 8288893: Popup and its subclasses cannot input text from InputMethod [v3]

2024-12-12 Thread Andy Goryachev
On Tue, 12 Nov 2024 15:08:11 GMT, Martin Fox wrote: >> Input methods don’t work for text controls inside Popups. This PR fixes that. >> >> Some background: >> >> A PopupWindow always has an owner. The owner of the first Popup is a >> standard Window; I’ll refer to that as the root window. But

Re: RFR: 8345937: Update JUnit Platform to newest version

2024-12-12 Thread Michael Strauß
On Tue, 10 Dec 2024 18:07:44 GMT, Marius Hanl wrote: > The JUnit Platform got some updates over the last years, so it is a good idea > to update it to the newest version. > > That is from `5.8.1` to `5.11.3`. > Affected dependencies: > - `junit.jupiter` > - `junit.platform` > - `opentest4j` >

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v31]

2024-12-12 Thread Martin Fox
On Thu, 12 Dec 2024 11:41:20 GMT, Helly Guo wrote: >> Finally, I got the point. Fcitx5 has a setting entry: `Show preedit in >> application`. If this is on, it works well. If this is off, the value >> `im_ctx.on_preedit` will get `false` when im(`fcitx5`) finished >> input-action. Then, the in

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v31]

2024-12-12 Thread Helly Guo
On Thu, 12 Dec 2024 10:15:19 GMT, Helly Guo wrote: >> @hellyguo I can't reproduce the problem you're seeing. I configured a Debian >> Bookworm system with Fcitx5 and Pinyin and tested this PR and everything >> worked. The Linux and Fcitx version numbers are the same as yours. I also >> install

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v31]

2024-12-12 Thread Helly Guo
On Thu, 12 Dec 2024 11:38:37 GMT, Helly Guo wrote: >> @beldenfox , you are right. >> I created a brand new env in virt-manager: >> >> >> virt@virtdeb:~$ uname -a >> Linux virtdeb 6.1.0-28-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.119-1 >> (2024-11-22) x86_64 GNU/Linux >> >> virt@virtdeb:~$ cat

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v31]

2024-12-12 Thread Helly Guo
On Wed, 11 Dec 2024 16:46:02 GMT, Martin Fox wrote: >> hi @beldenfox / @tsayao , thanks for response. >> >> here is my env. >> >> >> # uname -a >> Linux workdeb 6.1.0-28-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.119-1 >> (2024-11-22) x86_64 GNU/Linux >> >> # cat /etc/os-release >> PRETTY_NAME=

Re: test SDKs for headless builds

2024-12-12 Thread Craig Raw
Hi Johan, I managed to solve this - I forgot (again) that javafx.graphics.jar does not contain the native libraries, and you have to repackage the jar to include them manually. Once I did this, everything worked successfully. I'm hoping the headless glass platform makes it into the JavaFX 24 rele