On Tue, 10 Dec 2024 21:11:51 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> unicode license > > modules/jfx.incubator.input/src/main/java/jfx/incubator/scene/control/input/KeyBinding.java > line 521: > >> 519: * >> 520: * @return this Builder >> 521: */ > > So you decided that the builders don't need the ability to clear a modifier > key? That seems fine (it could be added later if needed, but seems unlikely). not needed. the (only?) use case is to create a KeyBinding in one step. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1524#discussion_r1882820663
