On Thu, 12 Dec 2024 19:04:53 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 83 commits: >> >> - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea >> - legal >> - unicode license >> - add handler >> - review comments >> - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea >> - clamp >> - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea >> - review comments >> - review comments >> - ... and 73 more: https://git.openjdk.org/jfx/compare/b76c05b9...e5814b21 > > modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/model/StyledTextModel.java > line 124: > >> 122: * and fire the change events as a response, for example, to >> changes in its backing data storage. >> 123: * >> 124: * @return true if the model supports content modifications via the >> UI > > It isn't just UI operations that cannot be done here, right? right, re-phrased. > modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/model/StyledTextModel.java > line 138: > >> 136: * Returns the plain text string for the specified paragraph. The >> returned text string cannot be null >> 137: * and must not contain any control characters other than TAB. >> 138: * The caller should never attempt to ask for a paragraph outside >> of the valid range. > > Would it be better to specify an IOOBE? This is an abstract method, so the functionality is delegated to the model. If the model decides to throw an exception, so be it. Not sure what to say here. "The return value is undefined if the index falls outside the valid range"? ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1524#discussion_r1882958253 PR Review Comment: https://git.openjdk.org/jfx/pull/1524#discussion_r1882957723
