On Thu, 12 Dec 2024 19:33:34 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 83 commits: >> >> - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea >> - legal >> - unicode license >> - add handler >> - review comments >> - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea >> - clamp >> - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea >> - review comments >> - review comments >> - ... and 73 more: https://git.openjdk.org/jfx/compare/b76c05b9...e5814b21 > > modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/model/RichTextModel.java > line 132: > >> 130: @Override >> 131: protected void insertParagraph(int index, Supplier<Region> >> generator) { >> 132: // TODO > > What is the implication of not having implemented this yet? For now, the RichTextModel does not support arbitrary Regions only text. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1524#discussion_r1882984087