Re: RFR: 8301121: RichTextArea Control (Incubator) [v51]

2024-12-02 Thread Andy Goryachev
> Incubating a new feature - rich text control, **RichTextArea**, intended to > bridge the functional gap with Swing and its StyledEditorKit/JEditorPane. The > main design goal is to provide a control that is complete enough to be useful > out-of-the box, as well as open to extension by the appl

Re: RFR: 8309381: Support JavaFX incubator modules [v3]

2024-12-02 Thread Andy Goryachev
On Mon, 2 Dec 2024 17:04:06 GMT, Kevin Rushforth wrote: >> build.gradle line 2877: >> >>> 2875: // Add a project declaration for each incubator module here, leaving >>> the >>> 2876: // incubator placeholder lines as an example. >>> 2877: // BEGIN: incubator placeholder >> >> Q: maybe we shoul

Integrated: 8344899: Map RT-nnnn bug IDs to JDK-mmmmmmm in JavaFX sources

2024-12-02 Thread Marius Hanl
On Sat, 23 Nov 2024 23:42:42 GMT, Marius Hanl wrote: > This PR changes all `RT-` references to `JDK-XXX`. > It also removes all `http://javafx-jira.kenai.com/browse/` occurrences. > > As discussed, this will help a lot when looking up old issues, especially > since not everybody know ho

Re: RFR: 8301121: RichTextArea Control (Incubator) [v50]

2024-12-02 Thread Ambarish Rapte
On Fri, 22 Nov 2024 18:07:14 GMT, Andy Goryachev wrote: >> Incubating a new feature - rich text control, **RichTextArea**, intended to >> bridge the functional gap with Swing and its StyledEditorKit/JEditorPane. >> The main design goal is to provide a control that is complete enough to be >> u

Re: CSS Media Queries

2024-12-02 Thread Michael Strauß
> I wish there was a simpler way to introduce variables - I think the variables > might be a better solution from the stylesheet maintainability point of view, > and to help with supporting light/dark, compact/roomy variants and simple > things like updating the base font size. Doing a differen

A new theme for JavaFX

2024-12-02 Thread Michael Strauß
Continuing the discussion that was started in the CSS media queries thread: On Mon, Dec 2, 2024 at 11:55 PM Kevin Rushforth wrote: > > I'm thinking a bit bigger than just "Modena Dark". Since JFX 19, we've > > added focusVisible, platform preferences, CSS transitions, and now > > hopefully media

Re: RFR: 8345348: CSS Media Queries

2024-12-02 Thread Andy Goryachev
On Mon, 2 Dec 2024 16:19:46 GMT, Michael Strauß wrote: > Implementation of [CSS media > queries](https://gist.github.com/mstr2/cbb93bff03e073ec0c32aac317b22de7). modules/javafx.graphics/src/main/java/javafx/scene/Scene.java line 1212: > 1210: * @since 24 > 1211: */ > 1212: privat

Re: RFR: 8345348: CSS Media Queries

2024-12-02 Thread Michael Strauß
On Mon, 2 Dec 2024 21:24:52 GMT, Andy Goryachev wrote: >> Implementation of [CSS media >> queries](https://gist.github.com/mstr2/cbb93bff03e073ec0c32aac317b22de7). > > modules/javafx.graphics/src/main/java/javafx/scene/Scene.java line 1212: > >> 1210: * @since 24 >> 1211: */ >> 1212:

RFR: 8345348: CSS Media Queries

2024-12-02 Thread Michael Strauß
Implementation of [CSS media queries](https://gist.github.com/mstr2/cbb93bff03e073ec0c32aac317b22de7). - Commit messages: - Add persistentScrollBars media feature - Merge branch 'master' into feature/media-queries - Merge branch 'master' into feature/media-queries - Implementatio

Re: RFR: 8344372: Setting width for TRANSPARENT Stage -> gtk_window_resize: assertion 'height > 0' [v6]

2024-12-02 Thread Thiago Milczarek Sayao
> The bug happened when setting only width or height (not both) on a Stage that > was oriented by the view size. > > The fix just uses the previous value for width/height if not set. > > The test class is designed to accept more test cases in the "mixed sizing" > scenarios. Thiago Milczarek Sa

Re: RFR: 8344372: Setting width for TRANSPARENT Stage -> gtk_window_resize: assertion 'height > 0' [v4]

2024-12-02 Thread Kevin Rushforth
On Mon, 2 Dec 2024 22:14:11 GMT, Thiago Milczarek Sayao wrote: >> tests/system/src/test/java/test/javafx/stage/StageMixedSizeTest.java line >> 103: >> >>> 101: >>> 102: mainStage.setOnShown(e -> { >>> 103: Util.sleep(500); >> >> We don't want to sleep on the FX ap

Re: CSS Media Queries

2024-12-02 Thread Andy Goryachev
Thank you for clarifications! As Kevin already mentioned, developing a new stylesheet would be a monumental task. It might be easier to adjust the modena.css, since it's already pretty good (in my opinion). I wish there was a simpler way to introduce variables - I think the variables might be

Re: RFR: 8344372: Setting width for TRANSPARENT Stage -> gtk_window_resize: assertion 'height > 0' [v3]

2024-12-02 Thread Thiago Milczarek Sayao
On Mon, 2 Dec 2024 21:25:34 GMT, Kevin Rushforth wrote: >> Thiago Milczarek Sayao has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix test package > > tests/system/src/test/java/test/javafx/stage/StageMixedSizeTest.java line 111: > >> 1

Re: RFR: 8344372: Setting width for TRANSPARENT Stage -> gtk_window_resize: assertion 'height > 0' [v4]

2024-12-02 Thread Thiago Milczarek Sayao
On Mon, 2 Dec 2024 21:24:42 GMT, Kevin Rushforth wrote: >> Thiago Milczarek Sayao has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add sleep to avoid intermittent failures > > tests/system/src/test/java/test/javafx/stage/StageMixedSizeTes

Re: RFR: 8344372: Setting width for TRANSPARENT Stage -> gtk_window_resize: assertion 'height > 0' [v5]

2024-12-02 Thread Thiago Milczarek Sayao
> The bug happened when setting only width or height (not both) on a Stage that > was oriented by the view size. > > The fix just uses the previous value for width/height if not set. > > The test class is designed to accept more test cases in the "mixed sizing" > scenarios. Thiago Milczarek Sa

Re: RFR: 8344372: Setting width for TRANSPARENT Stage -> gtk_window_resize: assertion 'height > 0' [v4]

2024-12-02 Thread Kevin Rushforth
On Mon, 2 Dec 2024 21:14:18 GMT, Thiago Milczarek Sayao wrote: >> The bug happened when setting only width or height (not both) on a Stage >> that was oriented by the view size. >> >> The fix just uses the previous value for width/height if not set. >> >> The test class is designed to accept

Re: CSS Media Queries

2024-12-02 Thread Kevin Rushforth
I also think this is a good addition to JavaFX CSS. On 12/2/2024 11:32 AM, Michael Strauß wrote: 1. what are the plans / commitments for actually developing the dark mode stylesheet? I'm thinking a bit bigger than just "Modena Dark". Since JFX 19, we've added focusVisible, platform preferences

Re: RFR: 8344372: Setting width for TRANSPARENT Stage -> gtk_window_resize: assertion 'height > 0' [v3]

2024-12-02 Thread Kevin Rushforth
On Sat, 30 Nov 2024 16:14:22 GMT, Thiago Milczarek Sayao wrote: >> The bug happened when setting only width or height (not both) on a Stage >> that was oriented by the view size. >> >> The fix just uses the previous value for width/height if not set. >> >> The test class is designed to accept

Re: RFR: 8345261: Refactor the Dimension2D classes

2024-12-02 Thread Marius Hanl
On Fri, 29 Nov 2024 17:00:42 GMT, Nir Lisker wrote: > A small refactoring of the Dimension classes. > > * `com.sun.javafx.geom.Dimension` was removed and its uses were replaced by > `com.sun.javafx.geom.Dimension2D`. > * `com.sun.javafx.geom.Dimension2D` became a record. > * `javafx.geometry.Di

Re: RFR: 8309381: Support JavaFX incubator modules [v3]

2024-12-02 Thread Kevin Rushforth
> This PR add the necessary support for [JavaFX Incubator > Modules](https://github.com/kevinrushforth/jfx/blob/jfx.incubator/INCUBATOR-MODULES.md). > It includes the following: > > 1. Changes to the build scripts `build.gradle` and `settings.gradle` to > document where to add your incubator mo

Re: RFR: 8344372: Setting width for TRANSPARENT Stage -> gtk_window_resize: assertion 'height > 0' [v4]

2024-12-02 Thread Thiago Milczarek Sayao
> The bug happened when setting only width or height (not both) on a Stage that > was oriented by the view size. > > The fix just uses the previous value for width/height if not set. > > The test class is designed to accept more test cases in the "mixed sizing" > scenarios. Thiago Milczarek Sa

Re: RFR: 8344899: Map RT-nnnn bug IDs to JDK-mmmmmmm in JavaFX sources [v3]

2024-12-02 Thread Andy Goryachev
On Fri, 29 Nov 2024 09:20:37 GMT, Marius Hanl wrote: >> Marius Hanl has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8344899: Revert accidentally renamed test comments > > Solved the merge conflict with `GlassView3D.m`. Thank you @Maran2

Re: RFR: 8345188: Set :root pseudo-class on root node

2024-12-02 Thread Kevin Rushforth
On Thu, 28 Nov 2024 14:02:36 GMT, Michael Strauß wrote: > The CSS Selectors specification defines the `:root` pseudo-class that matches > root nodes: > https://www.w3.org/TR/selectors-4/#the-root-pseudo > > JavaFX uses the non-standard `.root` style class for the same purpose. We > should also

Re: CSS Media Queries

2024-12-02 Thread John Hendrikx
This looks like a good addition, allowing FX applications to blend in better with their platform, and responding to certain accessibility settings. --John On 02/12/2024 17:22, Michael Strauß wrote: > Hi everyone, > > here's a proposal to add media queries to JavaFX, which is a powerful > feature

Re: RFR: 8344372: Setting width for TRANSPARENT Stage -> gtk_window_resize: assertion 'height > 0' [v3]

2024-12-02 Thread Kevin Rushforth
On Sat, 30 Nov 2024 16:14:22 GMT, Thiago Milczarek Sayao wrote: >> The bug happened when setting only width or height (not both) on a Stage >> that was oriented by the view size. >> >> The fix just uses the previous value for width/height if not set. >> >> The test class is designed to accept

Integrated: 8343336: Add persistentScrollBars preference

2024-12-02 Thread Michael Strauß
On Thu, 31 Oct 2024 03:56:30 GMT, Michael Strauß wrote: > This PR adds another accessibility preference that is available on all > supported desktop platforms: > > 1. **Windows**: Settings -> Accessibility -> Visual Effects -> Always show > scroll bars > 2. **macOS**: System Settings -> Appear

Re: RFR: 8345261: Refactor the Dimension2D classes

2024-12-02 Thread Nir Lisker
On Fri, 29 Nov 2024 17:00:42 GMT, Nir Lisker wrote: > A small refactoring of the Dimension classes. > > * `com.sun.javafx.geom.Dimension` was removed and its uses were replaced by > `com.sun.javafx.geom.Dimension2D`. > * `com.sun.javafx.geom.Dimension2D` became a record. > * `javafx.geometry.Di

Re: Is there an ETA for Linux Wayland support?

2024-12-02 Thread Kevin Rushforth
Hi Davide, As both Thiago and Johan both mentioned, JavaFX is supported on Wayland using XWayland. This is the same way that AWT in the core JDK is supported on Wayland. Your JavaFX applications should run fine on Wayland, and if they don't, it's a bug that we should fix. Longer term, there

Re: RFR: 8339603: Seal the class hierarchy of Node, Camera, LightBase, Shape, Shape3D [v8]

2024-12-02 Thread Andy Goryachev
On Sat, 9 Nov 2024 07:45:14 GMT, Michael Strauß wrote: >> None of these classes can be extended by user code, and any attempt to do so >> will fail at runtime with an exception. For this reason, we can seal the >> class hierarchy and remove the run-time checks to turn this into a >> compile-ti

Re: RFR: 8345261: Refactor the Dimension2D classes

2024-12-02 Thread Kevin Rushforth
On Mon, 2 Dec 2024 19:18:18 GMT, Andy Goryachev wrote: >> A small refactoring of the Dimension classes. >> >> * `com.sun.javafx.geom.Dimension` was removed and its uses were replaced by >> `com.sun.javafx.geom.Dimension2D`. >> * `com.sun.javafx.geom.Dimension2D` became a record. >> * `javafx.ge

Re: Result: New OpenJFX Reviewer: Lukasz Kostyra

2024-12-02 Thread Andy Goryachev
Congratulations, Lukasz! -andy From: openjfx-dev on behalf of Kevin Rushforth Date: Tuesday, November 26, 2024 at 09:03 To: registrar , Lukasz Kostyra Cc: openjfx-dev Subject: Result: New OpenJFX Reviewer: Lukasz Kostyra Voting for Lukasz Kostyra [1] to OpenJFX Reviewer [2] is now closed.

Re: CSS Media Queries

2024-12-02 Thread Michael Strauß
> 1. what are the plans / commitments for actually developing the dark mode > stylesheet? I'm thinking a bit bigger than just "Modena Dark". Since JFX 19, we've added focusVisible, platform preferences, CSS transitions, and now hopefully media queries. After this is done, I think we should levera

Re: RFR: 8345261: Refactor the Dimension2D classes

2024-12-02 Thread Andy Goryachev
On Fri, 29 Nov 2024 17:00:42 GMT, Nir Lisker wrote: > A small refactoring of the Dimension classes. > > * `com.sun.javafx.geom.Dimension` was removed and its uses were replaced by > `com.sun.javafx.geom.Dimension2D`. > * `com.sun.javafx.geom.Dimension2D` became a record. > * `javafx.geometry.Di

Integrated: 8309381: Support JavaFX incubator modules

2024-12-02 Thread Kevin Rushforth
On Tue, 29 Oct 2024 22:23:35 GMT, Kevin Rushforth wrote: > This PR add the necessary support for [JavaFX Incubator > Modules](https://github.com/kevinrushforth/jfx/blob/jfx.incubator/INCUBATOR-MODULES.md). > It includes the following: > > 1. Changes to the build scripts `build.gradle` and `set

Re: CSS Media Queries

2024-12-02 Thread Andy Goryachev
At first glance, this proposal looks good, with it we could provide a dark mode stylesheet. Questions: 1. what are the plans / commitments for actually developing the dark mode stylesheet? 2. are there plans / necessity of adding more similar properties to the Scene? 3. are there plans to provi

Re: RFR: 8309381: Support JavaFX incubator modules [v3]

2024-12-02 Thread Andy Goryachev
On Mon, 2 Dec 2024 17:22:07 GMT, Kevin Rushforth wrote: >> This PR add the necessary support for [JavaFX Incubator >> Modules](https://github.com/kevinrushforth/jfx/blob/jfx.incubator/INCUBATOR-MODULES.md). >> It includes the following: >> >> 1. Changes to the build scripts `build.gradle` and

Re: RFR: 8342233: Regression: TextInputControl selection is backwards in RTL mode

2024-12-02 Thread Andy Goryachev
On Wed, 27 Nov 2024 14:15:53 GMT, Lukasz Kostyra wrote: >> A fix for [JDK-8319844](https://bugs.openjdk.org/browse/JDK-8319844) >> Text/TextFlow.hitTest() introduced a regression in the >> `TextArea`/`TextField`/`PasswordField` in the RTL mode. >> >> The fix is to flip the x coordinates when n

Re: RFR: 8309381: Support JavaFX incubator modules [v3]

2024-12-02 Thread Kevin Rushforth
On Mon, 2 Dec 2024 17:22:07 GMT, Kevin Rushforth wrote: >> This PR add the necessary support for [JavaFX Incubator >> Modules](https://github.com/kevinrushforth/jfx/blob/jfx.incubator/INCUBATOR-MODULES.md). >> It includes the following: >> >> 1. Changes to the build scripts `build.gradle` and

CSS Media Queries

2024-12-02 Thread Michael Strauß
Hi everyone, here's a proposal to add media queries to JavaFX, which is a powerful feature to adjust stylesheets to changes in the runtime environment. Proposal: https://gist.github.com/mstr2/cbb93bff03e073ec0c32aac317b22de7 PR: https://github.com/openjdk/jfx/pull/1655

Re: RFR: 8345261: Refactor the Dimension2D classes

2024-12-02 Thread Alexander Zvegintsev
On Mon, 2 Dec 2024 11:25:14 GMT, Nir Lisker wrote: > would you object to making Dimension an inner class of Rectangle? I am fine with it. - PR Comment: https://git.openjdk.org/jfx/pull/1653#issuecomment-2511707325

Re: RFR: 8343336: Add persistentScrollBars preference [v6]

2024-12-02 Thread Andy Goryachev
On Wed, 27 Nov 2024 00:26:16 GMT, Michael Strauß wrote: >> This PR adds another accessibility preference that is available on all >> supported desktop platforms: >> >> 1. **Windows**: Settings -> Accessibility -> Visual Effects -> Always show >> scroll bars >> 2. **macOS**: System Settings ->

Re: RFR: 8344372: Setting width for TRANSPARENT Stage -> gtk_window_resize: assertion 'height > 0' [v3]

2024-12-02 Thread Kevin Rushforth
On Sat, 30 Nov 2024 16:14:22 GMT, Thiago Milczarek Sayao wrote: >> The bug happened when setting only width or height (not both) on a Stage >> that was oriented by the view size. >> >> The fix just uses the previous value for width/height if not set. >> >> The test class is designed to accept

Re: RFR: 8309381: Support JavaFX incubator modules [v3]

2024-12-02 Thread Andy Goryachev
On Mon, 2 Dec 2024 17:22:07 GMT, Kevin Rushforth wrote: >> This PR add the necessary support for [JavaFX Incubator >> Modules](https://github.com/kevinrushforth/jfx/blob/jfx.incubator/INCUBATOR-MODULES.md). >> It includes the following: >> >> 1. Changes to the build scripts `build.gradle` and

Re: RFR: 8309381: Support JavaFX incubator modules [v3]

2024-12-02 Thread Kevin Rushforth
On Tue, 5 Nov 2024 22:31:14 GMT, Andy Goryachev wrote: >> Kevin Rushforth has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains six additional >> comm

Re: RFR: 8345261: Refactor the Dimension2D classes

2024-12-02 Thread Nir Lisker
On Fri, 29 Nov 2024 17:00:42 GMT, Nir Lisker wrote: > A small refactoring of the Dimension classes. > > * `com.sun.javafx.geom.Dimension` was removed and its uses were replaced by > `com.sun.javafx.geom.Dimension2D`. > * `com.sun.javafx.geom.Dimension2D` became a record. > * `javafx.geometry.Di

Re: RFR: 8345261: Refactor the Dimension2D classes

2024-12-02 Thread Nir Lisker
On Mon, 2 Dec 2024 02:19:46 GMT, Alexander Zvegintsev wrote: >> A small refactoring of the Dimension classes. >> >> * `com.sun.javafx.geom.Dimension` was removed and its uses were replaced by >> `com.sun.javafx.geom.Dimension2D`. >> * `com.sun.javafx.geom.Dimension2D` became a record. >> * `ja