On Mon, 2 Dec 2024 17:22:07 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> This PR add the necessary support for [JavaFX Incubator >> Modules](https://github.com/kevinrushforth/jfx/blob/jfx.incubator/INCUBATOR-MODULES.md). >> It includes the following: >> >> 1. Changes to the build scripts `build.gradle` and `settings.gradle` to >> document where to add your incubator module. Also added `jlink` flags to not >> resolve incubator modules by default and warn when resolving (same as is >> done for JDK incubator modules). >> 2. A utility class to produce warnings when first using an incubator module. >> 3. Changes to `javafx.base/module-info.java` to document where to add the >> needed qualified exports to your module to access the utility class in 2. >> >> See PR #1617 for a sample module that is built on top of this PR's source >> branch. >> >> This is almost ready to review. I will take it out of Draft in the next day >> or so. > > Kevin Rushforth has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains six additional > commits since the last revision: > > - Add pointer to CSR in JBS > - Remove extra blank lines > - Merge branch 'master' into 8309381-incubator.dev > - Merge branch 'master' into 8309381-incubator.dev > - Remove call to doPrivileged > - 8309381: Support JavaFX incubator modules Marked as reviewed by angorya (Reviewer). ------------- PR Review: https://git.openjdk.org/jfx/pull/1616#pullrequestreview-2473400343
