On Mon, 28 Oct 2024 20:44:39 GMT, Andy Goryachev wrote:
> I think it should be consistent: it is, after all, the **minimum height**.
>
> Applications that want larger title bar can easily achieve that, but the
> minimum height **must** be set to the same height as the standard
> javaFX-created
> This PR is a new take on a highly requested feature: JavaFX controls in the
> header bar (see also #594 for an earlier iteration).
>
> This is a feature with many possible ways to skin the cat, and it has taken
> quite a bit of effort to come up with a good user model. In contrast to the
> pr
On Wed, 23 Oct 2024 20:10:02 GMT, Kevin Rushforth wrote:
> This PR removes all doPrivileged calls from `com.sun.javafx.tk**` in the
> `javafx.graphics` module.
>
> Here is a quick overview of what I did for this fix:
>
> 1. Changed all simple cases of `doPrivileged((PrivilegedAction) () ->
>
On Mon, 28 Oct 2024 23:01:39 GMT, Andy Goryachev wrote:
>> Incubating a new feature - rich text control, **RichTextArea**, intended to
>> bridge the functional gap with Swing and its StyledEditorKit/JEditorPane.
>> The main design goal is to provide a control that is complete enough to be
>> u
On Mon, 28 Oct 2024 23:01:39 GMT, Andy Goryachev wrote:
>> Incubating a new feature - rich text control, **RichTextArea**, intended to
>> bridge the functional gap with Swing and its StyledEditorKit/JEditorPane.
>> The main design goal is to provide a control that is complete enough to be
>> u
On Mon, 28 Oct 2024 23:20:49 GMT, Andy Goryachev wrote:
>>> If this flag is suddenly so important, then why doesn't `requestFocus` have
>>> it?
>>
>> That's easy: because we didn't deem it necessary. Back when we added the
>> flag, only internal code would be able to set it, and that has worke
On Mon, 28 Oct 2024 23:08:54 GMT, Michael Strauß wrote:
>> This PR is a new take on a highly requested feature: JavaFX controls in the
>> header bar (see also #594 for an earlier iteration).
>>
>> This is a feature with many possible ways to skin the cat, and it has taken
>> quite a bit of eff
> This replaces obsolete XIM and uses gtk api for IME.
> Gtk uses [ibus](https://github.com/ibus/ibus)
>
> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative
> positioning on `InputMethodRequest`.
>
> [Screencast from 17-09-2023
> 21:59:04.webm](https://github.com/openj
On Mon, 28 Oct 2024 23:13:50 GMT, Michael Strauß wrote:
>> Good question, @hjohn . Why indeed, @mstr2 ?
>
>> If this flag is suddenly so important, then why doesn't `requestFocus` have
>> it?
>
> That's easy: because we didn't deem it necessary. Back when we added the
> flag, only internal c
On Mon, 28 Oct 2024 22:37:34 GMT, Andy Goryachev wrote:
>> If this flag is suddenly so important, then why doesn't `requestFocus` have
>> it?
>>
>> I feel that we've found an internal inconsistency, and that the solution is
>> to then drop this on the user to ensure correctness (the wording "c
On Wed, 23 Oct 2024 09:36:56 GMT, Ajit Ghaisas wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> break iterator
>
> modules/jfx.incubator.richtext/src/main/java/com/sun/jfx/incubator/scene/control/richtext/Highligh
On Mon, 28 Oct 2024 22:21:51 GMT, Andy Goryachev wrote:
> the exception is gone, the flicker remains.
Can you verify? I can't observe it on my system with the latest fix.
-
PR Comment: https://git.openjdk.org/jfx/pull/1605#issuecomment-2442836942
> This PR is a new take on a highly requested feature: JavaFX controls in the
> header bar (see also #594 for an earlier iteration).
>
> This is a feature with many possible ways to skin the cat, and it has taken
> quite a bit of effort to come up with a good user model. In contrast to the
> pr
On Wed, 23 Oct 2024 09:36:18 GMT, Ajit Ghaisas wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> break iterator
>
> modules/jfx.incubator.richtext/src/main/java/com/sun/jfx/incubator/scene/control/richtext/Highligh
> Incubating a new feature - rich text control, **RichTextArea**, intended to
> bridge the functional gap with Swing and its StyledEditorKit/JEditorPane. The
> main design goal is to provide a control that is complete enough to be useful
> out-of-the box, as well as open to extension by the appl
On Mon, 28 Oct 2024 20:00:02 GMT, Kevin Rushforth wrote:
>> I don't indent case labels inside of switch.
>> I don't think we enforce one way or the other.
>>
>> And you can't ask to make it more compact and then complain that it's more
>> compact /jk
>
>> I don't indent case labels inside of sw
On Mon, 28 Oct 2024 22:31:18 GMT, John Hendrikx wrote:
>>> I like that, it clearly explains what to do. thank you!
>>
>> I do, too. When I read the discussion up to the point Michael proposed this,
>> my thought was that the only way to solve it is with a parameter like this.
>>
>>> Somewhat t
On Mon, 28 Oct 2024 20:04:06 GMT, Michael Strauß wrote:
>> This PR is a new take on a highly requested feature: JavaFX controls in the
>> header bar (see also #594 for an earlier iteration).
>>
>> This is a feature with many possible ways to skin the cat, and it has taken
>> quite a bit of eff
On Mon, 28 Oct 2024 19:49:39 GMT, Kevin Rushforth wrote:
>> Somewhat tangential question: should we start placing JEPs in
>> `/doc-files/jeps` ?
>>
>> The use of private repos is ok at the initial stages of discussion, but at
>> some point we are risking the bit rot: private repos can be remov
On Mon, 28 Oct 2024 22:09:17 GMT, Michael Strauß wrote:
>> This PR is a new take on a highly requested feature: JavaFX controls in the
>> header bar (see also #594 for an earlier iteration).
>>
>> This is a feature with many possible ways to skin the cat, and it has taken
>> quite a bit of eff
> This PR is a new take on a highly requested feature: JavaFX controls in the
> header bar (see also #594 for an earlier iteration).
>
> This is a feature with many possible ways to skin the cat, and it has taken
> quite a bit of effort to come up with a good user model. In contrast to the
> pr
On Mon, 28 Oct 2024 21:29:14 GMT, Andy Goryachev wrote:
> I am getting exceptions on win11:
I didn't catch that one because I was testing without assertions. Fixed.
-
PR Comment: https://git.openjdk.org/jfx/pull/1605#issuecomment-2442700914
On Mon, 28 Oct 2024 20:04:06 GMT, Michael Strauß wrote:
>> This PR is a new take on a highly requested feature: JavaFX controls in the
>> header bar (see also #594 for an earlier iteration).
>>
>> This is a feature with many possible ways to skin the cat, and it has taken
>> quite a bit of eff
On Mon, 28 Oct 2024 20:04:06 GMT, Michael Strauß wrote:
>> This PR is a new take on a highly requested feature: JavaFX controls in the
>> header bar (see also #594 for an earlier iteration).
>>
>> This is a feature with many possible ways to skin the cat, and it has taken
>> quite a bit of eff
On Mon, 28 Oct 2024 20:23:50 GMT, Andy Goryachev wrote:
> re: header bar height (on mac). It looks super weird that the title is larger
> than the native - I would expect it to be the same.
>
> How does macOS itself determine the height?
>
> Silly idea: can we create a dummy Stage and measure
On Mon, 28 Oct 2024 20:04:06 GMT, Michael Strauß wrote:
>> This PR is a new take on a highly requested feature: JavaFX controls in the
>> header bar (see also #594 for an earlier iteration).
>>
>> This is a feature with many possible ways to skin the cat, and it has taken
>> quite a bit of eff
On Mon, 28 Oct 2024 20:14:05 GMT, Michael Strauß wrote:
>> modules/javafx.graphics/src/main/java/javafx/stage/StageStyle.java line 83:
>>
>>> 81: *
>>> 82: * An extended window has the default window buttons (minimize,
>>> maximize, close), but no system-provided
>>> 83: * dragg
On Mon, 28 Oct 2024 20:04:06 GMT, Michael Strauß wrote:
>> This PR is a new take on a highly requested feature: JavaFX controls in the
>> header bar (see also #594 for an earlier iteration).
>>
>> This is a feature with many possible ways to skin the cat, and it has taken
>> quite a bit of eff
On Mon, 28 Oct 2024 20:37:01 GMT, Andy Goryachev wrote:
> I think it should be consistent with the height of the DECORATED style (i.e.
> the rest of the windows created by JavaFX).
I can see two reasons to consider a larger style:
1. The classic style has fallen out of favor on contemporary mac
On Mon, 28 Oct 2024 20:30:25 GMT, Thiago Milczarek Sayao
wrote:
>> This replaces obsolete XIM and uses gtk api for IME.
>> Gtk uses [ibus](https://github.com/ibus/ibus)
>>
>> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative
>> positioning on `InputMethodRequest`.
>>
> This replaces obsolete XIM and uses gtk api for IME.
> Gtk uses [ibus](https://github.com/ibus/ibus)
>
> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative
> positioning on `InputMethodRequest`.
>
> [Screencast from 17-09-2023
> 21:59:04.webm](https://github.com/openj
On Mon, 28 Oct 2024 20:04:06 GMT, Michael Strauß wrote:
>> This PR is a new take on a highly requested feature: JavaFX controls in the
>> header bar (see also #594 for an earlier iteration).
>>
>> This is a feature with many possible ways to skin the cat, and it has taken
>> quite a bit of eff
On Mon, 28 Oct 2024 18:05:35 GMT, Andy Goryachev wrote:
>> Michael Strauß has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 13 additional
>> commi
On Mon, 28 Oct 2024 19:52:05 GMT, Andy Goryachev wrote:
> I would have preferred to have the pref height to be set to a special
> constant,
I tried to do that, but it doesn't work: `Region.minHeight(double)`
special-cases exactly two constants, `USE_COMPUTED_SIZE` and `USE_PREF_SIZE`.
The met
> This replaces obsolete XIM and uses gtk api for IME.
> Gtk uses [ibus](https://github.com/ibus/ibus)
>
> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative
> positioning on `InputMethodRequest`.
>
> [Screencast from 17-09-2023
> 21:59:04.webm](https://github.com/openj
On Mon, 28 Oct 2024 16:30:36 GMT, Andy Goryachev wrote:
> I don't indent case labels inside of switch.
Our typical code style is to indent. I don't have a strong preference, but I
switched (pun intended) many years ago from not indenting to always indenting
because: A) the IDEs (at least most
> This PR is a new take on a highly requested feature: JavaFX controls in the
> header bar (see also #594 for an earlier iteration).
>
> This is a feature with many possible ways to skin the cat, and it has taken
> quite a bit of effort to come up with a good user model. In contrast to the
> pr
On Mon, 28 Oct 2024 19:41:07 GMT, Michael Strauß wrote:
>> This PR is a new take on a highly requested feature: JavaFX controls in the
>> header bar (see also #594 for an earlier iteration).
>>
>> This is a feature with many possible ways to skin the cat, and it has taken
>> quite a bit of eff
On Mon, 28 Oct 2024 19:23:18 GMT, Andy Goryachev wrote:
>> also updated the JEP:
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md
>
> Somewhat tangential question: should we start placing JEPs in
> `/doc-files/jeps` ?
>
> The use of private repo
On Mon, 28 Oct 2024 19:20:51 GMT, Andy Goryachev wrote:
>> I like that, it clearly explains what to do. thank you!
>
> also updated the JEP:
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md
Somewhat tangential question: should we start placing JE
> This PR is a new take on a highly requested feature: JavaFX controls in the
> header bar (see also #594 for an earlier iteration).
>
> This is a feature with many possible ways to skin the cat, and it has taken
> quite a bit of effort to come up with a good user model. In contrast to the
> pr
On Mon, 28 Oct 2024 19:03:41 GMT, Andy Goryachev wrote:
>> What do you think of the following:
>>
>> * @param visible Specifies whether the {@link #focusVisibleProperty()
>> focusVisible} flag will be
>> *set on the node that receives focus. Callers must specify
>> {@code true}
> Public focus traversal API for use in custom controls
>
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md
>
> This work is loosely based on the patch
> https://cr.openjdk.org/~jgiles/8061673/
>
> And is a scaled down version (with the public trav
On Mon, 28 Oct 2024 18:35:23 GMT, Andy Goryachev wrote:
>> Let's consider a few scenarios:
>>
>> 1. A node has acquired focus via keyboard navigation. Its `focusVisible` bit
>> is set. When I press "tab", I expect the next node to also have visible
>> focus. This is the status quo.
>> 2. Same
On Mon, 28 Oct 2024 19:02:05 GMT, Michael Strauß wrote:
>> I think the javadoc for `Node.focusVisible` (and its sibling
>> `Node.focusWithin`) is rather insufficient. The JBS ticket is not a
>> normative document, perhaps this should be clarified in a follow-up ticket
>> (by moving some of th
On Mon, 28 Oct 2024 18:07:17 GMT, Michael Strauß wrote:
>> Maybe we should say that `Node.requestFocusTraversal()` should only be
>> called by custom components/skins as a response to key press? I can't see a
>> way to enforce that particular rule.
>>
>> Or perhaps `Node.focusVisible` doc sho
On Mon, 28 Oct 2024 17:36:33 GMT, Michael Strauß wrote:
>> This PR is a new take on a highly requested feature: JavaFX controls in the
>> header bar (see also #594 for an earlier iteration).
>>
>> This is a feature with many possible ways to skin the cat, and it has taken
>> quite a bit of eff
On Mon, 28 Oct 2024 17:36:33 GMT, Michael Strauß wrote:
>> This PR is a new take on a highly requested feature: JavaFX controls in the
>> header bar (see also #594 for an earlier iteration).
>>
>> This is a feature with many possible ways to skin the cat, and it has taken
>> quite a bit of eff
Dear Michael:
Could you add another row to the table in the JEP clarifying who is responsible
for the application title?
I would like to suggest to include this table in the javadoc - where do you
think it should be? HeaderBar?
Thanks,
-andy
From: openjfx-dev on behalf of Michael Strauß
On Mon, 28 Oct 2024 17:36:33 GMT, Michael Strauß wrote:
>> This PR is a new take on a highly requested feature: JavaFX controls in the
>> header bar (see also #594 for an earlier iteration).
>>
>> This is a feature with many possible ways to skin the cat, and it has taken
>> quite a bit of eff
On Mon, 28 Oct 2024 17:43:41 GMT, Andy Goryachev wrote:
>> I just quoted you the JavaFX specification, not W3C. It very clearly says
>> that the `focusVisible` flag is only set when a node acquires focus as a
>> result of keyboard navigation. You are proposing to extend the API to change
>> fo
On Mon, 28 Oct 2024 17:36:33 GMT, Michael Strauß wrote:
>> This PR is a new take on a highly requested feature: JavaFX controls in the
>> header bar (see also #594 for an earlier iteration).
>>
>> This is a feature with many possible ways to skin the cat, and it has taken
>> quite a bit of eff
> This PR is a new take on a highly requested feature: JavaFX controls in the
> header bar (see also #594 for an earlier iteration).
>
> This is a feature with many possible ways to skin the cat, and it has taken
> quite a bit of effort to come up with a good user model. In contrast to the
> pr
On Mon, 28 Oct 2024 09:23:50 GMT, Thiago Milczarek Sayao
wrote:
> The current behavior is do adapt to Scene background.
>
> As it does not fit all scenarios, I would not adapt it at all, and provide a
> way to developers to CSS style the Window Controls overlay.
There are good reasons to adap
> This PR is an improved version of #1093.
>
> JavaFX can load BMP, GIF, PNG, and JPEG images with its built-in image
> loaders. It has been a long-standing request to support more image formats,
> most notably (but not limited to) SVG. However, adding more built-in image
> loaders is a signifi
On Mon, 28 Oct 2024 17:37:36 GMT, Michael Strauß wrote:
>> To clarify, this PR changes nothing in the way FX behaves in relation to
>> focus. Nothing. I only provided a public API for use in custom controls.
>>
>> So whatever discrepancy between FX and w3.org spec you mention (not sure
>> w
On Mon, 28 Oct 2024 17:33:46 GMT, Andy Goryachev wrote:
>> Because `focusVisible` is specified to _only_ be set as a result of keyboard
>> navigation, not as a result of programmatic navigation.
>>
>> `Node.focusVisible` specifies:
>>
>> /**
>> * Indicates whether this {@code Node} sh
On Mon, 28 Oct 2024 17:28:55 GMT, Michael Strauß wrote:
>> I do not. Why do you say that?
>
> Because `focusVisible` is specified to _only_ be set as a result of keyboard
> navigation, not as a result of programmatic navigation.
>
> `Node.focusVisible` specifies:
>
> /**
> * Indicate
On Mon, 28 Oct 2024 16:05:40 GMT, Andy Goryachev wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/Node.java line 10443:
>>
>>> 10441: /**
>>> 10442: * Requests focus traversal from this {@code Node} in the
>>> specified direction.
>>> 10443: * A successful traversal re
On Mon, 28 Oct 2024 17:25:15 GMT, Andy Goryachev wrote:
>> So you're proposing to change the specification of `focusVisible`. That
>> needs to be discussed first.
>
> I do not. Why do you say that?
Because `focusVisible` is specified to _only_ be set as a result of keyboard
navigation, not as
On Mon, 28 Oct 2024 17:23:22 GMT, Michael Strauß wrote:
>> The rationale is that this PR does not change the way the current focus
>> subsystem works, only provides the public API.
>
> So you're proposing to change the specification of `focusVisible`. That needs
> to be discussed first.
I do n
Removes doPrivileged in the following module:
- javafx.controls
See JDK-8342441 for details.
As a helpful hint for reviewers, I recommend reviewing this using the "Hide
whitespace" option.
-
Commit messages:
- Merge remote-tracking branch 'origin/master' into
8342911.do.privilig
> Public focus traversal API for use in custom controls
>
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md
>
> This work is loosely based on the patch
> https://cr.openjdk.org/~jgiles/8061673/
>
> And is a scaled down version (with the public trav
On Mon, 28 Oct 2024 16:21:25 GMT, Nir Lisker wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review comments
>
> modules/javafx.graphics/src/main/java/javafx/scene/Node.java line 10458:
>
>> 10456: case
Removes `doPrivileged` in the following module:
* javafx.fxml
See JDK-8342441 for details.
As a helpful hint for reviewers, I recommend reviewing this using the "Hide
whitespace" option.
-
Commit messages:
- Merge remote-tracking branch 'origin/master' into 8342912.do.privileged.
Removes doPrivileged in the following module:
- javafx.media
See JDK-8342441 for details.
As a helpful hint for reviewers, I recommend reviewing this using the "Hide
whitespace" option.
-
Commit messages:
- Merge remote-tracking branch 'origin/master' into 8342913.do.privileged.m
On Mon, 28 Oct 2024 06:09:40 GMT, Michael Strauß wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review comments
>
> modules/javafx.graphics/src/main/java/javafx/scene/Node.java line 10443:
>
>> 10441: /**
>
On Mon, 28 Oct 2024 16:13:37 GMT, Andy Goryachev wrote:
>> Public focus traversal API for use in custom controls
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md
>>
>> This work is loosely based on the patch
>> https://cr.openjdk.org/~jgiles/
Removes doPrivileged in the following module:
- javafx.swt
See JDK-8342441 for details.
As a helpful hint for reviewers, I recommend reviewing this using the "Hide
whitespace" option.
-
Commit messages:
- Merge remote-tracking branch 'origin/master' into 8342914.do.privileged.swt
Removes doPrivileged in the following module:
- javafx.swing
See JDK-8342441 for details.
As a helpful hint for reviewers, I recommend reviewing this using the "Hide
whitespace" option.
-
Commit messages:
- Merge remote-tracking branch 'origin/master' into 8342457.do.privileged.s
On Sat, 26 Oct 2024 14:53:38 GMT, Nir Lisker wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review comments
>
> modules/javafx.graphics/src/main/java/javafx/scene/Node.java line 10442:
>
>> 10440:
>> 10441:
> Public focus traversal API for use in custom controls
>
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md
>
> This work is loosely based on the patch
> https://cr.openjdk.org/~jgiles/8061673/
>
> And is a scaled down version (with the public trav
On Mon, 28 Oct 2024 07:47:21 GMT, Johan Vos wrote:
> Bump the release version in .jcheck/conf and build.properties to 21.0.6
This pull request has now been integrated.
Changeset: 9e3dfb33
Author:Johan Vos
URL:
https://git.openjdk.org/jfx21u/commit/9e3dfb3355713cd257f6a3c9ab5b64eec8a
On Mon, 28 Oct 2024 15:01:20 GMT, Prasanta Sadhukhan
wrote:
> When AWT toolkit is started first for it to own the "NSApplication" and then
> FX toolkit is started and shutdown by calling `Platform.exit` and then Swing
> Dialog is tried to be created, then it is seen that the application crashe
On Sat, 26 Oct 2024 14:37:49 GMT, Nir Lisker wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review comments
>
> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/ListenerHelper.java
> line 466:
On Wed, 23 Oct 2024 20:10:02 GMT, Kevin Rushforth wrote:
> This PR removes all doPrivileged calls from `com.sun.javafx.tk**` in the
> `javafx.graphics` module.
>
> Here is a quick overview of what I did for this fix:
>
> 1. Changed all simple cases of `doPrivileged((PrivilegedAction) () ->
>
On Mon, 28 Oct 2024 07:50:32 GMT, Johan Vos wrote:
> Bump release version to 17.0.14
This pull request has now been integrated.
Changeset: 9fecccf8
Author:Johan Vos
URL:
https://git.openjdk.org/jfx17u/commit/9fecccf8cf7bdb8e5aca5c82fd4a4b4b67a509e4
Stats: 2 lines in 2 files chan
On Sat, 26 Oct 2024 14:34:38 GMT, Nir Lisker wrote:
>> Plain `requestFocus` can also work as it can be overloaded with the
>> direction parameter.
>
> I like the overloaded `requestFocus` idea as well.
I really dislike overloading in this case - the semantics of these two methods
is totally di
On Mon, 28 Oct 2024 15:01:20 GMT, Prasanta Sadhukhan
wrote:
> When AWT toolkit is started first for it to own the "NSApplication" and then
> FX toolkit is started and shutdown by calling `Platform.exit` and then Swing
> Dialog is tried to be created, then it is seen that the application crashe
When AWT toolkit is started first for it to own the "NSApplication" and then FX
toolkit is started and shutdown by calling `Platform.exit` and then Swing
Dialog is tried to be created, then it is seen that the application crashes as
the AWT dialog tries to create the underlying Window as a child
On Wed, 23 Oct 2024 20:10:02 GMT, Kevin Rushforth wrote:
> This PR removes all doPrivileged calls from `com.sun.javafx.tk**` in the
> `javafx.graphics` module.
>
> Here is a quick overview of what I did for this fix:
>
> 1. Changed all simple cases of `doPrivileged((PrivilegedAction) () ->
>
This PR removes all doPrivileged calls from `com.sun.javafx.tk**` in the
`javafx.graphics` module.
Here is a quick overview of what I did for this fix:
1. Changed all simple cases of `doPrivileged((PrivilegedAction) () ->
LAMBDA)` to `LAMBDA`, removing the `@SuppressWarnings("removal")` if pos
On Mon, 7 Oct 2024 20:03:49 GMT, Kevin Rushforth wrote:
> This PR removes support for running JavaFX applications with the Java
> Security Manager.
>
> The initial work was done in 4 separate commits as follows:
>
> * Fail fast at startup if the Security Manager is enabled
> * Remove `-Djava.s
On Wed, 23 Oct 2024 19:36:53 GMT, Kevin Rushforth wrote:
>> This PR removes support for running JavaFX applications with the Java
>> Security Manager.
>>
>> The initial work was done in 4 separate commits as follows:
>>
>> * Fail fast at startup if the Security Manager is enabled
>> * Remove `
On Mon, 28 Oct 2024 05:53:12 GMT, Michael Strauß wrote:
> > I've found bug on resize cursors. Tried to investigate it but didn't find
> > an reasonable explanation:
> > If you go do a resize border triggering the cursor change and then move the
> > cursor through the window without clicking to
On Mon, 28 Oct 2024 05:39:45 GMT, Michael Strauß wrote:
>> This PR is a new take on a highly requested feature: JavaFX controls in the
>> header bar (see also #594 for an earlier iteration).
>>
>> This is a feature with many possible ways to skin the cat, and it has taken
>> quite a bit of eff
On Mon, 28 Oct 2024 07:50:32 GMT, Johan Vos wrote:
> Bump release version to 17.0.14
Marked as reviewed by jpereda (Reviewer).
-
PR Review: https://git.openjdk.org/jfx17u/pull/208#pullrequestreview-2398292368
On Mon, 28 Oct 2024 07:47:21 GMT, Johan Vos wrote:
> Bump the release version in .jcheck/conf and build.properties to 21.0.6
Marked as reviewed by jpereda (Reviewer).
-
PR Review: https://git.openjdk.org/jfx21u/pull/73#pullrequestreview-2398293692
On Fri, 11 Oct 2024 10:57:34 GMT, Lukasz Kostyra wrote:
> This PR adds a title-mentioned fallback to `ImageStorage.java` and a test for
> that specific scenario.
>
> In `ImageStorage.loadAll()` we still prefer the Image path that was provided
> by the user, but if it is missing we will now try
Bump release version to 17.0.14
-
Commit messages:
- Bump release version to 17.0.14
Changes: https://git.openjdk.org/jfx17u/pull/208/files
Webrev: https://webrevs.openjdk.org/?repo=jfx17u&pr=208&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8343135
Stats: 2 lines in 2 f
Bump the release version in .jcheck/conf and build.properties to 21.0.6
-
Commit messages:
- 8343136: increase release version to 21.0.6
Changes: https://git.openjdk.org/jfx21u/pull/73/files
Webrev: https://webrevs.openjdk.org/?repo=jfx21u&pr=73&range=00
Issue: https://bugs.open
On Fri, 3 May 2024 14:45:24 GMT, John Hendrikx wrote:
> This PR provides a fix for the linked issue.
>
> The issue was that when an invalidation listener is removed, and the
> `ExpressionHelper` type changes from `Generic` to `SingleChange` that it
> would copy the current value of the `Generi
92 matches
Mail list logo
