On Mon, 28 Oct 2024 23:01:39 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Incubating a new feature - rich text control, **RichTextArea**, intended to >> bridge the functional gap with Swing and its StyledEditorKit/JEditorPane. >> The main design goal is to provide a control that is complete enough to be >> useful out-of-the box, as well as open to extension by the application >> developers. >> >> This is a complex feature with a large API surface that would be nearly >> impossible to get right the first time, even after an extensive review. We >> are, therefore, introducing this in an incubating module, >> **jfx.incubator.richtext**. This will allow us to evolve the API in future >> releases without the strict compatibility constraints that other JavaFX >> modules have. >> >> Please check out two manual test applications - one for RichTextArea >> (**RichTextAreaDemoApp**) and one for the CodeArea (**CodeAreaDemoApp**). >> Also, a small example provides a standalone rich text editor, see >> **RichEditorDemoApp**. >> >> Because it's an incubating module, please focus on the public APIs rather >> than implementation. There **will be** changes to the implementation >> once/if the module is promoted to the core by popular demand. The goal of >> the incubator is to let the app developers try the new feature out. >> >> **References** >> >> - Proposal: >> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/RichTextArea/RichTextArea.md >> - Discussion points: >> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/RichTextArea/RichTextAreaDiscussion.md >> - API specification (javadoc): >> https://cr.openjdk.org/~angorya/RichTextArea/javadoc >> - RichTextArea RFE: https://bugs.openjdk.org/browse/JDK-8301121 >> - Behavior doc: >> https://github.com/andy-goryachev-oracle/jfx/blob/8301121.RichTextArea/doc-files/behavior/RichTextAreaBehavior.md >> - CSS Reference: >> https://cr.openjdk.org/~angorya/RichTextArea/javadoc/javafx.graphics/javafx/scene/doc-files/cssref.html >> - InputMap (v3): >> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/InputMap/InputMapV3.md >> - Previous Draft PR: https://github.com/openjdk/jfx/pull/1374 > > Andy Goryachev has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 41 commits: > > - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea > - break iterator > - consume conditionally > - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea > - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea > - ask to save on closing window > - line numbers, highlight paragraph menus > - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea > - whitespace > - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea > - ... and 31 more: https://git.openjdk.org/jfx/compare/dc5df6c1...faabd11e modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/model/BasicTextModel.java line 52: > 50: /** > 51: * Returns the number of paragraphs in this content. > 52: * @return number of text lines Method description says it returns number of paragraphs but return value says it returns lines. What about document with multi-line paragraphs? What will the return value be? modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/model/BasicTextModel.java line 159: > 157: @Override > 158: public final boolean isWritable() { > 159: return content.isUserEditable(); Just curious why it is editable in some places but writable in other? Again, description says user-editable name says writable. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1524#discussion_r1819928728 PR Review Comment: https://git.openjdk.org/jfx/pull/1524#discussion_r1819929510
