On Mon, 28 Oct 2024 20:00:02 GMT, Kevin Rushforth <k...@openjdk.org> wrote:

>> I don't indent case labels inside of switch.
>> I don't think we enforce one way or the other.
>> 
>> And you can't ask to make it more compact and then complain that it's more 
>> compact /jk
>
>> I don't indent case labels inside of switch.
> 
> Our typical code style is to indent. I don't have a strong preference, but I 
> switched (pun intended) many years ago from not indenting to always indenting 
> because: A) the IDEs (at least most of them) indent by default; B) most of 
> the code in the JDK and JavaFX does.
> 
>> I don't think we enforce one way or the other.
> 
> No, we don't. Feel free to leave it as you have it.

This is a bit silly.  You have an opening brace, you should be indenting as you 
would in every other case when an opening brace appears and you break off the 
line.  So unless there is a **really** good reason to suddenly not do so that 
has to do with readability, I think this is an really odd stand to take.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1604#discussion_r1819858059

Reply via email to