On Wed, 23 Oct 2024 09:36:56 GMT, Ajit Ghaisas <aghai...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> break iterator > > modules/jfx.incubator.richtext/src/main/java/com/sun/jfx/incubator/scene/control/richtext/HighlightShape.java > line 72: > >> 70: PathElement[] pe = f.underlineShape(start, end); >> 71: return generateSquiggly(pe); >> 72: default: > > case UNDERLINE also should be added to default:? this code path will never execute. changed to return an empty array. > modules/jfx.incubator.richtext/src/main/java/com/sun/jfx/incubator/scene/control/richtext/RTAccessibilityHelper.java > line 51: > >> 49: } >> 50: >> 51: // FIX remove > > To be removed? to be removed ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1524#discussion_r1819877421 PR Review Comment: https://git.openjdk.org/jfx/pull/1524#discussion_r1819878692
