On Fri, 11 Oct 2024 10:57:34 GMT, Lukasz Kostyra <lkost...@openjdk.org> wrote:
> This PR adds a title-mentioned fallback to `ImageStorage.java` and a test for > that specific scenario. > > In `ImageStorage.loadAll()` we still prefer the Image path that was provided > by the user, but if it is missing we will now try to add a `@1x` suffix to > Image name and give it one last try. > > Added test includes a binary file `check...@1x.png`. This was added to > differentiate it from the collection of `checker.png` files and their higher > scale variants, but it is a direct copy of already existing `checker.png` > test resource, just with a different name and suffix. Test should fail > without a change in `ImageStorage.java` and pass with it. This pull request has now been integrated. Changeset: e128382f Author: Lukasz Kostyra <lkost...@openjdk.org> URL: https://git.openjdk.org/jfx/commit/e128382fa305bb0a50b1f9fbb90f5237f9a0f9c5 Stats: 53 lines in 5 files changed: 51 ins; 0 del; 2 mod 8329098: Support "@1x" image naming convention as fallback Reviewed-by: kcr, jhendrikx, mstrauss ------------- PR: https://git.openjdk.org/jfx/pull/1598
