Finally getting to this. To add to what Michael said about the development
process, there are many large ongoing efforts in various stages (interest
gathering, proposals, discussions, PRs...) that require a lot of investment
from the maintainers. From the top of my head: various CSS changes +
reimp
On Sun, 15 Sep 2024 12:31:03 GMT, Jay Bhaskar wrote:
> Successfully converted web tests from JUnit 4 to JUnit 5, ensuring all tests
> are fully compliant with the JUnit 5 framework.
This pull request has now been integrated.
Changeset: e81b6766
Author:Jay Bhaskar
URL:
https://git.o
On Mon, 16 Sep 2024 17:57:07 GMT, Andy Goryachev wrote:
> Converting system tests to junit5.
>
> Please see migration notes:
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Tests/JUnit5Migration.md
>
> ### Notes:
>
> I see shutdown timeout on linux, this will be addressed by
> [
On Mon, 16 Sep 2024 17:57:07 GMT, Andy Goryachev wrote:
> Converting system tests to junit5.
>
> Please see migration notes:
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Tests/JUnit5Migration.md
>
> ### Notes:
>
> I see shutdown timeout on linux, this will be addressed by
> [
On Wed, 18 Sep 2024 20:04:47 GMT, Andy Goryachev wrote:
>> my mistake. switched to the Timeout annotation.
>
> fixed
Thanks for fixing this. Btw, I see a few now-used imports of
`org.junit.jupiter.api.Assertions.assertTimeout`.
-
PR Review Comment: https://git.openjdk.org/jfx/pul
On Fri, 13 Sep 2024 15:14:39 GMT, Lukasz Kostyra wrote:
> This PR converts all tests in `modules/javafx.graphics` to use JUnit5.
>
> ## Details
>
> Trivial changes resolved by first four commits:
> - Import changes to use `org.junit.jupiter` package instead of `org.junit` or
> `junit.framework
On Tue, 17 Sep 2024 13:48:50 GMT, Jay Bhaskar wrote:
>> Successfully converted web tests from JUnit 4 to JUnit 5, ensuring all tests
>> are fully compliant with the JUnit 5 framework.
>
> Jay Bhaskar has updated the pull request incrementally with one additional
> commit since the last revision
On Wed, 18 Sep 2024 00:20:39 GMT, Kevin Rushforth wrote:
>> Converting system tests to junit5.
>>
>> Please see migration notes:
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Tests/JUnit5Migration.md
>>
>> ### Notes:
>>
>> I see shutdown timeout on linux, this will be addresse
On Wed, 18 Sep 2024 15:31:40 GMT, Andy Goryachev wrote:
>> tests/system/src/test/java/test/com/sun/javafx/application/ConcurrentStartupTest.java
>> line 46:
>>
>>> 44: @Test
>>> 45: public void testStartupReturnBeforeRunnableComplete() {
>>> 46: assertTimeout(Duration.ofMillis(1
On Wed, 18 Sep 2024 00:20:39 GMT, Kevin Rushforth wrote:
>> Converting system tests to junit5.
>>
>> Please see migration notes:
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Tests/JUnit5Migration.md
>>
>> ### Notes:
>>
>> I see shutdown timeout on linux, this will be addresse
On Mon, 16 Sep 2024 17:57:07 GMT, Andy Goryachev wrote:
> Converting system tests to junit5.
>
> Please see migration notes:
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Tests/JUnit5Migration.md
>
> ### Notes:
>
> I see shutdown timeout on linux, this will be addressed by
> [
Converting system tests to junit5.
Please see migration notes:
https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Tests/JUnit5Migration.md
### Notes:
I see shutdown timeout on linux, this will be addressed by
[JDK-8340403](https://bugs.openjdk.org/browse/JDK-8340403)
QPathTest > execu
John,
Sorry I didn’t respond to this thread earlier. I’ve been looking at the code
and bug database trying to work backward to a problem statement. The bug
reports cited in the PR are light on details so I’m trying to come up with a
more concrete set of use cases to consider.
Currently I’m fai
On Wed, 18 Sep 2024 15:25:47 GMT, Lukasz Kostyra wrote:
>> This PR migrates RenderPerf performance test application from jfx-sandbox
>> metal branch:
>> https://github.com/openjdk/jfx-sandbox/tree/metal/tests/performance/animation/RenderPerfTest/src/renderperf
>>
>> RenderPerf is a performance
> Converting control module tests to junit5.
>
> The following notes might help reviewers and people migrating other parts of
> https://bugs.openjdk.org/browse/JDK-8339170. The direct link to the notes:
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Tests/JUnit5Migration.md
>
> #
On Wed, 18 Sep 2024 13:22:45 GMT, Marius Hanl wrote:
>> Yes, please. I made a similar comment on Draft PR #1569
>
> Agree, would be good to be consistent, especially now, where we anyway
> convert everything to JUnit 5 and have the chance to be consistent.
yep, for some reason I incorrectly dec
> This PR migrates RenderPerf performance test application from jfx-sandbox
> metal branch:
> https://github.com/openjdk/jfx-sandbox/tree/metal/tests/performance/animation/RenderPerfTest/src/renderperf
>
> RenderPerf is a performance test application which draws provided number of
> "particles"
On Sun, 15 Sep 2024 13:06:41 GMT, Marius Hanl wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 16 additional
>> commits
This PR converts all tests in `modules/javafx.graphics` to use JUnit5.
## Details
Trivial changes resolved by first four commits:
- Import changes to use `org.junit.jupiter` package instead of `org.junit` or
`junit.framework` and all changes that follow it (ex. `@Before` ->
`@BeforeEach`)
- Mes
Oh, sorry, I did not mean to ignore your comments. I should have mentioned we
are having a bi-annual "test sprint" and work exclusively on the test suite.
You made a lot of good comments that require some thought and careful
consideration, for which I simply had no spare CPU cycles last week o
On Tue, 17 Sep 2024 15:33:06 GMT, Jayathirth D V wrote:
> This PR is for open-sourcing 2 closed toys EmbeddedSwing and HelloWorld.
> JBS : https://bugs.openjdk.org/browse/JDK-8211234
>
> 1)EmbeddedSwing - a simple FX test app with a SwingNode containing a Swing
> application
>
> 2)HelloWorld c
On Wed, 18 Sep 2024 14:00:24 GMT, Kevin Rushforth wrote:
> Ah, never mind. I see that you already resolved the conflict. I'll re-review
> then.
Yes Kevin, i was pushing the changes one after another because i was also
suspecting merge conflict in apps/toys/build.xml
-
PR Comment:
> This PR is for open-sourcing 2 closed toys EmbeddedSwing and HelloWorld.
> JBS : https://bugs.openjdk.org/browse/JDK-8211234
>
> 1)EmbeddedSwing - a simple FX test app with a SwingNode containing a Swing
> application
>
> 2)HelloWorld contains 2 test apps :
>
> - HelloJFXPanel - a simple Swin
On Wed, 18 Sep 2024 14:02:20 GMT, Jayathirth D V wrote:
>> This PR is for open-sourcing 2 closed toys EmbeddedSwing and HelloWorld.
>> JBS : https://bugs.openjdk.org/browse/JDK-8211234
>>
>> 1)EmbeddedSwing - a simple FX test app with a SwingNode containing a Swing
>> application
>>
>> 2)Hello
On Tue, 17 Sep 2024 15:33:06 GMT, Jayathirth D V wrote:
> This PR is for open-sourcing 2 closed toys EmbeddedSwing and HelloWorld.
> JBS : https://bugs.openjdk.org/browse/JDK-8211234
>
> 1)EmbeddedSwing - a simple FX test app with a SwingNode containing a Swing
> application
>
> 2)HelloWorld c
On Wed, 18 Sep 2024 11:09:29 GMT, Kevin Rushforth wrote:
>> modules/javafx.controls/src/test/java/test/javafx/scene/chart/NumberAxisTest.java
>> line 261:
>>
>>> 259: @Test
>>> 260: public void testCloseValues() {
>>> 261: assertTimeout(Duration.ofMillis(1000), () -> {
>>
>> Co
On Mon, 16 Sep 2024 18:45:45 GMT, Hima Bindu Meda wrote:
> Updated additional webkit-619.1 fixes from webkitgtk-2.44.4. Build is
> successful on all platforms.No issues seen
All my testing looks good. The code changes look good with one question that I
left.
modules/javafx.web/src/main/native
On Wed, 18 Sep 2024 03:50:17 GMT, Ambarish Rapte wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 16 additional
>> commi
On Tue, 17 Sep 2024 14:29:11 GMT, Jayathirth D V wrote:
> This PR is for open-sourcing HelloFXCanvas test app.
> JBS : https://bugs.openjdk.org/browse/JDK-8211247
> It is an SWT app with SWT button and an FXCanvas with animated rectangle.
> This is used on our integration testing.
>
> This test
On Tue, 17 Sep 2024 13:48:50 GMT, Jay Bhaskar wrote:
>> Successfully converted web tests from JUnit 4 to JUnit 5, ensuring all tests
>> are fully compliant with the JUnit 5 framework.
>
> Jay Bhaskar has updated the pull request incrementally with one additional
> commit since the last revision
On Tue, 17 Sep 2024 14:29:11 GMT, Jayathirth D V wrote:
> This PR is for open-sourcing HelloFXCanvas test app.
> JBS : https://bugs.openjdk.org/browse/JDK-8211247
> It is an SWT app with SWT button and an FXCanvas with animated rectangle.
> This is used on our integration testing.
>
> This test
31 matches
Mail list logo
