Converting system tests to junit5.

Please see migration notes:
https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Tests/JUnit5Migration.md

### Notes:

I see shutdown timeout on linux, this will be addressed by 
[JDK-8340403](https://bugs.openjdk.org/browse/JDK-8340403)

QPathTest > executionError FAILED
    org.opentest4j.AssertionFailedError: Exceeded timeout limit of 10000 msec
        at 
app//org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:39)
        at app//org.junit.jupiter.api.Assertions.fail(Assertions.java:134)
        at app//test.util.Util.runAndWait(Util.java:156)
        at app//test.util.Util.runAndWait(Util.java:127)
        at app//test.util.Util.shutdown(Util.java:365)
        at app//test.com.sun.marlin.QPathTest.teardownOnce(QPathTest.java:146)


This test might fail intermittently (?) on linux only:

SetSceneScalingTest > testShowAndSetScene() FAILED
    org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
        at 
app//org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
        at app//org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:40)
        at app//org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:35)
        at app//org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:179)
        at 
app//test.robot.javafx.stage.SetSceneScalingTest$TestShowSetSceneApp.test(SetSceneScalingTest.java:129)
        at 
app//test.robot.javafx.stage.SetSceneScalingTest$TestApp.runTest(SetSceneScalingTest.java:89)
        at 
app//test.robot.javafx.stage.SetSceneScalingTest.testShowAndSetScene(SetSceneScalingTest.java:193)

-------------

Commit messages:
 - fixes 4
 - fixes 3
 - fixes 2
 - fixes 1
 - part 12 last
 - fixes
 - part 11 scene
 - part 10 swing
 - part 9 monocle
 - Merge remote-tracking branch 'origin/master' into 8339510.junit5.system
 - ... and 9 more: https://git.openjdk.org/jfx/compare/5993c09e...96cd1972

Changes: https://git.openjdk.org/jfx/pull/1569/files
  Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1569&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8339510
  Stats: 5070 lines in 276 files changed: 916 ins; 948 del; 3206 mod
  Patch: https://git.openjdk.org/jfx/pull/1569.diff
  Fetch: git fetch https://git.openjdk.org/jfx.git pull/1569/head:pull/1569

PR: https://git.openjdk.org/jfx/pull/1569

Reply via email to