@Nir Lisker Do you mind taking a look, and maybe
helping answer some of my questions? I'm just not getting any replies, so
I'm somewhat confused.
ALSO, unrelated, I'm hoping to pick up the PR you dropped before:
https://github.com/openjdk/jfx/pull/1281
What would be the process for me taking over
On Mon, 9 Sep 2024 19:36:29 GMT, Andy Goryachev wrote:
> Further additions to the MonkeyTester application:
>
> - tree/table view column property sheets ✔
> - new pages: button, checkbox, hyperlink, menu bar, radio button, toggle
> button, canvas, split menu button, dnd ✔
> - properties... cont
On Mon, 9 Sep 2024 19:36:29 GMT, Andy Goryachev wrote:
> Further additions to the MonkeyTester application:
>
> - tree/table view column property sheets ✔
> - new pages: button, checkbox, hyperlink, menu bar, radio button, toggle
> button, canvas, split menu button, dnd ✔
> - properties... cont
On Mon, 9 Sep 2024 06:23:02 GMT, John Hendrikx wrote:
> This PR removes the pausing logic from AbstractPrimaryTimer. The test that
> is using it wasn't actually testing anything in AbstractPrimaryTimer itself,
> and no other code needs this pausing code.
Good cleanup. Without digging a bit mo
On Mon, 9 Sep 2024 16:47:21 GMT, Ambarish Rapte wrote:
> Following 2 warnings are observed with the JavaFX build.
> These warnings need to be addressed for updating to Gradle 9.0 in future.
>
> 1. The org.gradle.api.plugins.JavaPluginConvention type has been deprecated.
> This is scheduled to
On Mon, 9 Sep 2024 06:23:02 GMT, John Hendrikx wrote:
> This PR removes the pausing logic from AbstractPrimaryTimer. The test that
> is using it wasn't actually testing anything in AbstractPrimaryTimer itself,
> and no other code needs this pausing code.
Looks good.
-
Marked as
On Mon, 9 Sep 2024 16:47:21 GMT, Ambarish Rapte wrote:
> Following 2 warnings are observed with the JavaFX build.
> These warnings need to be addressed for updating to Gradle 9.0 in future.
>
> 1. The org.gradle.api.plugins.JavaPluginConvention type has been deprecated.
> This is scheduled to
On Mon, 9 Sep 2024 06:23:02 GMT, John Hendrikx wrote:
> This PR removes the pausing logic from AbstractPrimaryTimer. The test that
> is using it wasn't actually testing anything in AbstractPrimaryTimer itself,
> and no other code needs this pausing code.
nice cleanup!
-
Marked a
Further additions to the MonkeyTester application:
- tree/table view column property sheets ✔
- new pages: button, checkbox, hyperlink, menu bar, radio button, toggle
button, canvas, split menu button, dnd ✔
- properties... context menu ✔
- context menu: table columns, toolbar items ✔
- control.c
On Tue, 4 Apr 2023 15:22:48 GMT, John Hendrikx wrote:
> This provides and uses a new implementation of `ExpressionHelper`, called
> `ListenerManager` with improved semantics.
>
> # Behavior
>
> |Listener...|ExpressionHelper|ListenerManager|
> |---|---|---|
> |Invocation Order|In order they wer
This PR removes the pausing logic from AbstractPrimaryTimer. The test that is
using it wasn't actually testing anything in AbstractPrimaryTimer itself, and
no other code needs this pausing code.
-
Commit messages:
- Remove unused code
Changes: https://git.openjdk.org/jfx/pull/155
Public APIs for focus traversal and the focus traversal policy:
https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal.md
This work is loosely based on the patch
https://cr.openjdk.org/~jgiles/8061673/
-
Commit messages:
- Merge remote-tracking br
On Mon, 9 Sep 2024 16:33:31 GMT, Kevin Rushforth wrote:
>> I don't think that would matter much. This error will only ever be
>> interpreted by programmers, I'm sure they'll be able to understand what's
>> going on.
>
> Agreed. This should never happen, and if it does, the difference between a
On Mon, 2 Sep 2024 12:45:02 GMT, John Hendrikx wrote:
>> Moves `SimpleSelector` and `CompoundSelector` to internal packages.
>>
>> This can be done with only a minor API break, as `SimpleSelector` and
>> `CompoundSelector` were public before. However, these classes could not be
>> constructed
Following 2 warnings are observed with the JavaFX build.
These warnings need to be addressed for updating to Gradle 9.0 in future.
1. The org.gradle.api.plugins.JavaPluginConvention type has been deprecated.
This is scheduled to be removed in Gradle 9.0. Consult the upgrading guide for
further
On Mon, 9 Sep 2024 16:29:25 GMT, John Hendrikx wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/css/BinarySerializer.java
>> line 109:
>>
>>> 107:
>>> 108: if (type != TYPE_SIMPLE) {
>>> 109: throw new IllegalStateException("Expected compound
>>> sele
On Tue, 3 Sep 2024 16:47:12 GMT, Andy Goryachev wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reject CSS where compound selectors don't consist of simple selectors
>
> modules/javafx.graphics/src/main/java/com/s
> Incubating a new feature - rich text control, **RichTextArea**, intended to
> bridge the functional gap with Swing and its StyledEditorKit/JEditorPane. The
> main design goal is to provide a control that is complete enough to be useful
> out-of-the box, as well as open to extension by the appl
On Fri, 6 Sep 2024 22:08:05 GMT, Kevin Rushforth wrote:
> This method seems redundant: `fromInlineStyle(style)` and `fromStyles(style)`
> are equivalent. Do we need both?
These are not the same.
`fromInlineStyle(String)` accepts as single string containing fx-style CSS with
one more more styl
On Fri, 6 Sep 2024 21:57:16 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 12 additional
>> commi
On Fri, 6 Sep 2024 21:44:39 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 12 additional
>> commi
On Fri, 6 Sep 2024 21:42:25 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 12 additional
>> commi
On Mon, 2 Sep 2024 12:45:02 GMT, John Hendrikx wrote:
>> Moves `SimpleSelector` and `CompoundSelector` to internal packages.
>>
>> This can be done with only a minor API break, as `SimpleSelector` and
>> `CompoundSelector` were public before. However, these classes could not be
>> constructed
On Sun, 8 Sep 2024 20:55:53 GMT, Michael Strauß wrote:
>> This PR completes the CSS Transitions story (see #870) by adding
>> interpolation support for backgrounds and borders, making them targetable by
>> transitions.
>>
>> `Background` and `Border` objects are deeply immutable, but not
>> i
24 matches
Mail list logo
