On Fri, 6 Sep 2024 21:42:25 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 12 additional >> commits since the last revision: >> >> - fixes and review comments >> - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea >> - improved vertical scrolling >> - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea >> - cleanup >> - navigation >> - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea >> - whitespace >> - update + review comments >> - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea >> - ... and 2 more: https://git.openjdk.org/jfx/compare/60aa6171...bc1615c0 > > modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/RichTextArea.java > line 1076: > >> 1074: * When selection exists, deletes selected text. Otherwise, >> deletes the character preceding the caret, >> 1075: * possibly breaking up the grapheme clusters. >> 1076: * This method does nothing if either control or the model is not >> editable, or the caret position is {@code null}. > > Suggestion for here and similar methods: > > "does nothing if the control is not editable or the model is not writable..." changed this and similar methods to throw an exception ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1524#discussion_r1750448259
