On Tue, 3 Sep 2024 16:47:12 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reject CSS where compound selectors don't consist of simple selectors
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/css/BinarySerializer.java
> line 109:
>
>> 107:
>> 108: if (type != TYPE_SIMPLE) {
>> 109: throw new IllegalStateException("Expected compound
>> selector to consist of simple selectors only, but found type: " + type);
>
> minor: the output will be a signed decimal. would it be better if this can
> be formatted as hex?
>
> `String.format("Expected compound selector to consist of TYPE_SIMPLE only,
> but found type: 0x%02X", type)`
I don't think that would matter much. This error will only ever be interpreted
by programmers, I'm sure they'll be able to understand what's going on.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1333#discussion_r1750569742
