On Fri, 6 Sep 2024 21:44:39 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 12 additional >> commits since the last revision: >> >> - fixes and review comments >> - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea >> - improved vertical scrolling >> - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea >> - cleanup >> - navigation >> - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea >> - whitespace >> - update + review comments >> - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea >> - ... and 2 more: https://git.openjdk.org/jfx/compare/9ac571eb...bc1615c0 > > modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/RichTextArea.java > line 1030: > >> 1028: * sequences result in a new paragraph being added. >> 1029: * <p> >> 1030: * This method is no-op if either the control or the model is not >> editable. It is up to the model > > This method doesn't depend on the editable state of the control at all, and > will now throw and exception if the module is null or not writable. > > This applies to the other programmatic editing methods, too: > `appendText(StyledInput)`, `insertText()`, `replaceText()`, `applyStyle()`, > `setStyle()`, and `clear()`. fixed > modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/RichTextArea.java > line 1088: > >> 1086: /** >> 1087: * Clears the document, creating an undo entry. >> 1088: * This method does nothing if either control or the model is not >> editable. > > Remove this sentence and add the needed `@throws` done > modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/RichTextArea.java > line 2096: > >> 2094: * might be wider than one specified. >> 2095: * <p> >> 2096: * This method does nothing if either control or the model is not >> editable. > > Remove this sentence. done ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1524#discussion_r1750482524 PR Review Comment: https://git.openjdk.org/jfx/pull/1524#discussion_r1750483779 PR Review Comment: https://git.openjdk.org/jfx/pull/1524#discussion_r1750483101
