On Fri, 17 May 2024 15:32:10 GMT, Thiago Milczarek Sayao
wrote:
> I got some requests to reopen it. So, reopening.
>
> Feedback is welcome.
Thank you so much for reopening the PR. We truly appreciate your responsiveness
and commitment to improving this project. Your efforts make a significant
On Fri, 19 Apr 2024 18:10:32 GMT, Andy Goryachev wrote:
>> ## ManualTestWindow
>>
>> This facility provides the base class for manual tests which displays the
>> test instructions,
>> the UI under test, and the Pass/Fail buttons.
>>
>> Example:
>>
>>
>> public class ManualTestExample extends
> ## ManualTestWindow
>
> This facility provides the base class for manual tests which displays the
> test instructions,
> the UI under test, and the Pass/Fail buttons.
>
> Example:
>
>
> public class ManualTestExample extends ManualTestWindow {
> public ManualTestExample() {
> sup
On Sun, 18 Feb 2024 23:10:12 GMT, Thiago Milczarek Sayao
wrote:
>> This replaces obsolete XIM and uses gtk api for IME.
>> Gtk uses [ibus](https://github.com/ibus/ibus)
>>
>> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative
>> positioning on `InputMethodRequest`.
>>
On Fri, 17 May 2024 15:36:27 GMT, Andy Goryachev wrote:
>> This change replaces Character.isLetterOrDigit(char) which fails with
>> surrogate characters with Character.isLetterOrDigit(int).
>
> Andy Goryachev has updated the pull request with a new target base due to a
> merge or a rebase. The
On Fri, 17 May 2024 15:36:27 GMT, Andy Goryachev wrote:
>> This change replaces Character.isLetterOrDigit(char) which fails with
>> surrogate characters with Character.isLetterOrDigit(int).
>
> Andy Goryachev has updated the pull request with a new target base due to a
> merge or a rebase. The
On Fri, 17 May 2024 08:07:58 GMT, Ambarish Rapte wrote:
> `hoverSquare`'s visible property is not initialized in the `ColorPalette`
> constructor.
thank you for reviewing, @arapte !
effectively, yes, and that's the issue I have fixed, by explicitly setting
visibility in `setFocusedSquare()` (
On Fri, 17 May 2024 07:28:44 GMT, Florian Kirmaier
wrote:
>> As seen in the unit test of the PR, when we click on the area above/below
>> the scrollbar the position jumps - but the jump is now not always consistent.
>> In the current version on the last cell - the UI always jumps to the top. In
On Fri, 17 May 2024 08:45:43 GMT, Ambarish Rapte wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains two additional
>> comm
> This change replaces Character.isLetterOrDigit(char) which fails with
> surrogate characters with Character.isLetterOrDigit(int).
Andy Goryachev has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by
On Sun, 18 Feb 2024 23:10:12 GMT, Thiago Milczarek Sayao
wrote:
>> This replaces obsolete XIM and uses gtk api for IME.
>> Gtk uses [ibus](https://github.com/ibus/ibus)
>>
>> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative
>> positioning on `InputMethodRequest`.
>>
On Wed, 15 May 2024 21:05:33 GMT, Andy Goryachev wrote:
> In the context of the recent discussion on the mailing list, would it be
> possible to actually detect the keyboard layout?
I answered this question in full on the mailing list but will provide a summary
here. There's no documented way
On Fri, 17 May 2024 14:58:41 GMT, Nir Lisker wrote:
>> Kevin Rushforth has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 20 additional
>> commits
On Fri, 17 May 2024 14:10:43 GMT, Kevin Rushforth wrote:
>> Update the code review guidelines for JavaFX.
>>
>> The JavaFX
>> [CONTRIBUTING](https://github.com/kevinrushforth/jfx/blob/8332313-contributing/CONTRIBUTING.md)
>> guidelines includes guidance for creating, reviewing, and integrating
On Fri, 17 May 2024 14:55:18 GMT, Kevin Rushforth wrote:
>> Update the code review guidelines for JavaFX.
>>
>> The JavaFX
>> [CONTRIBUTING](https://github.com/kevinrushforth/jfx/blob/8332313-contributing/CONTRIBUTING.md)
>> guidelines includes guidance for creating, reviewing, and integrating
> Update the code review guidelines for JavaFX.
>
> The JavaFX
> [CONTRIBUTING](https://github.com/kevinrushforth/jfx/blob/8332313-contributing/CONTRIBUTING.md)
> guidelines includes guidance for creating, reviewing, and integrating
> changes to JavaFX, along with a pointer to a [Code Review
>
Mark,
> I iterate over each key in that set, sending that keycode to a text
> field. I then do the same for each keycode but with the shift key held.
> I don't doubt that it could cause havoc in some setups!
On a German or Spanish layout on the Mac BACK_QUOTE will invoke a dead key and
throw eve
On Fri, 17 May 2024 14:10:43 GMT, Kevin Rushforth wrote:
>> Update the code review guidelines for JavaFX.
>>
>> The JavaFX
>> [CONTRIBUTING](https://github.com/kevinrushforth/jfx/blob/8332313-contributing/CONTRIBUTING.md)
>> guidelines includes guidance for creating, reviewing, and integrating
On Wed, 15 May 2024 22:18:24 GMT, Kevin Rushforth wrote:
>> README-code-reviews.md line 79:
>>
>>> 77: * All Reviewers who have requested the chance to review have done so
>>> (or indicated that they are OK with it going in without their review). In
>>> rare cases a Project Lead may override t
On Thu, 16 May 2024 07:27:34 GMT, Johan Vos wrote:
>> That's a good idea.
>
> In the ideal world where we have tons of regression and compatibility tests,
> I would agree. Unfortunately, we are totally not there yet. Compared to other
> projects, the quality of tests in OpenJFX is good, but giv
On Wed, 15 May 2024 18:30:06 GMT, Andy Goryachev wrote:
>> Kevin Rushforth has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 20 additional
>> comm
On Wed, 15 May 2024 19:38:55 GMT, Kevin Rushforth wrote:
>> README-code-reviews.md line 64:
>>
>>> 62:
>>> 63: * Make sure you understand why there was an issue to begin with, and
>>> why/how the proposed PR solves the issue
>>> 64: * Focus first on substantive comments rather than stylistic c
On Wed, 15 May 2024 22:00:42 GMT, Kevin Rushforth wrote:
>> I think it worth noting that in skara syntax that isn't two people with the
>> reviewer role.
>> And tell people what to use if that is what they intend - eg if I have it
>> right
>
> It's `/reviewers 2 reviewers`, so I'll add that as
On Wed, 15 May 2024 21:58:46 GMT, Kevin Rushforth wrote:
>> README-code-reviews.md line 14:
>>
>>> 12: ### Reviewers
>>> 13:
>>> 14: The [List of Reviewers](https://openjdk.java.net/census#openjfx) is on
>>> the OpenJDK Census.
>>
>> We use ".org" now, not ".java.net"
>
> Yes, I missed this.
On Wed, 15 May 2024 22:13:34 GMT, Kevin Rushforth wrote:
>>> or is it? :-)
>>
>> 
>>
>> Looks to me like it is...
>
> A passing GHA test run is neither necessary nor sufficient. It is an
> interesting
On Wed, 15 May 2024 22:10:12 GMT, Kevin Rushforth wrote:
> > ...inadvertent introduction of new API (that will have to be deprecated if
> > missed)
>
> I think this is worth mentioning.
Fixed.
-
PR Review Comment: https://git.openjdk.org/jfx/pull/1455#discussion_r1605063298
On Wed, 15 May 2024 22:05:46 GMT, Kevin Rushforth wrote:
>> README-code-reviews.md line 60:
>>
>>> 58: * If you want an area expert to review a PR, indicate this in a comment
>>> of the form: `Reviewers: @PERSON1 @PERSON2`; the requested reviewers can
>>> indicate whether or not they plan to r
On Wed, 15 May 2024 21:57:55 GMT, Kevin Rushforth wrote:
>> exactly my point. when the majority of time is spent in the context of
>> github (PR review etc) it might be confusing when one types `@jvos` and it's
>> not found, or when within a PR there are references to both `jvos` and
>> `joha
> Update the code review guidelines for JavaFX.
>
> The JavaFX
> [CONTRIBUTING](https://github.com/kevinrushforth/jfx/blob/8332313-contributing/CONTRIBUTING.md)
> guidelines includes guidance for creating, reviewing, and integrating
> changes to JavaFX, along with a pointer to a [Code Review
>
On Thu, 16 May 2024 08:48:14 GMT, John Hendrikx wrote:
>> I agree with the concern, but I still think it's much better to encourage
>> developers to do formatting in a separate issue (or not at all) with all the
>> required administration, than to sneak in a formatting change in a PR that
>> h
On Fri, 17 May 2024 13:21:36 GMT, John Hendrikx wrote:
> At a minimum I think the tests that are part of this PR should be included in
> FX whichever fix ends up being integrated.
The test has already been added to both PRs.
> I'm only wondering if the code in ``paintImpl`` should always clear
On Mon, 6 May 2024 14:14:05 GMT, eduardsdv wrote:
> This is an alternative solution to the PR:
> https://github.com/openjdk/jfx/pull/1310.
>
> This solution is based on the invariant that if a node is marked as dirty,
> all ancestors must also be marked as dirty and that if an ancestor is mark
On Fri, 3 May 2024 10:23:27 GMT, Florian Kirmaier wrote:
>> In some situations, a part of the SG is no longer rendered.
>> I created a test program that showcases this problem.
>>
>> Explanation:
>>
>> This can happen, when a part of the SG, is covered by another Node.
>> In this part, one node
On Thu, 16 May 2024 22:23:40 GMT, Kevin Rushforth wrote:
> Clean backport of Linux GHA fix to jfx22u (so we can get clean GHA runs for
> future 22u backports)
This pull request has now been integrated.
Changeset: e7545c6c
Author:Kevin Rushforth
URL:
https://git.openjdk.org/jfx22u/c
On Fri, 19 Apr 2024 20:36:42 GMT, Andy Goryachev wrote:
>> This change replaces Character.isLetterOrDigit(char) which fails with
>> surrogate characters with Character.isLetterOrDigit(int).
>
> Andy Goryachev has updated the pull request with a new target base due to a
> merge or a rebase. The
On Thu, 16 May 2024 18:30:17 GMT, Andy Goryachev wrote:
> Root cause: premature 'return' from initialization code leaves the hover
> square visible, even when it should be hidden, as the case is when the color
> value is not present in the palette.
>
> - added unit tests
Fix looks good, I thi
On Thu, 16 May 2024 19:36:00 GMT, Kevin Rushforth wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8323511: Adjust javadoc of the getViewportLength()
>
> modules/javafx.controls/src/main/java/javafx/scene/co
> As seen in the unit test of the PR, when we click on the area above/below the
> scrollbar the position jumps - but the jump is now not always consistent.
> In the current version on the last cell - the UI always jumps to the top. In
> the other cases, the assumed default cell height is used.
>
On Fri, 17 May 2024 07:23:45 GMT, Florian Kirmaier
wrote:
>> As seen in the unit test of the PR, when we click on the area above/below
>> the scrollbar the position jumps - but the jump is now not always consistent.
>> In the current version on the last cell - the UI always jumps to the top. In
> As seen in the unit test of the PR, when we click on the area above/below the
> scrollbar the position jumps - but the jump is now not always consistent.
> In the current version on the last cell - the UI always jumps to the top. In
> the other cases, the assumed default cell height is used.
>
40 matches
Mail list logo
