On Fri, 17 May 2024 08:45:43 GMT, Ambarish Rapte <ara...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains two additional
>> commits since the last revision:
>>
>> - Merge branch 'master' into 8330590.prev.word
>> - 8330590 TextInputControl: previous word fails with Bhojpuri characters
>
> modules/javafx.controls/src/main/java/javafx/scene/control/TextInputControl.java
> line 1745:
>
>> 1743: }
>> 1744:
>> 1745: private static boolean isLetterOrDigit(String text, int ix, int
>> len) {
>
> The `len` variable is unused in this method.
fixed, thank you
> modules/javafx.controls/src/main/java/javafx/scene/control/TextInputControl.java
> line 1751:
>
>> 1749: } else if (ix >= text.length()) {
>> 1750: return false;
>> 1751: }
>
> May be combine them into single if statement.
> Or may be remove the checks as this is a private method.
I prefer to keep one statement per line; the checks are needed here.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1444#discussion_r1605201603
PR Review Comment: https://git.openjdk.org/jfx/pull/1444#discussion_r1605203032
